[GitHub] [apisix] spacewander commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level

[GitBox]

spacewander commented on a change in pull request #5839:
URL: https://github.com/apache/apisix/pull/5839#discussion_r771942631



##
File path: apisix/plugins/google-cloud-logging/oauth.lua
##
@@ -111,10 +111,10 @@ function _M:new(config)
 access_token_expire_time = 0,
 }
 
-if config.ssl_verify == false then
-oauth.ssl_verify = config.ssl_verify
-else
+if ssl_verify == true then
 oauth.ssl_verify = true

Review comment:
   Why not `oauth.ssl_verify = ssl_verify` directly? The ssl_verify can't 
be nil.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level

[GitBox]

spacewander commented on a change in pull request #5839:
URL: https://github.com/apache/apisix/pull/5839#discussion_r771132235



##
File path: apisix/plugins/google-cloud-logging.lua
##
@@ -162,6 +163,7 @@ local function get_auth_config(config)
 end
 
 auth_config_cache = config_data
+auth_config_cache.ssl_verify = conf.ssl_verify

Review comment:
   It seems the ssl_verify will be cached with the auth configuration. So 
changing the ssl_verify won't take effect immediately.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org