[GitHub] [apisix] spacewander commented on pull request #3624: feat: add pre-commit framework
spacewander commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-833214517 @jbampton If you want your PR to be accepted, please limit its scope. If you keep adding new things with `force push` which destroys the history, I can't trust you and leave approval (as you may add new things just after I have reviewed it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3624: feat: add pre-commit framework
spacewander commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-782997965 We are not a Python project. Can it fix the markdown / yaml automatically? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3624: feat: add pre-commit framework
spacewander commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-782981097 The pre-commit framework is good. But does it add any value as we already check them in the CI? There are many duplicate rules between this framework and the CI files. I don't want to increase the maintain burden and make amateur harder to do contribute to it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
