[GitHub] [apisix] spacewander commented on pull request #4175: docs: fix broken links and ids in plugins
spacewander commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831870516 @iamayushdas @KishaniKandasamy Have you read my review? > Not all pages need a sidebar. They can go back from the browser. > And this problem should be fixed by the doc render framework itself. Adding unrelative doc to the sidebar to fix it is a hack. I won't want to review anymore if your guys keep ignoring my feedback. And such a change should not have such a title called 'docs: fix broken links and ids in plugins'! Please open another PR with **correct** name and **suitable** change! I am quite annoyed by you today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4175: docs: fix broken links and ids in plugins
spacewander commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831740037 @KishaniKandasamy 1. Don't change something that works well. 2. Before you submit a PR, please discuss it carefully and limit the scope. Most of your change in this PR is not relative to "broken links" or `ids`. Even without a quote, I think most people will think https://host.domain/auth/realms/foo/.well-known/uma2-configuration is just a "fake" example instead of a real link. Those links are **used as the example**. How many people in the real world have been misled by those links? What's the evidence? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4175: docs: fix broken links and ids in plugins
spacewander commented on pull request #4175: URL: https://github.com/apache/apisix/pull/4175#issuecomment-831628212 Would you put similar changes into one PR instead of submitting them one by one? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
