[GitHub] [apisix] spacewander commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
spacewander commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-996420133 The luarocks 2.x doesn't be broken because of the git URL. In fact, it doesn't handle the new rockspec format and the dependency management which have been reported by the user. It has been broken for a time. This PR just admitted it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
spacewander commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-996419334 No, as I mentioned in the commit message. The luarocks 2.x is actually broken. We just make sure people won't be trapped in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
spacewander commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-995572479 Luarocks automatically handles the URL conversion in this commit: https://github.com/luarocks/luarocks/commit/9ff512e35455939f02eaec2318e3acc77782fdeb, which is included in v3.8.0. So there is no need to handle this by ourselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org