[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-14 Thread GitBox


stu01509 commented on a change in pull request #3766:
URL: https://github.com/apache/apisix/pull/3766#discussion_r593988469



##
File path: Makefile
##
@@ -60,6 +60,7 @@ help: default
 ### deps: Installation dependencies
 .PHONY: deps
 deps: default
+luarocks install apisix --server https://luarocks.cn

Review comment:
   Hi @membphis 
   
   Ok, so what should I change? I am not familiar with `Makefile`
   cc @spacewander 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-14 Thread GitBox


stu01509 commented on a change in pull request #3766:
URL: https://github.com/apache/apisix/pull/3766#discussion_r593988469



##
File path: Makefile
##
@@ -60,6 +60,7 @@ help: default
 ### deps: Installation dependencies
 .PHONY: deps
 deps: default
+luarocks install apisix --server https://luarocks.cn

Review comment:
   Hi @membphis 
   
   Ok, so what should I change?
   
   cc @spacewander 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-14 Thread GitBox


stu01509 commented on a change in pull request #3766:
URL: https://github.com/apache/apisix/pull/3766#discussion_r593859879



##
File path: docs/en/latest/FAQ.md
##
@@ -71,6 +71,10 @@ There are two possibilities when encountering slow luarocks:
 For the first problem, you can use https_proxy or use the `--server` option to 
specify a luarocks server that you can access or access faster.
 Run the `luarocks config rocks_servers` command(this command is supported 
after luarocks 3.0) to see which server are available.
 
+```shell
+luarocks install apisix --server https://luarocks.cn

Review comment:
   Hi @spacewander 
   
   I update the `Makefile` and revert `FAQ.md` files.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-12 Thread GitBox


stu01509 commented on a change in pull request #3766:
URL: https://github.com/apache/apisix/pull/3766#discussion_r593188243



##
File path: docs/en/latest/FAQ.md
##
@@ -71,6 +71,10 @@ There are two possibilities when encountering slow luarocks:
 For the first problem, you can use https_proxy or use the `--server` option to 
specify a luarocks server that you can access or access faster.
 Run the `luarocks config rocks_servers` command(this command is supported 
after luarocks 3.0) to see which server are available.
 
+```shell
+luarocks install apisix --server https://luarocks.cn

Review comment:
   Hi @spacewander 
   
   Should I change to this?
   
   ```
   ### deps: Installation dependencies
   .PHONY: deps
   deps: default
   luarocks install apisix --server https://luarocks.cn
   ifeq ($(LUAROCKS_VER),luarocks 3.)
mkdir -p ~/.luarocks
   ifeq ($(shell whoami),root)
luarocks config variables.OPENSSL_LIBDIR $(addprefix $(OPENSSL_PREFIX), 
/lib)
luarocks config variables.OPENSSL_INCDIR $(addprefix $(OPENSSL_PREFIX), 
/include)
   else
luarocks config --local variables.OPENSSL_LIBDIR $(addprefix 
$(OPENSSL_PREFIX), /lib)
luarocks config --local variables.OPENSSL_INCDIR $(addprefix 
$(OPENSSL_PREFIX), /include)
   endif
luarocks install rockspec/apisix-master-0.rockspec --tree=deps 
--only-deps --local
   else
@echo "WARN: You're not using LuaRocks 3.x, please add the following 
items to your LuaRocks config file:"
@echo "variables = {"
@echo "OPENSSL_LIBDIR=$(addprefix $(OPENSSL_PREFIX), /lib)"
@echo "OPENSSL_INCDIR=$(addprefix $(OPENSSL_PREFIX), /include)"
@echo "}"
luarocks install rockspec/apisix-master-0.rockspec --tree=deps 
--only-deps --local
   endif
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-11 Thread GitBox


stu01509 commented on a change in pull request #3766:
URL: https://github.com/apache/apisix/pull/3766#discussion_r592246505



##
File path: docs/en/latest/FAQ.md
##
@@ -71,6 +71,10 @@ There are two possibilities when encountering slow luarocks:
 For the first problem, you can use https_proxy or use the `--server` option to 
specify a luarocks server that you can access or access faster.
 Run the `luarocks config rocks_servers` command(this command is supported 
after luarocks 3.0) to see which server are available.
 
+```shell
+luarocks install apisix --server https://luarocks.cn

Review comment:
   Hi @spacewander 
   
   Yeah, Please give me some time to understand





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org