[GitHub] [apisix] tokers commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
tokers commented on a change in pull request #5839:
URL: https://github.com/apache/apisix/pull/5839#discussion_r772031363
##
File path: apisix/plugins/google-cloud-logging.lua
##
@@ -61,13 +61,13 @@ local schema = {
type = "string",
default = "https://logging.googleapis.com/v2/entries:write;
},
-ssl_verify = {
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
tokers commented on a change in pull request #5839:
URL: https://github.com/apache/apisix/pull/5839#discussion_r771898379
##
File path: apisix/plugins/google-cloud-logging.lua
##
@@ -61,13 +61,13 @@ local schema = {
type = "string",
default = "https://logging.googleapis.com/v2/entries:write;
},
-ssl_verify = {
Review comment:
I don't know whether this plugin is used by someone, if we just remove
this setting, it's bad for these users. Or we can just reserve and deprecate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
