[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-27 Thread GitBox


tokers commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-717211974


   I am still debugging this problem, it's seems the `plugin_metadata` cannot 
be fetched in the test case 10 (plugin-metadata.t)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-22 Thread GitBox


tokers commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-714461021


   @membphis I'm stucking in this weird CI failed problem, it may cost me some 
time to solve this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-21 Thread GitBox


tokers commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-714178118


   @membphis Fixed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-19 Thread GitBox


tokers commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-712541082


   > CI failed, please take a look at the output: 
https://github.com/apache/apisix/pull/2395/checks?check_run_id=1272985327#step:9:43
   
   @membphis Fixed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-19 Thread GitBox


tokers commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-712537171


   @membphis I'm investigating this failure, it's a bit weird



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-12 Thread GitBox


tokers commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-707083816


   > many thx @tokers for your nice job. that is a big change, need time to 
read it first.
   > 
   > please wait for more time.
   
   OK, great care must be taken for these big changes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-12 Thread GitBox


tokers commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-706958472


   Temporarily modify the branch from `master` to `improve/cmd_refactoring` 
file to pass the CI. Should be reset after merging.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-12 Thread GitBox


tokers commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-706958566


   @membphis 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org