[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide

2021-12-13 Thread GitBox 


tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r768263246



##
File path: docs/en/latest/how-to-build.md
##
@@ -21,36 +21,37 @@ title: How to build Apache APISIX
 #
 -->
 
-## Step 1: Install dependencies
-
-The Apache APISIX runtime environment requires dependencies on NGINX and etcd.
-
-Before installing Apache APISIX, please install dependencies according to the 
operating system you are using. We provide the dependencies installation 
instructions for **CentOS7**, **Fedora 31 & 32**, **Ubuntu 16.04 & 18.04**, 
**Debian 9 & 10**, and **MacOS**, please refer to [Install 
Dependencies](install-dependencies.md) for more details.
-
-## Step 2: Install Apache APISIX
+## Step 1: Install Apache APISIX
 
 You can install Apache APISIX via RPM Repository, RPM package, Docker, Helm 
Chart, and source release package. Please choose one from the following options.

Review comment:
   hi @zaunist , RPM Repository and RPM package are same meanings.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide

2021-12-13 Thread GitBox 


tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r768255563



##
File path: docs/en/latest/how-to-build.md
##
@@ -66,34 +67,50 @@ Please refer to: [Installing Apache APISIX with Helm 
Chart](https://github.com/a
 1. Create a directory named `apisix-2.11.0`.
 
   ```shell
-  mkdir apisix-2.11.0
+  $ APISIX_VERSION='2.11.0'
+  $ mkdir apisix-${APISIX_VERSION}
   ```
 
 2. Download Apache APISIX Release source package.
 
   ```shell
-  wget https://downloads.apache.org/apisix/2.11.0/apache-apisix-2.11.0-src.tgz
+  $ wget 
https://downloads.apache.org/apisix/2.11.0/apache-apisix-${APISIX_VERSION}-src.tgz
   ```
 
   You can also download the Apache APISIX Release source package from the 
Apache APISIX website. The [Apache APISIX Official Website - Download 
Page](https://apisix.apache.org/downloads/) also provides source packages for 
Apache APISIX, APISIX Dashboard and APISIX Ingress Controller.
 
 3. Unzip the Apache APISIX Release source package.
 
   ```shell
-  tar zxvf apache-apisix-2.11.0-src.tgz -C apisix-2.11.0
+  $ tar zxvf apache-apisix-2.11.0-src.tgz -C apisix-2.11.0

Review comment:
   done

##
File path: docs/en/latest/how-to-build.md
##
@@ -66,34 +67,50 @@ Please refer to: [Installing Apache APISIX with Helm 
Chart](https://github.com/a
 1. Create a directory named `apisix-2.11.0`.
 
   ```shell
-  mkdir apisix-2.11.0
+  $ APISIX_VERSION='2.11.0'
+  $ mkdir apisix-${APISIX_VERSION}
   ```
 
 2. Download Apache APISIX Release source package.
 
   ```shell
-  wget https://downloads.apache.org/apisix/2.11.0/apache-apisix-2.11.0-src.tgz
+  $ wget 
https://downloads.apache.org/apisix/2.11.0/apache-apisix-${APISIX_VERSION}-src.tgz

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide

2021-12-13 Thread GitBox 


tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r768255311



##
File path: docs/en/latest/how-to-build.md
##
@@ -66,34 +67,50 @@ Please refer to: [Installing Apache APISIX with Helm 
Chart](https://github.com/a
 1. Create a directory named `apisix-2.11.0`.
 
   ```shell
-  mkdir apisix-2.11.0
+  $ APISIX_VERSION='2.11.0'
+  $ mkdir apisix-${APISIX_VERSION}
   ```
 
 2. Download Apache APISIX Release source package.
 
   ```shell
-  wget https://downloads.apache.org/apisix/2.11.0/apache-apisix-2.11.0-src.tgz
+  $ wget 
https://downloads.apache.org/apisix/2.11.0/apache-apisix-${APISIX_VERSION}-src.tgz
   ```
 
   You can also download the Apache APISIX Release source package from the 
Apache APISIX website. The [Apache APISIX Official Website - Download 
Page](https://apisix.apache.org/downloads/) also provides source packages for 
Apache APISIX, APISIX Dashboard and APISIX Ingress Controller.
 
 3. Unzip the Apache APISIX Release source package.
 
   ```shell
-  tar zxvf apache-apisix-2.11.0-src.tgz -C apisix-2.11.0
+  $ tar zxvf apache-apisix-2.11.0-src.tgz -C apisix-2.11.0
   ```
 
 4. Install the runtime dependent Lua libraries.
 
   ```shell
   # Switch to the apisix-2.11.0 directory
-  cd apisix-2.11.0
+  $ cd apisix-2.11.0
   # Create dependencies
-  make deps
+  $ make deps
   # Install apisix command
-  make install
+  $ make install
   ```
 
+## Step 2: Install ETCD
+
+This step is required if you have installed only Apache APISIX via RPM, Docker 
or source code but not ETCD.
+
+You can install ETCD via Docker or binary etc. The following command installs 
ETCD via binary.
+
+```shell
+$ ETCD_VERSION='3.4.13'

Review comment:
   I have tried, but now install-dependencies.sh is not support to only 
install etcd.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide

2021-12-13 Thread GitBox 


tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r767855573



##
File path: docs/en/latest/how-to-build.md
##
@@ -66,34 +67,49 @@ Please refer to: [Installing Apache APISIX with Helm 
Chart](https://github.com/a
 1. Create a directory named `apisix-2.11.0`.
 
   ```shell
-  mkdir apisix-2.11.0
+  $ mkdir apisix-2.11.0

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide

2021-12-12 Thread GitBox 


tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r767293181



##
File path: docs/zh/latest/how-to-build.md
##
@@ -21,36 +21,37 @@ title: 如何构建 Apache APISIX
 #
 -->
 
-## 步骤1：安装依赖
-
-Apache APISIX 的运行环境需要依赖 NGINX 和 etcd，所以在安装 Apache APISIX 
前，请根据您使用的操作系统安装对应的依赖。我们提供了 **CentOS7** 、**Fedora 31 & 32** 、**Ubuntu 16.04 & 
18.04** 、 **Debian 9 & 10** 和 **MacOS** 上的依赖安装操作步骤，详情请参考 
[安装依赖](install-dependencies.md)。
-
-通过 Docker 或 Helm Chart 安装 Apache APISIX 时，已经包含了所需的 NGINX 和 etcd，请参照各自对应的文档。
-
-## 步骤2：安装 Apache APISIX
+## 步骤1：安装 Apache APISIX
 
 你可以通过 RPM 仓库、RPM 包、Docker、Helm Chart、源码包等多种方式来安装 Apache APISIX。请在以下选项中选择其中一种执行。
 
 ### 通过 RPM 仓库安装（CentOS 7）
 
-这种安装方式适用于 CentOS 7 操作系统。Apache APISIX 已经支持适用于 CentOS 7 的 RPM 仓库。请运行以下命令安装 RPM 
仓库和 Apache APISIX。
+这种安装方式适用于 CentOS 7 操作系统。

Review comment:
   we currently only offer RPMs for Centos 7. In fact, AFAIK, Centos 7 is 
very common, Centos 6 and 8 are less common.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide

2021-12-07 Thread GitBox 


tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r764071076



##
File path: docs/zh/latest/how-to-build.md
##
@@ -94,6 +95,23 @@ sudo yum install -y 
https://repos.apiseven.com/packages/centos/apache-apisix-rep
   make install
   ```
 
+## 步骤2：安装 ETCD
+
+通过 RPM 或者 Docker 安装 Apache APISIX 时，需要执行此步骤。
+
+你可以通过 Docker 或者二进制等方式安装 ETCD。以下命令通过二进制方式安装 ETCD。
+
+```shell
+ETCD_VERSION='3.4.13'

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide

2021-12-07 Thread GitBox 


tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r764070892



##
File path: docs/en/latest/how-to-build.md
##
@@ -94,6 +95,23 @@ Please refer to: [Installing Apache APISIX with Helm 
Chart](https://github.com/a
   make install
   ```
 
+## Step 2: Install ETCD
+
+This step is required when installing Apache APISIX via RPM or Docker.

Review comment:
   I didn't find this document, I've changed the expression.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide

2021-12-07 Thread GitBox 


tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r764070493



##
File path: docs/en/latest/how-to-build.md
##
@@ -94,6 +95,23 @@ Please refer to: [Installing Apache APISIX with Helm 
Chart](https://github.com/a
   make install
   ```
 
+## Step 2: Install ETCD
+
+This step is required when installing Apache APISIX via RPM or Docker.
+
+You can install ETCD via Docker or binary etc. The following command installs 
ETCD via binary.
+
+```shell
+ETCD_VERSION='3.4.13'
+wget 
https://github.com/etcd-io/etcd/releases/download/v${ETCD_VERSION}/etcd-v${ETCD_VERSION}-linux-amd64.tar.gz
+tar -xvf etcd-v${ETCD_VERSION}-linux-amd64.tar.gz && \
+cd etcd-v${ETCD_VERSION}-linux-amd64 && \
+sudo cp -a etcd etcdctl /usr/bin/
+nohup etcd &
+```
+
+Note: When ETCD is started with the command `nohup etcd &`, the data in ETCD 
is not stored persistently. For more information on ETCD, please refer to the 
[ETCD documentation](https://etcd.io/docs/).

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org