[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate

2022-03-27 Thread GitBox


tzssangglass commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1080066439


   > This is not easy to combine these two plugins. But we can make a try.
   
   Maybe we can make file-logger support log file rotation (without modifying 
the log-rotate plugin, or extracting some common functions)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate

2022-03-26 Thread GitBox


tzssangglass commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079717169


   good idea,  we should make the file logger itself support log file 
rotation.. cc @spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate

2022-03-24 Thread GitBox


tzssangglass commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1077659748


   They are not really related, can you give more details?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org