[GitHub] [apisix] zhixiongdu027 commented on pull request #6663: feat: improve kubernetes discovery

2022-03-20 Thread GitBox 


zhixiongdu027 commented on pull request #6663:
URL: https://github.com/apache/apisix/pull/6663#issuecomment-1073407486


   
![image](https://user-images.githubusercontent.com/4032302/159195405-56f495ac-ebed-4bbf-884e-0d2351ec5c08.png)
   
   It looks like we just need to insert a line here?
   
   @spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] zhixiongdu027 commented on pull request #6663: feat: improve kubernetes discovery

2022-03-20 Thread GitBox 


zhixiongdu027 commented on pull request #6663:
URL: https://github.com/apache/apisix/pull/6663#issuecomment-1073202410


   @spacewander @tokers 
   TKS review, ALL comment issues have been taken care of. please help reviews


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] zhixiongdu027 commented on pull request #6663: feat: improve kubernetes discovery

2022-03-20 Thread GitBox 


zhixiongdu027 commented on pull request #6663:
URL: https://github.com/apache/apisix/pull/6663#issuecomment-1073200331


   @spacewander @tokers 
   Hi, all comment issues have been taken care of. please help review.
   Many TKS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org