Baoyuantop commented on code in PR #2647:
URL: https://github.com/apache/apisix-dashboard/pull/2647#discussion_r1001272492
##########
web/package.json:
##########
@@ -68,6 +68,8 @@
"classnames": "^2.2.6",
"dayjs": "1.8.28",
"dotenv": "^16.0.1",
+ "eslint-plugin-import": "^2.26.0",
+ "eslint-plugin-simple-import-sort": "^8.0.0",
Review Comment:
Are both of these required? I think `eslint-plugin-import` is enough
##########
web/.eslintrc.js:
##########
@@ -15,13 +15,38 @@
* limitations under the License.
*/
module.exports = {
- extends: [require.resolve('@umijs/fabric/dist/eslint')],
+ extends: [
+ require.resolve('@umijs/fabric/dist/eslint'),
+ 'plugin:import/errors',
+ 'plugin:import/warnings',
+ ],
+ plugins: ['simple-import-sort'],
globals: {
ANT_DESIGN_PRO_ONLY_DO_NOT_USE_IN_YOUR_PRODUCTION: true,
page: true,
REACT_APP_ENV: true,
},
rules: {
'@typescript-eslint/naming-convention': 'off',
+ 'import/no-unresolved': [2, { ignore: ['^@/', '^umi/', '^@@/'] }],
+ 'sort-imports': 'off',
+ 'import/order': 'off',
Review Comment:
Why turn it off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
