[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-03-14 Thread GitBox


LiteSun commented on issue #1512:
URL: 
https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-799045795


   > @LiteSun can we close this issue now?
   
   Sure.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-03-14 Thread GitBox


LiteSun commented on issue #1512:
URL: 
https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-799045638


   closed by #1540 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-03-01 Thread GitBox


LiteSun commented on issue #1512:
URL: 
https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-788522822


   > > > I am a little confused about how to use the plugin template. Do we 
need to bind the template to the target route manually? @LiteSun
   > > 
   > > 
   > > Yes, just like binding upstream in a route.
   > 
   > Got it, and does the plugin template can also be bind to service?
   
   Binding service depends on apisix, which does not currently support this 
feature



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-03-01 Thread GitBox


LiteSun commented on issue #1512:
URL: 
https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-788493242


   > I am a little confused about how to use the plugin template. Do we need to 
bind the template to the target route manually? @LiteSun
   
   Yes, just like binding upstream in a route.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-02-28 Thread GitBox


LiteSun commented on issue #1512:
URL: 
https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-787597383


   Apisix has submitted pr to complete this requirement: 
https://github.com/apache/apisix/pull/3703
   
   The front-end page was changed as follows to complete the requirement.
   1. new label search on the plugin template list page, similar to the route 
list label search.
   
![image](https://user-images.githubusercontent.com/31329157/109445467-9e938980-7a7a-11eb-990e-0714889e4297.png)
   
   2. add label field in the basic information configuration. similar to the 
creation of the route when the configuration label.
   
![image](https://user-images.githubusercontent.com/31329157/109445629-f7632200-7a7a-11eb-814a-0f37d5ce91a9.png)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-02-28 Thread GitBox


LiteSun commented on issue #1512:
URL: 
https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-787567786


   > > will pugin support `tag`?
   > 
   > > In this way, the management and grouping of plug-ins can be completed, 
which is more flexible
   > 
   > 
   > 
   > Good catch!  
   > 
   > Does apisix plugin config support tag? Need @spacewander  to confirm, if 
apisix supports it, I will update the tag to the solution. 
   
   Ping @spacewander 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-02-25 Thread GitBox


LiteSun commented on issue #1512:
URL: 
https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785719936


   Let me do more research on how to prevent the page from crashing if a field 
is missing



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-02-24 Thread GitBox


LiteSun commented on issue #1512:
URL: 
https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785677739


   > will pugin support `tag`?
   > In this way, the management and grouping of plug-ins can be completed, 
which is more flexible
   
   Good catch!  
   Does apisix plugin config support tag? Need @spacewander  to confirm, if 
apisix supports it, I will update the tag to the solution. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org