[GitHub] [apisix-dashboard] batman-ezio edited a comment on pull request #1558: feat:Support duplicate one existing Route
batman-ezio edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-801540082 CI is still not stable, I sync from master still fails This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio edited a comment on pull request #1558: feat:Support duplicate one existing Route
batman-ezio edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-800882327 @nic-chen This PR contains two things 1: duplicate a route 2: check duplicate name in create/update route api `#2` break many test case and take much time. how about I revert the code and just keep the `#1` codes here . I see you have a more effective PR to do the `#2` things here https://github.com/apache/apisix-dashboard/pull/1606/files and then we can move this PR forward This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio edited a comment on pull request #1558: feat:Support duplicate one existing Route
batman-ezio edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799015546 after rebase from latest master, the frontend test case is still failed. `should import route(s) from be test files` failed because click from multi routes. maybe import in foreach look needs to ensure the route is deleted. add async? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio edited a comment on pull request #1558: feat:Support duplicate one existing Route
batman-ezio edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-792660304 > @batman-ezio would you mind if we modify your code on your branch? no, please I found those test case in `ece/route_with_*` does not pass Name field in the body, so their route will create with a blank name and will failed for duplicate, can we add a logic in create/update API to set the name from url params if it does not exists in the request body? the frontend e2e test will be fixed after merge this PR https://github.com/apache/apisix-dashboard/pull/1559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio edited a comment on pull request #1558: feat:Support duplicate one existing Route
batman-ezio edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-792660304 > @batman-ezio would you mind if we modify your code on your branch? no, please I found those test case in `ece/route_with_*` does not pass Name field in the body, so their route will create with a blank name and will failed for duplicate, can we add a logic in create/update API to set the name from url params if it does not exists in the request body? the frontend e2e test will be fixed after merge this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio edited a comment on pull request #1558: feat:Support duplicate one existing Route
batman-ezio edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-792660304 > @batman-ezio would you mind if we modify your code on your branch? no, please I found those test case in `ece/route_with_*` does not pass Name field in the body, so their route will create with a blank name and will failed for duplicate, can we add a logic to create/update to set the name from url params if name is not in body or blank? the frontend e2e test will be fixed after merge this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
