[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1705: fix: detailed error for store init failure and deferred execution of closers

[GitBox]

bisakhmondal commented on a change in pull request #1705:
URL: https://github.com/apache/apisix-dashboard/pull/1705#discussion_r612927994



##
File path: api/cmd/managerapi.go
##
@@ -93,13 +102,16 @@ func NewManagerAPICommand() *cobra.Command {
return newMws
}
 
+   fmt.Printf("DEBUG-ETCDCONFIG: %+v\n\n", 
*conf.ETCDConfig)

Review comment:
   yes yes. Just 1 min.
   
![image](https://user-images.githubusercontent.com/41498427/114654459-d5aabb00-9d07-11eb-82f4-d5d64e28ea48.png)
   Actually, it was the root cause. The endpoint was different, haha.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1705: fix: detailed error for store init failure and deferred execution of closers

[GitBox]

bisakhmondal commented on a change in pull request #1705:
URL: https://github.com/apache/apisix-dashboard/pull/1705#discussion_r607521106



##
File path: api/test/shell/cli_test.sh
##
@@ -457,6 +457,23 @@ fi
 ./manager-api stop
 sleep 6
 
+# test manager-api output for bad data on etcd
+# make a dummy entry
+./etcd-v3.4.14-linux-amd64/etcdctl put /apisix/routes/unique1 "{\"id\":}"

Review comment:
   Still not working




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1705: fix: detailed error for store init failure and deferred execution of closers

[GitBox]

bisakhmondal commented on a change in pull request #1705:
URL: https://github.com/apache/apisix-dashboard/pull/1705#discussion_r606956010



##
File path: api/cmd/managerapi.go
##
@@ -99,7 +108,9 @@ func NewManagerAPICommand() *cobra.Command {
}
if err := store.InitStores(); err != nil {
log.Errorf("init stores fail: %w", err)
-   panic(err)
+   fmt.Printf("%s\n", err)

Review comment:
   Oops!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org