[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-15 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(bd9551b) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/40d1dabf4380ee0ff6c48d2eb3943e6d50daf05b?el=desc)
 (40d1dab) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#1538   +/-   ##
   ===
 Coverage   70.28%   70.28%   
   ===
 Files  46   46   
 Lines3019 3019   
   ===
 Hits 2122 2122   
 Misses652  652   
 Partials  245  245   
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `60.88% <ø> (+0.03%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `46.27% <ø> (-0.04%)` | :arrow_down: |
   | backend-unit-test | `51.50% <ø> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.34% <0.00%> (-0.61%)` | :arrow_down: |
   | 
[api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv)
 | `59.45% <0.00%> (+1.35%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[40d1dab...bd9551b](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-15 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(bd9551b) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/40d1dabf4380ee0ff6c48d2eb3943e6d50daf05b?el=desc)
 (40d1dab) will **decrease** coverage by `3.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1538  +/-   ##
   ==
   - Coverage   70.28%   66.31%   -3.98% 
   ==
 Files  46   46  
 Lines3019 3019  
   ==
   - Hits 2122 2002 -120 
   - Misses652  769 +117 
   - Partials  245  248   +3 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `46.27% <ø> (-0.04%)` | :arrow_down: |
   | backend-unit-test | `51.50% <ø> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `77.14% <0.00%> (-8.58%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (-3.64%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | ... and [2 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[40d1dab...bd9551b](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-15 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(bd9551b) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/40d1dabf4380ee0ff6c48d2eb3943e6d50daf05b?el=desc)
 (40d1dab) will **decrease** coverage by `18.78%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1538   +/-   ##
   ===
   - Coverage   70.28%   51.50%   -18.79% 
   ===
 Files  46   37-9 
 Lines3019 2555  -464 
   ===
   - Hits 2122 1316  -806 
   - Misses652 1058  +406 
   + Partials  245  181   -64 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.50% <ø> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=)
 | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [32 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[40d1dab...bd9551b](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-14 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(35f722e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc)
 (e22de29) will **decrease** coverage by `11.21%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1538   +/-   ##
   ===
   - Coverage   69.01%   57.80%   -11.22% 
   ===
 Files 132  132   
 Lines5374 5375+1 
 Branches  592  592   
   ===
   - Hits 3709 3107  -602 
   - Misses   1417 1983  +566 
   - Partials  248  285   +37 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test-ginkgo | `46.37% <ø> (+0.09%)` | :arrow_up: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `72.45% <100.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==)
 | `52.00% <100.00%> (+2.00%)` | :arrow_up: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `9.43% <0.00%> (-70.76%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv)
 | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `36.11% <0.00%> (-41.67%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `52.12% <0.00%> (-39.37%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `27.41% <0.00%> (-38.71%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `57.22% <0.00%> (-30.73%)` | :arrow_down: |
   | 
[api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=)
 | `48.95% <0.00%> (-29.29%)` | :arrow_down: |
   | ... and [15 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[e22de29...35f722e](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To 

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-14 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(35f722e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc)
 (e22de29) will **decrease** coverage by `11.28%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1538   +/-   ##
   ===
   - Coverage   69.01%   57.73%   -11.29% 
   ===
 Files 132  132   
 Lines5374 5375+1 
 Branches  592  592   
   ===
   - Hits 3709 3103  -606 
   - Misses   1417 1989  +572 
   - Partials  248  283   +35 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test-ginkgo | `46.24% <ø> (-0.04%)` | :arrow_down: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `72.45% <100.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==)
 | `52.00% <100.00%> (+2.00%)` | :arrow_up: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `9.43% <0.00%> (-70.76%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv)
 | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `36.11% <0.00%> (-41.67%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `52.12% <0.00%> (-39.37%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `27.41% <0.00%> (-38.71%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `56.02% <0.00%> (-31.93%)` | :arrow_down: |
   | 
[api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=)
 | `48.95% <0.00%> (-29.29%)` | :arrow_down: |
   | ... and [16 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[e22de29...35f722e](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To 

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-14 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(35f722e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc)
 (e22de29) will **increase** coverage by `3.43%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1538  +/-   ##
   ==
   + Coverage   69.01%   72.45%   +3.43% 
   ==
 Files 132   86  -46 
 Lines5374 2356-3018 
 Branches  592  592  
   ==
   - Hits 3709 1707-2002 
   + Misses   1417  649 -768 
   + Partials  2480 -248 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `72.45% <100.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==)
 | `52.00% <100.00%> (+2.00%)` | :arrow_up: |
   | 
[api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=)
 | | |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | | |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | | |
   | 
[api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==)
 | | |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | | |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | | |
   | 
[api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==)
 | | |
   | 
[api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=)
 | | |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | | |
   | ... and [37 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[e22de29...35f722e](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-10 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-10 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(81d7bb4) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/6dce9e09640b1c81f14dbb88e5f6f8c43371af31?el=desc)
 (6dce9e0) will **decrease** coverage by `19.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1538   +/-   ##
   ===
   - Coverage   70.82%   51.50%   -19.33% 
   ===
 Files 135   37   -98 
 Lines5485 2555 -2930 
 Branches  5830  -583 
   ===
   - Hits 3885 1316 -2569 
   + Misses   1352 1058  -294 
   + Partials  248  181   -67 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.50% <ø> (-0.18%)` | :arrow_down: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=)
 | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [118 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[6dce9e0...81d7bb4](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this 

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-10 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(45e8b49) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/6dce9e09640b1c81f14dbb88e5f6f8c43371af31?el=desc)
 (6dce9e0) will **decrease** coverage by `11.96%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1538   +/-   ##
   ===
   - Coverage   70.82%   58.86%   -11.97% 
   ===
 Files 135   46   -89 
 Lines5485 3019 -2466 
 Branches  5830  -583 
   ===
   - Hits 3885 1777 -2108 
   + Misses   1352  938  -414 
   - Partials  248  304   +56 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `58.86% <ø> (+3.29%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `42.39% <ø> (+2.60%)` | :arrow_up: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==)
 | `15.15% <0.00%> (-72.73%)` | :arrow_down: |
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `57.44% <0.00%> (-34.05%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `41.66% <0.00%> (-30.56%)` | :arrow_down: |
   | 
[api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==)
 | `39.26% <0.00%> (-29.97%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `60.24% <0.00%> (-26.51%)` | :arrow_down: |
   | 
[api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=)
 | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
   | 
[...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv)
 | `56.38% <0.00%> (-21.28%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
   | ... and [106 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[6dce9e0...45e8b49](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To 

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-10 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(45e8b49) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/6dce9e09640b1c81f14dbb88e5f6f8c43371af31?el=desc)
 (6dce9e0) will **decrease** coverage by `28.43%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1538   +/-   ##
   ===
   - Coverage   70.82%   42.39%   -28.44% 
   ===
 Files 135   46   -89 
 Lines5485 3019 -2466 
 Branches  5830  -583 
   ===
   - Hits 3885 1280 -2605 
   - Misses   1352 1469  +117 
   - Partials  248  270   +22 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `42.39% <ø> (+2.60%)` | :arrow_up: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==)
 | `15.15% <0.00%> (-72.73%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `9.43% <0.00%> (-72.65%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv)
 | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `27.41% <0.00%> (-56.46%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=)
 | `33.47% <0.00%> (-44.77%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `30.55% <0.00%> (-41.67%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `52.12% <0.00%> (-39.37%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | ... and [108 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[6dce9e0...45e8b49](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git 

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix Incomplete i18n coverage

2021-03-01 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(3e3d53f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/e51323fccf8b7bf5490f3e59319bb1c10ea03c5f?el=desc)
 (e51323f) will **decrease** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1538  +/-   ##
   ==
   - Coverage   68.61%   68.57%   -0.05% 
   ==
 Files  48   48  
 Lines3056 3055   -1 
   ==
   - Hits 2097 2095   -2 
   - Misses718  720   +2 
   + Partials  241  240   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv)
 | `54.05% <0.00%> (-5.41%)` | :arrow_down: |
   | 
[api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==)
 | `68.20% <0.00%> (-0.68%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `64.91% <0.00%> (ø)` | |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.95% <0.00%> (+1.20%)` | :arrow_up: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `47.27% <0.00%> (+1.81%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[e51323f...3e3d53f](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix Incomplete i18n coverage

2021-03-01 Thread GitBox


codecov-io edited a comment on pull request #1538:
URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) 
Report
   > Merging 
[#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) 
(3e3d53f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/e51323fccf8b7bf5490f3e59319bb1c10ea03c5f?el=desc)
 (e51323f) will **decrease** coverage by `6.29%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1538  +/-   ##
   ==
   - Coverage   68.61%   62.32%   -6.30% 
   ==
 Files  48   48  
 Lines3056 3055   -1 
   ==
   - Hits 2097 1904 -193 
   - Misses718  901 +183 
   - Partials  241  250   +9 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
   | 
[api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=)
 | `30.00% <0.00%> (-20.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `54.08% <0.00%> (-16.33%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
   | 
[api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=)
 | `71.12% <0.00%> (-7.12%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `62.56% <0.00%> (-6.71%)` | :arrow_down: |
   | ... and [7 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer).
 Last update 
[e51323f...3e3d53f](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org