[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631

[GitBox]

iamayushdas commented on pull request #1666:
URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-807860167


   > 
![image](https://user-images.githubusercontent.com/2106987/112455118-61c66400-8d94-11eb-806f-f4d71f4246dc.png)
   > 
   > How about here?
   
   #1671 @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631

[GitBox]

iamayushdas commented on pull request #1666:
URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806526078


   > 
![image](https://user-images.githubusercontent.com/2106987/112455118-61c66400-8d94-11eb-806f-f4d71f4246dc.png)
   > 
   > 
   > 
   > How about here?
   
   Yes sure will put that there☺️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631

[GitBox]

iamayushdas commented on pull request #1666:
URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806480385


   > Hi, @iamayushdas I think the headings should be left-justified.
   > 
![image](https://user-images.githubusercontent.com/72343596/112428672-7e53a380-8d76-11eb-9128-ca8e1bdeac9d.png)
   
   can you suggest me the exact fix in changes required?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631

[GitBox]

iamayushdas commented on pull request #1666:
URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806344710


   @juzhiyuan @LiteSun @bzp2010 @guoqqqi please review this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631

[GitBox]

iamayushdas commented on pull request #1666:
URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806022032


   
![image](https://user-images.githubusercontent.com/40708551/112356809-f2e5fe00-8cf4-11eb-9a6d-184aa67a38d7.png)
   
   Is this an issue from my side or something else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631

[GitBox]

iamayushdas commented on pull request #1666:
URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806003102


   @juzhiyuan @liuxiran @nic-chen @imjoey 
   Please review this PR #1666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org