[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-810747300 @liuxiran have a view to this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809525124 @juzhiyuan have a check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809505279 Okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809031431 @juzhiyuan should i change the path name of edit to configure for all or not, i guess that would be good. What say? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 > > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. > > Then I found a small problem when editing the page, the title should be `Edit **`, but now when editing it is `Create **`. > > ![image](https://user-images.githubusercontent.com/72343596/112758986-a0be1900-9023-11eb-9eab-eb48694f65e7.png) > > Thank you. > > Okay let me look into this @juzhiyuan after looking into the fix raised by @guoqqqi this, i got to know many of the routings was wrongly done like "Service and upstream". parameters were not set correctly. so should i fix this in the same PR or should i raise an issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808919338 > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. > > Then I found a small problem when editing the page, the title should be `Edit **`, but now when editing it is `Create **`. > > ![image](https://user-images.githubusercontent.com/72343596/112758986-a0be1900-9023-11eb-9eab-eb48694f65e7.png) > > Thank you. > > Okay let me look into this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808878108 @juzhiyuan @guoqqqi @LiteSun @gxthrj have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org