[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r594070690 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: ok, cc @LiteSun to take a look., I remember he had faced this case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r594028620 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: fail on windows, right? does this work on Linux? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593920864 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: Maybe a FAQ or some tips would be better? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593920843 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: `cross-env` is used in Windows IMO 🤔 we can't set it here directly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
