[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1633: feat: add the service page upstream select option

2021-04-26 Thread GitBox 


juzhiyuan commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r619649516



##
File path: web/src/pages/Upstream/locales/en-US.ts
##
@@ -17,6 +17,9 @@
 export default {
   'page.upstream.step.select.upstream': 'Select Upstream',
   'page.upstream.step.select.upstream.select.option': 'Custom',
+  'page.upstream.step.select.upstream.select.none': 'None',
+  'page.upstream.form.item-label.node.domain.or.ip': 'Node List',
+  'page.upstream.step.backend.server.domain.or.ip': 'Backend Server Domain/IP',

Review comment:
   ```suggestion
 'page.upstream.step.backend.server.domain.or.ip': 'Backend Server Host/IP',
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1633: feat: add the service page upstream select option

2021-04-24 Thread GitBox 


juzhiyuan commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r619649516



##
File path: web/src/pages/Upstream/locales/en-US.ts
##
@@ -17,6 +17,9 @@
 export default {
   'page.upstream.step.select.upstream': 'Select Upstream',
   'page.upstream.step.select.upstream.select.option': 'Custom',
+  'page.upstream.step.select.upstream.select.none': 'None',
+  'page.upstream.form.item-label.node.domain.or.ip': 'Node List',
+  'page.upstream.step.backend.server.domain.or.ip': 'Backend Server Domain/IP',

Review comment:
   ```suggestion
 'page.upstream.step.backend.server.domain.or.ip': 'Backend Server Host/IP',
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1633: feat: add the service page upstream select option

2021-04-13 Thread GitBox 


juzhiyuan commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r612868817



##
File path: web/src/components/Upstream/components/UpstreamSelector.tsx
##
@@ -61,6 +60,9 @@ const Component: React.FC = ({ shouldUpdate, onChange, 
list = [], disable
 {item.name}
   
 ))}
+{

Review comment:
   oh yes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1633: feat: add the service page upstream select option

2021-04-13 Thread GitBox 


juzhiyuan commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r612361952



##
File path: web/src/components/Upstream/components/UpstreamSelector.tsx
##
@@ -61,6 +60,9 @@ const Component: React.FC = ({ shouldUpdate, onChange, 
list = [], disable
 {item.name}
   
 ))}
+{

Review comment:
   Hi, please add i18n here :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1633: feat: add the service page upstream select option

2021-03-25 Thread GitBox 


juzhiyuan commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r601966905



##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -661,15 +661,14 @@ const UpstreamForm: React.FC = forwardRef(
 item?.children.toLowerCase().includes(input.toLowerCase())
   }
 >
-  {Boolean(!required) && None}
+  {Boolean(!required) && {

Review comment:
   ```suggestion
 {Boolean(!required) && {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1633: feat: add the service page upstream select option

2021-03-23 Thread GitBox 


juzhiyuan commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r599495506



##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -667,6 +667,9 @@ const UpstreamForm: React.FC = forwardRef(
   name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.option' }),
   id: '',
 },
+{

Review comment:
   aha! Good catch!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org