[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
liuxiran commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-825008616 Then how about leave enough space for users, that is to say, we just keep the current behavior, when users have scenarios that create an upstream with no nodes(even if we have not encountered now), they can do this through dashboard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
liuxiran commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823786050 @juzhiyuan @nic-chen keep the current behavior is also reasonable for me If there is no objection, we will close the issue cc @ericsyh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
liuxiran commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823120920 Hi @ericsyh thanks for your report. Acctually from the funcitonal point of view, the empty node list is a feature, see: `The nodes can be empty, which means it is a placeholder and will be filled later. Clients use such an upstream will get 502 response.` (come from https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#upstream) But from the UE point of view, an upstream can not be used with the empty node list, so keep at least one node in the node list is better. How about add this restriction to the dashboard? Let's wait for others option @juzhiyuan @LiteSun @nic-chen @imjoey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
