[GitHub] [apisix-dashboard] nic-chen commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo

2021-11-08 Thread GitBox 


nic-chen commented on pull request #1583:
URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-962920013


   @bisakhmondal 
   
   Could you continue to complete this PR when you have time?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo

2021-03-15 Thread GitBox 


nic-chen commented on pull request #1583:
URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-799930168


   @bisakhmondal  
   Thanks.
   You could deal with other issues first. 
   I will try to fix it when I get time.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo

2021-03-14 Thread GitBox 


nic-chen commented on pull request #1583:
URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-799033939


   > Thank you @membphis :)
   > 
   > It seems few recently added tests are failing. I am going to push the 
changes really soon after rechecking the code.
   > 
   > Btw, I have a small query. Here I have used 
[`gomega`](https://onsi.github.io/gomega/) with ginkgo as a matcher library (as 
they are widely used as a combo for being more bdd style), will that be okay, 
or I should stick with the assert package that is currently being used?
   
   
   I know this lib, but I don't know its details very well. 
   Could you share us the benefits of using this lib? @bisakhmondal 
   Thanks.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org