[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823750638 @tokers @starsz please have a look again when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823118510 > > how about ./manager-api start and ./manager-api stop, > > when run ./manager-api start and the service is not installed, install it ? > > Okay then, I will take care of checking and installing(if required) for `./manager-api start`. > And yes, actual commands instead of flags would look nice, thanks for that. Regarding the commands I think, we could provide install, remove and status too. > > * ./manager-api start > * ./manager-api stop > * ./manager-api status (option to check service status from the binary itself without depending on os specific service manager) > * ./manager-api remove (would be helpful deleting service test file without manually navigating to the filesystem) > * ./manager-api install (reinstalling the service, if the binary location needs to be changed in future, service must be reinstalled. Also in newer releases if we introduce extra flags, that should be passed as arguments for ExecStart of the service unit file i.e. need reinstallation) > > what do you think :) LGTM. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-82225 > > don't see the update? @bisakhmondal > > Updated :) Fully tested on Linux (ubuntu 20.04). I don't have macOS or windows. Please let me know if it is working or not when you have some time. >  > > cc @nic-chen, @membphis, @tokers, @starsz how about `./manager-api start` and `./manager-api stop`, when run `./manager-api start` and the service is not installed, install it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822149835 don't see the update? @bisakhmondal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-81909 hi, @bisakhmondal I think you could start a discussion on the mailing list: d...@apisix.apache.org, including which lib should be used and what our service name should be called, `apisix-dashboard` or `manager-api` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-809821928 > > @bisakhmondal > > > I think we could use a library to automate, instead of writing a configuration for each platform. What do you think? > > > > Totally agree with you :+1: . A few days back I found https://github.com/kardianos/service. It seems it's gonna serve our purpose (I haven't tested it though). What do you think? looks good. you could find some more libs and compare them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-808845673 @bisakhmondal I think we could use a library to automate, instead of writing a configuration for each platform. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-808089921
> Backend CLI Test is failing for changing
> `log.Infof("The Manager API server receive %s and start shutting down",
sig.String())`
> to
> `log.Infof("The Manager API server receives %s and starts acting up",
sig.String())`
> hehe :)
hi
Can it be solved by modifying the test's assertion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
