[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-841800524 > @nic-chen Something just come up into my mind. Let me know what you think about it. hi, @bisakhmondal , LGTM. But I think it’s better to put it in the `[WorkDir](https://github.com/apache/apisix-dashboard/blob/master/api/cmd/managerapi.go#L91)`, not in a temporary directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-841800524 > @nic-chen Something just come up into my mind. Let me know what you think about it. hi, @bisakhmondal , LGTM. But I think it’s better to put it in the `[WorkDir](https://github.com/apache/apisix-dashboard/blob/master/api/cmd/managerapi.go#L91)`, not in a temporary directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-840993732 > Hi guys, > regarding embedding the static lua codes into the binary, > > this is the method that handles the conversion of lua code, but I am not getting how this is done!! > https://github.com/apache/apisix-dashboard/blob/a59e8eff7ecdf38c197b4678c34d2fd15f364f72/api/internal/handler/route/route.go#L271-L306 > > The documentation in `gopher-lua` is not that good. > Could anyone give me some details? > > It seems pointing to the directory is enough, but after the embedding, it's going to be an **in-memory filesystem**. > I haven't found such apis in gopher-lua, could you please guide me? > Thanks. Are there any related error logs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-829845799 hi @bisakhmondal please sync code form branch master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-828062678 > Hii, what about `conf.yaml`, do we also have to embed this? should not embed it. people need to change configuration in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-823769178 hi @bisakhmondal I think we should also embed `dag-to-lua`, see: https://github.com/apache/apisix-dashboard/blob/master/api/build.sh#L38-L42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
