[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-22 Thread GitBox 


stu01509 commented on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803913240


   Update the commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-21 Thread GitBox 


stu01509 commented on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803746153


   Hello @nic-chen 
   
   Update the commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-21 Thread GitBox 


stu01509 commented on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803691495


   Hi @guoqqqi 
   
   Update the commit, please review it again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-21 Thread GitBox 


stu01509 commented on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803591182


   I updated the commit, but it seems like occurred the error in another test 
case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox 


stu01509 commented on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803252310


   Hi @guoqqqi and @juzhiyuan 
   
   Update the commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer

2021-03-19 Thread GitBox 


stu01509 commented on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802847983


   > Hi, We need to test the functionality not only on the plug-in page but 
also on the route page and the service page to make sure it works.
   
   Hi 
   
   Actually, I only found it the plugin page, where could I find in the route 
page and services page?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org