[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox


zaunist commented on pull request #2251:
URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996489601


   /LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox


zaunist commented on pull request #2251:
URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996428789


   If we delete the push step, the deploy-with-docker.yaml maybe delete 
together. Otherwise it doesn't make sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox


zaunist commented on pull request #2251:
URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996415535


   If we delete the push step, the deploy-with-docker.yaml maybe delete 
together. Otherwise it doesn't make sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org