[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582560334 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +branches: + - master + pull_request: +branches: + - master + +jobs: + build: +runs-on: ubuntu-latest +steps: + - uses: actions/checkout@v2 + - name: Build and run +run: | + git clone http://github.com/apache/apisix Review comment: > We need to specify APISIX_VERSION when git clone. Using master branch is enough, it's just for test. > Doesn't the APISIX repository exist in the CI action env? No in this repo, we only have apisix-docker in CI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582560334 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +branches: + - master + pull_request: +branches: + - master + +jobs: + build: +runs-on: ubuntu-latest +steps: + - uses: actions/checkout@v2 + - name: Build and run +run: | + git clone http://github.com/apache/apisix Review comment: > We need to specify APISIX_VERSION when git clone. Using master branch is enough, it's just for test. > Doesn't the APISIX repository exist in the CI action env? ~No in this repo, we only have apisix-docker in CI~ Got it, removed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582560334 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +branches: + - master + pull_request: +branches: + - master + +jobs: + build: +runs-on: ubuntu-latest +steps: + - uses: actions/checkout@v2 + - name: Build and run +run: | + git clone http://github.com/apache/apisix Review comment: > We need to specify APISIX_VERSION when git clone. Using master branch is enough, it's just for test. > Doesn't the APISIX repository exist in the CI action env? No in this repo, we only have apisix-docker in CI ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +branches: + - master + pull_request: +branches: + - master + +jobs: + build: +runs-on: ubuntu-latest +steps: + - uses: actions/checkout@v2 + - name: Build and run +run: | + git clone http://github.com/apache/apisix + export APISIX_PATH="./apisix" Review comment: Changed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code
Yiyiyimu commented on a change in pull request #137:
URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582559814
##
File path: Makefile
##
@@ -28,6 +28,10 @@ build-on-centos:
build-on-alpine:
docker build -t $(IMAGE_NAME):$(APISIX_VERSION)-alpine -f
./alpine/Dockerfile .
+### build-on-alpine: Build apaceh/apisix:xx-alpine image
+build-on-alpine-local:
+ docker build -t $(IMAGE_NAME):alpine-local --build-arg
APISIX_VERSION=${APISIX_PATH} -f ./alpine-local/Dockerfile .
Review comment:
It's actually a typo 🤣 The arg name should be `APISIX_PATH`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code
Yiyiyimu commented on a change in pull request #137:
URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582559814
##
File path: Makefile
##
@@ -28,6 +28,10 @@ build-on-centos:
build-on-alpine:
docker build -t $(IMAGE_NAME):$(APISIX_VERSION)-alpine -f
./alpine/Dockerfile .
+### build-on-alpine: Build apaceh/apisix:xx-alpine image
+build-on-alpine-local:
+ docker build -t $(IMAGE_NAME):alpine-local --build-arg
APISIX_VERSION=${APISIX_PATH} -f ./alpine-local/Dockerfile .
Review comment:
It's actually a typo... The arg name should be `APISIX_PATH`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582440504 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +branches: + - master + pull_request: +branches: + - master + +jobs: + build: +runs-on: ubuntu-latest +steps: + - uses: actions/checkout@v2 + - name: Build and run +run: | + git clone http://github.com/apache/apisix Review comment: To mock building from local This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code
Yiyiyimu commented on a change in pull request #137:
URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582440327
##
File path: Makefile
##
@@ -28,6 +28,10 @@ build-on-centos:
build-on-alpine:
docker build -t $(IMAGE_NAME):$(APISIX_VERSION)-alpine -f
./alpine/Dockerfile .
+### build-on-alpine: Build apaceh/apisix:xx-alpine image
+build-on-alpine-local:
+ docker build -t $(IMAGE_NAME):alpine-local --build-arg
APISIX_VERSION=${APISIX_PATH} -f ./alpine-local/Dockerfile .
Review comment:
My bad.. Forget to rename it to `APISIX_VERSION`.
Here I try to build from local code, but not certain commit from origin. So
I think we still need the path
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
