[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder

2021-03-26 Thread GitBox


juzhiyuan commented on a change in pull request #153:
URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602176412



##
File path: docs/en/latest/manual.md
##
@@ -1,3 +1,27 @@
+---
+title: Manual deploy apisix via docker

Review comment:
   ```suggestion
   title: Deploy Apache APISIX with Docker
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder

2021-03-26 Thread GitBox


juzhiyuan commented on a change in pull request #153:
URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602176552



##
File path: docs/en/latest/build.md
##
@@ -1,3 +1,26 @@
+---
+title: Build an image from source

Review comment:
   ```suggestion
   title: Build an image from the source codes
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder

2021-03-26 Thread GitBox


juzhiyuan commented on a change in pull request #153:
URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602176033



##
File path: docs/en/latest/config.json
##
@@ -1,10 +1,10 @@
 {
-"version": 1.0,
-"sidebar": [
-  {
-"type": "category",
-"label": "Installation",
-"items": ["build", "manual", "example"]
-  }
-]
-  }
\ No newline at end of file
+  "version": 1.0,
+  "sidebar": [
+{
+  "type": "category",
+  "label": "Installation",
+  "items": [ "build", "manual", "example"]
+}
+  ]
+}

Review comment:
   new line




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder

2021-03-25 Thread GitBox


juzhiyuan commented on a change in pull request #153:
URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602018586



##
File path: docs/en/latest/config.json
##
@@ -0,0 +1,10 @@
+{
+"version": 1.0,
+"sidebar": [
+  {
+"type": "category",
+"label": "Installation",
+"items": ["build", "manual", "example"]
+  }
+]
+  }

Review comment:
   new line, please

##
File path: docs/en/latest/config.json
##
@@ -0,0 +1,10 @@
+{
+"version": 1.0,
+"sidebar": [
+  {
+"type": "category",
+"label": "Installation",
+"items": ["build", "manual", "example"]

Review comment:
   Hi, those items should contain necessary meta information, please refer 
to `apisix`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org