[GitHub] [apisix-docker] tokers commented on a change in pull request #152: feat: add apisix-dashboard dockerfile & CI

[GitBox]

tokers commented on a change in pull request #152:
URL: https://github.com/apache/apisix-docker/pull/152#discussion_r598065541



##
File path: compose/dashboard-compose.yaml
##
@@ -0,0 +1,35 @@
+version: "3"

Review comment:
   Got it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] tokers commented on a change in pull request #152: feat: add apisix-dashboard dockerfile & CI

[GitBox]

tokers commented on a change in pull request #152:
URL: https://github.com/apache/apisix-docker/pull/152#discussion_r597346508



##
File path: Makefile
##
@@ -20,6 +20,10 @@ APISIX_VERSION ?= 2.4
 IMAGE_NAME = apache/apisix
 IMAGE_TAR_NAME = apache_apisix
 
+APISIX_DASHBOARD_VERSION ?= 2.4
+DASHBOARD_IMAGE_NAME = apache/apisix-dashboard

Review comment:
   Would be better to always add the `APISIX` prefix.

##
File path: compose/dashboard-compose.yaml
##
@@ -0,0 +1,35 @@
+version: "3"

Review comment:
   It would be great to add the dashboard to the 
`compose/docker-compose.yaml`, let people can run APISIX, Dashboard, and ETCD 
together.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org