[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname

[GitBox]

PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r831785797



##
File path: charts/apisix-dashboard/values.yaml
##
@@ -86,9 +86,17 @@ service:
 
 ingress:
   enabled: false
+  # kubernetes ingress attribe ingressClassName,default to "apisix" 
+  # Kubernetes 1.18+ support ingressClassName attribe 
+  className: "apisix"

Review comment:
   ok, please reaudit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname

[GitBox]

PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r831746074



##
File path: charts/apisix-dashboard/values.yaml
##
@@ -86,9 +86,17 @@ service:
 
 ingress:
   enabled: false
+  # kubernetes ingress attribe ingressClassName,default to "apisix" 
+  # Kubernetes 1.18+ support ingressClassName attribe 
+  className: "apisix"

Review comment:
   why? is become kubernetes version not upgrade!?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname

[GitBox]

PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830716265



##
File path: charts/apisix-dashboard/templates/ingress.yaml
##
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
 {{- end }}
 kind: Ingress
 metadata:
+  {{- if .Values.ingress.classNmae }}
+  ingressClassName: {{- .Values.ingress.classNmae -}}

Review comment:
   hi,readme.md already update;




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname

[GitBox]

PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830606759



##
File path: charts/apisix-dashboard/templates/ingress.yaml
##
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
 {{- end }}
 kind: Ingress
 metadata:
+  {{- if .Values.ingress.classNmae }}
+  ingressClassName: {{- .Values.ingress.classNmae -}}

Review comment:
   thx, already edited; 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname

[GitBox]

PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830577422



##
File path: charts/apisix-dashboard/templates/ingress.yaml
##
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
 {{- end }}
 kind: Ingress
 metadata:
+  {{- if .Values.ingress.classNmae }}
+  ingressClassName: {{- .Values.ingress.classNmae -}}

Review comment:
   values.yaml  file describe "ingressClassName"  kubernetes version ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org