[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #254: Ingress classname

[GitBox]

tokers commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830702118



##
File path: charts/apisix-dashboard/templates/ingress.yaml
##
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
 {{- end }}
 kind: Ingress
 metadata:
+  {{- if .Values.ingress.classNmae }}
+  ingressClassName: {{- .Values.ingress.classNmae -}}

Review comment:
   Yes, but I think readme should also be updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #254: Ingress classname

[GitBox]

tokers commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830567364



##
File path: charts/apisix-dashboard/templates/ingress.yaml
##
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
 {{- end }}
 kind: Ingress
 metadata:
+  {{- if .Values.ingress.classNmae }}
+  ingressClassName: {{- .Values.ingress.classNmae -}}

Review comment:
   There is a minimum version constraint for Kubernetes, Please update the 
document to classify it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org