[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #262: feat: ApisixRoute v2alpha1

[GitBox]

gxthrj commented on a change in pull request #262:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r586049600



##
File path: test/e2e/ingress/resourcepushing.go
##
@@ -64,19 +76,21 @@ spec:
ginkgo.It("create and then remove", func() {
backendSvc, backendSvcPort := s.DefaultHTTPBackend()
apisixRoute := fmt.Sprintf(`
-apiVersion: apisix.apache.org/v1
+apiVersion: apisix.apache.org/v2alpha1
 kind: ApisixRoute
 metadata:
   name: httpbin-route
 spec:
-  rules:
-  - host: httpbin.com
-http:
+  http:
+  - name: rule1
+match:
+  hosts:
+  - httpbin.com
   paths:
-  - backend:
-  serviceName: %s
-  servicePort: %d
-path: /ip
+  - /ip
+backend:
+  serviceName: %s
+  servicePort: %d

Review comment:
   Need more test case with v2alpha1. We may add more in future.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #262: feat: ApisixRoute v2alpha1

[GitBox]

gxthrj commented on a change in pull request #262:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r582535841



##
File path: pkg/ingress/controller/controller.go
##
@@ -338,17 +340,6 @@ type Api6Controller struct {
Stop  <-chan struct{}
 }
 
-func (api6 *Api6Controller) ApisixRoute(controller *Controller) {

Review comment:
   We discussed earlier that we should keep the v1 version for a while, 
declare in the document "deprecated", and delete the logic of v1 in version 1.0.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org