[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-988431614 > Thd code LGTM > > I added the label of `do-not-merge/hold` to it because this feature is not planned to be in the v1.4 version. > > Do you have a strong demand for this feature? @lxm right, I want to use apisix-ingress-controller to replace the nginx-ingress-controller without this feature, this can not be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987855282 ping @tao12345666333 @gxthrj @lingsamuel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987688535 > re-run all jobs. E2E tests failed with "check the ingress lb status is updated" this time, maybe something wrong with test cases. I can pass this case singly in a private environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-987622827 @gxthrj @tao12345666333 need a review I think the e2e failure has nothing to do with this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-986634421 > In addition, can you please add documentation to introduce this feature? done for docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-986156768 > In addition, can you please add documentation to introduce this feature? sure. Because `exprs` is complex, more configurations may be added in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-985498000 @tokers @tao12345666333 @lingsamuel @gxthrj finally got the e2e testing work. now, this PR needs a review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-984335293 > > > We may also add some test cases. > > > > > > have written more test cases. retested the feature > > By say adding test cases, we'd better also add the E2E test cases. working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-983463848 > We may also add some test cases. have written more test cases. retested the feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
