[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
neverCase commented on pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-984455512 > > Mostly LGTM but some import block style problems. > > @neverCase can you improve the code style? I had revert it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
neverCase commented on pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-983543907 @tao12345666333 hi, i'm ready -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
neverCase commented on pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-983469190 > @neverCase Sorry for delay. I leave some comments, I hope you can make changes ok, i will change these and update right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
neverCase commented on pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978892163 @tao12345666333 hi, i'm ok. I had add the missing license header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
