[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1145898685 yes, thanks @neverCase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1005932964 Thanks! @neverCase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1005397071 For this feature, there is one last task left. - [ ] Add docs to describe it. Who has time to help with this task? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-1002621775 Hi folks, The main part of the ApisixPluginConfig function has been implemented, thanks for your hard work @neverCase , great! I鈥檓 about to initiate a vote for the release of a new version of v1.4. This feature will appear for the first time in v1.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-988588107 @neverCase Thanks for your work, if you have time, you can continue the development of follow-up tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978006065 > * [ ] Add client implementation to interact with Apache APISIX. > * [ ] Add ApisixPluginConfig translator, it can convert ApisixPluginConfig data structure into APISIX. > * [ ] Add ApisixPluginConfig controller loop, It watches the ApisixPluginConfig resource in the Kubernetes cluster and converts it to the ApisixPluginConfig data structure. > * [ ] Add docs to describe it. @shelltea @fengshunli If you are interested, you can also choose one of the tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-977931641 #694 has been merged. 馃憤 You can do this job @neverCase - [ ] Add client implementation to interact with Apache APISIX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975193850 @neverCase I hope you complete the definition of CRD and data type first. eg. #689 or #694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-975187296 @neverCase You can refer to the following PR to split this work. So that others can also develop collaboratively. * [chore: consumer data structures by tokers 路 Pull Request #470 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/470) * [feat: apisixconsumer translator by tokers 路 Pull Request #474 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/474) * [feat: consumer controller loop by tao12345666333 路 Pull Request #516 路 apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/pull/516) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973928489 > Feel free to paste your questions there :). @neverCase If you need help, please feel free to ping us -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-973683759 @shelltea you can check #694 and #689 If @neverCase has time to complete this feature, we can include it in 1.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925514670 You can open a PR and set it as draf status. Related discussions can be held in the PR, which will be more convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925501421 @neverCase You can use `[]ApisixRouteHTTPPlugin` directly, no need to define the list yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638:
URL:
https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925493450
You can open a PR and submit your current changes directly.
The PluginConfig document is here
https://apisix.apache.org/docs/apisix/architecture-design/plugin-config
It looks like this:
```go
// ApisixPluginConfigSpec defines the desired state of
ApisixPluginConfigSpec.
type ApisixPluginConfigSpec struct {
Desc string`json:"desc,omitempty" yaml:"desc,omitempty"`
Plugins Plugins // it should be imported from
https://github.com/apache/apisix-ingress-controller/blob/3e9bdbf0cee6d49c8e0db27152d46565df704e8c/pkg/types/apisix/v1/types.go#L158
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925487850 After discussing it with @tokers and @gxthrj . We finally reached an agreement. We can set the `plugins` field and `pluginconfig` field in `ApisixRoute` to be mutually exclusive. This means that the user can only configure one of the `plugins` or `pluginconfig` in `ApisixRoute`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925446318 > I had replied a mail on the apache mail list, but it seems something wrong. > After sending, i can't find my reply on the mail list. > @tao12345666333 @tokers Yes, you need to subscribe the d...@apisix.apache.org before you send any mails. **Of course, whether you are discussing in this issue or on the mailing list, it鈥檚 okay.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-925445772 > Add a CRD like `ApisixPluginConfig` to support a group of plugin configs, and `ApisixRoute` add a field be associated with it. > > If we want to implement this function, we can split the following tasks: > > * [ ] Add ApisixPluginConfig custom resource. Only need to modify YAML. > * [ ] Add ApisixPluginConfig data structures. > * [ ] Add client implementation to interact with Apache APISIX. > * [ ] Add ApisixPluginConfig translator, it can convert ApisixPluginConfig data structure into APISIX. > * [ ] Add ApisixPluginConfig controller loop, It watches the ApisixPluginConfig resource in the Kubernetes cluster and converts it to the ApisixPluginConfig data structure. > * [ ] Add docs to describe it. You can split this function into multiple small tasks to carry out, refer to these tasks I added in the description. @neverCase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924761923 Thanks! @neverCase If you need help, you can ping me at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924711179 cc @Donghui0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-924710123 Started a discussion on the mailing list https://lists.apache.org/thread.html/r6e989cb7087feff7ab48157d74cf47aab18c3a1cfd32474b0672e63f%40%3Cdev.apisix.apache.org%3E -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-900836800 Add this to v1.3 milestone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-900836800 Add this to v1.3 milestone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
