[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox


tao12345666333 commented on pull request #731:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-1003265292


   @Sindweller LGTM. Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

2021-12-30 Thread GitBox


tao12345666333 commented on pull request #731:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-1003258223


   @Sindweller Thanks! It looks great to me!
   
   Please fix the markdown lint error. Then we can merge this one. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

2021-11-24 Thread GitBox


tao12345666333 commented on pull request #731:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-978785418


   Can you add a document describing how to monitor and use this dashboard? 
Thanks 
   
   If you need any help please feel free to ping me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration

2021-11-24 Thread GitBox


tao12345666333 commented on pull request #731:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-977839782


   ping @Sindweller any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org