[GitHub] [apisix-ingress-controller] tokers commented on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox 


tokers commented on issue #293:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797245654


   > > We should use `Networking().V1beta1().Ingress().Informer().
   > 
   > yep, I make a PR to fixed.
   > 
   > > Some users running versions < Kubernetes 1.14
   > 
   > In addition, After K8s 1.13 the API server automatically translate 
`extensions/v1beta1.Ingress` objects to `networking/v1beta1.Ingress` objects, 
we may need to be compatible with the previous version.
   
   Then I think we should support "extensions/v1beta1.Ingress", instead of 
"networking/v1beta1.Ingress".



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox 


tokers commented on issue #293:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797164418


   @Junnplus Seems we have a bug here:
   
![image](https://user-images.githubusercontent.com/10428333/110876941-7413bd00-8313-11eb-9a22-8139cea16f10.png)
   
   We should use `Networking().V1beta1().Ingress().Informer().
   
   Would you like to submit a PR to solve this? Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org