[GitHub] [apisix-website] Yiyiyimu commented on pull request #303: chore: add alpha channel to showcase image for dark mode

2021-04-13 Thread GitBox 


Yiyiyimu commented on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-819173058


   > Wow, I see so many images got updated, but some images seem broken or too 
dark?
   
   @juzhiyuan On my side, no images got updated 🤣 The reason is all images 
coming from CDN, and it would not got updated when only in PR. 
   
   That's the same reason those two images got broken. I changed them from svg 
to png, so we could not use the original source from CDN anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #303: chore: add alpha channel to showcase image for dark mode

2021-04-12 Thread GitBox 


Yiyiyimu commented on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-817744716


   It seems the preview sites not showing the new version of those showcase 
images. So I could only to add some screenshots of open them locally in 
photoshop 🤦 
   
   Before:
   
![image](https://user-images.githubusercontent.com/34589752/114389933-33d08480-9bc8-11eb-83d4-8138a97a25a5.png)
   
   After:
   
![image](https://user-images.githubusercontent.com/34589752/114389908-2adfb300-9bc8-11eb-898c-9a3690eed6a5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org