[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

2022-03-20 Thread GitBox 


juzhiyuan commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830607387



##
File path: website/static/data/showcases.json
##
@@ -401,4 +401,4 @@
 "infoLink": "https://www.xinpianchang.com;,
 "pinned": true
   }
-]
+]

Review comment:
   ```suggestion
   ]
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

2022-03-18 Thread GitBox 


juzhiyuan commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829712920



##
File path: website/static/data/showcases.json
##
@@ -43,7 +43,7 @@
   },
   {
 "caption": "嘀嗒出行",
-"image": "showcase/didachuxing.jpg",
+"image": "showcase/didachuxing.webp",

Review comment:
   Hi, you could visit https://caniuse.com/?search=webp to check if a 
property or feature is supported in different browsers.
   
   
![image](https://user-images.githubusercontent.com/2106987/158945642-95cabb4e-2ec7-43a3-8e82-29448208f6e0.png)
   
   
   For webp, it seems that Safari doesn't support it well?
   
   
![image](https://user-images.githubusercontent.com/2106987/158945562-df409750-b19b-4974-ad79-154c70600b97.png)
   

##
File path: website/static/data/showcases.json
##
@@ -43,7 +43,7 @@
   },
   {
 "caption": "嘀嗒出行",
-"image": "showcase/didachuxing.jpg",
+"image": "showcase/didachuxing.webp",

Review comment:
   Microsoft drops IE, and I support not considering it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

2022-03-18 Thread GitBox 


juzhiyuan commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830052315



##
File path: website/static/data/showcases.json
##
@@ -43,7 +43,7 @@
   },
   {
 "caption": "嘀嗒出行",
-"image": "showcase/didachuxing.jpg",
+"image": "showcase/didachuxing.webp",

Review comment:
   Microsoft drops IE, and I support not considering it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

2022-03-17 Thread GitBox 


juzhiyuan commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829712920



##
File path: website/static/data/showcases.json
##
@@ -43,7 +43,7 @@
   },
   {
 "caption": "嘀嗒出行",
-"image": "showcase/didachuxing.jpg",
+"image": "showcase/didachuxing.webp",

Review comment:
   Hi, you could visit https://caniuse.com/?search=webp to check if a 
property or feature is supported in different browsers.
   
   
![image](https://user-images.githubusercontent.com/2106987/158945642-95cabb4e-2ec7-43a3-8e82-29448208f6e0.png)
   
   
   For webp, it seems that Safari doesn't support it well?
   
   
![image](https://user-images.githubusercontent.com/2106987/158945562-df409750-b19b-4974-ad79-154c70600b97.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org