date:20160603

Change in asterixdb[master]: ASTERIXDB-1131 and ASTERIXDB-1230: add regression tests.

2016-06-03 Thread Yingyi Bu (Code Review)

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/907

Change subject: ASTERIXDB-1131 and ASTERIXDB-1230: add regression tests.
..

ASTERIXDB-1131 and ASTERIXDB-1230: add regression tests.

Change-Id: I3b520d27e2c9ea2fbbd0cf5fbbcfa6d24ed094d9
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.4.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/list/query-ASTERIXDB-1131-2/query-ASTERIXDB-1131.1.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/list/query-ASTERIXDB-1131/query-ASTERIXDB-1131.1.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/list/query-ASTERIXDB-1131-2/query-ASTERIXDB-1131-2.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/list/query-ASTERIXDB-1131/query-ASTERIXDB-1131.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
10 files changed, 166 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/07/907/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.1.ddl.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.1.ddl.aql
new file mode 100644
index 000..acc0866
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.1.ddl.aql
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+drop dataverse test if exists;
+create dataverse test
+use dataverse test
+
+create type listType as {
+  "id": int64,
+  "list": [int64]
+}
+
+create dataset listDS(listType) primary key id;
+
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.2.update.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.2.update.aql
new file mode 100644
index 000..ea52da4
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.2.update.aql
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+use dataverse test;
+
+insert into dataset listDS({"id":1, "list":[1,2,3]});
+
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.3.query.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.3.query.aql
new file mode 100644
index 000..3ba701b
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/query-ASTERIXDB-1230/query-ASTERIXDB-1230.3.query.aql
@@ -0,0 +1,23 @@
+/*
+ *

Change in asterixdb[master]: ASTERIXDB-1131 and ASTERIXDB-1230: add regression tests.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1131 and ASTERIXDB-1230: add regression tests.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1583/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/907
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b520d27e2c9ea2fbbd0cf5fbbcfa6d24ed094d9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Yingyi Bu has submitted this change and it was merged.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Reviewed-on: https://asterix-gerrit.ics.uci.edu/899
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D

Change in asterixdb[master]: ASTERIXDB-1025: a test case to verify the fix.

2016-06-03 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1025: a test case to verify the fix.
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/905
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3297cdd00a3e9dd2bf0cf209c75eb1e1cc564c4b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 13:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1582/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#13).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Yingyi Bu has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

(16 comments)

https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java:

Line 99: IOptimizationContext context) throws AlgebricksException {
> Remove template params in this method?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java:

Line 246:  * @param toPush
> update comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java:

Line 425: new 
MutableObject(makeUnnestExpression(eo.first)), pVar,
> remove the template parameter?
Done


Line 481: throw new IllegalStateException(ERR_MSG);
> Should this just be an UnsupportedOperationException? Do we have a "usual" 
Done


Line 487: throw new IllegalStateException(ERR_MSG);
> Should this just be an UnsupportedOperationException?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java:

Line 329: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(recordType);
> rename this variable?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
File 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java:

Line 358: "Field: " + 
recType.getFieldNames()[optionalFieldId] + " can not be null");
> s/null/optional/?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java:

Line 112: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(this.recordType);
> rename variable?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java:

Line 191: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(inputRecType);
> rename variable?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java:

Line 111: missingTypeTag.set(bos.getByteArray(), start, end - 
start);
> What's the difference between missingReference and missingTypeTag? 
Done


Line 142: } catch (AsterixException e) {
> This seems to be the only place where we use TypeException. Could we remove
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java:

Line 159: 
> s/getExpendedOffset/getExpandedOffset/
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java:

Line 81: 
.deserialize(nextFieldValue.getByteArray()[nextFieldValue.getStartOffset()]);
> Would it make sense to re-use this typeTag for the next iteration (and get 
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java:

Line 337: } else {
> Should we just remove this else and fall through to the default case (addin
Done

Change in asterixdb[master]: Improve External Data

2016-06-03 Thread abdullah alamoudi (Code Review)

abdullah alamoudi has uploaded a new patch set (#2).

Change subject: Improve External Data
..

Improve External Data

This change enable an adapter to specify its data parser and not have
the user specify it and pass it as part of the adapter configurations.
In addition, it introduces a new parameter "parser-factory" that can be
used to specifies a parser factory instead of using parser to specify
a parser factory.

Change-Id: Iae2560c73fa63e9454f731b8e893ae779a2ac7d9
---
M .gitignore
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta/change-feed-with-meta-pk-in-meta.1.ddl.aql
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPRequestToRecordWithMetadataAndPKConverter.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/AdapterFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
10 files changed, 45 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/06/906/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/906
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iae2560c73fa63e9454f731b8e893ae779a2ac7d9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: PLEASE EDIT to provide a meaningful commit message!
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1580/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/906
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae2560c73fa63e9454f731b8e893ae779a2ac7d9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

(16 comments)

Looks great, just a few minor comments.

https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java:

Line 99: IOptimizationContext context) throws AlgebricksException {
Remove template params in this method?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java:

Line 246:  * @param toPush
update comment?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java:

Line 425: new 
MutableObject(makeUnnestExpression(eo.first)), pVar,
remove the template parameter?


Line 481: throw new IllegalStateException(ERR_MSG);
Should this just be an UnsupportedOperationException? Do we have a "usual" way 
to choose these?


Line 487: throw new IllegalStateException(ERR_MSG);
Should this just be an UnsupportedOperationException?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java:

Line 329: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(recordType);
rename this variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
File 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java:

Line 358: "Field: " + 
recType.getFieldNames()[optionalFieldId] + " can not be null");
s/null/optional/?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java:

Line 112: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(this.recordType);
rename variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java:

Line 191: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(inputRecType);
rename variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java:

Line 111: missingTypeTag.set(bos.getByteArray(), start, end - 
start);
What's the difference between missingReference and missingTypeTag? 

Also, shouldn't we always write using writeByte (which is unsynchronized)?


Line 142: } catch (AsterixException e) {
This seems to be the only place where we use TypeException. Could we remove it?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java:

Line 159: 
s/getExpendedOffset/getExpandedOffset/


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java:

Line 81: 
.deserialize(nextFieldValue.getByteArray()[nextFieldValue.getStartOffset()]);
Would it make sense to re-use this typeTag for the next iteration (and get the 
first type tag before the loop?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java:

Line 337: } else {
Should we just remove this else and fall through to the default case (adding a

[jira] [Assigned] (ASTERIXDB-1459) Debugging support for code that's generated ...

2016-06-03 Thread Yingyi Bu (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu reassigned ASTERIXDB-1459:


Assignee: Yingyi Bu

> Debugging support for code that's generated ...
> ---
>
> Key: ASTERIXDB-1459
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1459
> Project: Apache AsterixDB
>  Issue Type: Task
>  Components: AsterixDB
>Reporter: Till Westmann
>Assignee: Yingyi Bu
>
> ... or hidden behind generated code. Currently we generate some byte code to 
> avoid repetitive implementation of some language features. The disadvantage 
> of this approach is that the generated byte code (and code that's called from 
> the generated byte code) is difficult to debug. 
> We need to find a way to debug such code (e.g. by generating Java code that 
> could be picked up by a debugger?).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ASTERIXDB-1472) Exception when ingesting the data with filter on a field

2016-06-03 Thread Jianfeng Jia (JIRA)

Jianfeng Jia created ASTERIXDB-1472:
---

 Summary: Exception when ingesting the data with filter on a field
 Key: ASTERIXDB-1472
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1472
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Storage
 Environment: master code:
commit 2dff79736e6f3f877149317d02395dbd12e16a20
Date:   Thu Jun 2 23:13:52 2016 -0700

Reporter: Jianfeng Jia
Assignee: Murtadha Hubail


Here is the aql:
{code}
drop dataverse twitter if exists;
create dataverse twitter if not exists;
use dataverse twitter

create type typeUser if not exists as open {
id: int64,
name: string,
screen_name : string,
lang : string,
location: string,
create_at: date,
description: string,
followers_count: int32,
friends_count: int32,
statues_count: int64
}

create type typePlace if not exists as open{
country : string,
country_code : string,
full_name : string,
id : string,
name : string,
place_type : string,
bounding_box : rectangle
}

create type typeGeoTag if not exists as open {
stateID: int32,
stateName: string,
countyID: int32,
countyName: string,
cityID: int32?,
cityName: string?
}

create type typeTweet if not exists as open{
create_at : datetime,
id: int64,
"text": string,
in_reply_to_status : int64,
in_reply_to_user : int64,
favorite_count : int64,
coordinate: point?,
retweet_count : int64,
lang : string,
is_retweet: boolean,
hashtags : {{ string }} ?,
user_mentions : {{ int64 }} ? ,
user : typeUser,
place : typePlace?,
geo_tag: typeGeoTag
}

create dataset ds_tweet(typeTweet) if not exists primary key id with filter on 
create_at;
//"using" "compaction" "policy" CompactionPolicy ( Configuration )? )?
create index text_idx if not exists on ds_tweet("text") type keyword;
create index location_idx if not exists on ds_tweet(coordinate) type rtree;
create index time_idx if not exists on ds_tweet(create_at) type btree;
create index state_idx if not exists on ds_tweet(geo_tag.stateID) type btree;
create index county_idx if not exists on ds_tweet(geo_tag.countyID) type btree;
create index city_idx if not exists on ds_tweet(geo_tag.cityID) type btree;

create feed MessageFeed using localfs(
("path"="128.195.52.77:///home/jianfeng/data/head20m.adm"),
("format"="adm"),
("type-name"="typeTweet"));

set wait-for-completion-feed "true";
connect feed MessageFeed to dataset ds_tweet;

{code}

The exception seems related to the Merging phase 
{code}
java.lang.IllegalStateException
at 
org.apache.hyracks.storage.am.lsm.common.impls.PrefixMergePolicy.isMergeLagging(PrefixMergePolicy.java:151)
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness.exitComponents(LSMHarness.java:211)
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness.flush(LSMHarness.java:437)
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMTreeIndexAccessor.flush(LSMTreeIndexAccessor.java:105)
at 
org.apache.hyracks.storage.am.lsm.rtree.impls.LSMRTreeFlushOperation.call(LSMRTreeFlushOperation.java:74)
at 
org.apache.hyracks.storage.am.lsm.rtree.impls.LSMRTreeFlushOperation.call(LSMRTreeFlushOperation.java:34)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:744)
{code}

I uploaded small sample data 
[here|https://drive.google.com/open?id=0B423M7wGZj9ddlN2Zk1SZmFEOGs]





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1025: a test case to verify the fix.

2016-06-03 Thread Yingyi Bu (Code Review)

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/905

Change subject: ASTERIXDB-1025: a test case to verify the fix.
..

ASTERIXDB-1025: a test case to verify the fix.

Change-Id: I3297cdd00a3e9dd2bf0cf209c75eb1e1cc564c4b
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.4.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
6 files changed, 127 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/05/905/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.1.ddl.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.1.ddl.aql
new file mode 100644
index 000..f4eb328
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.1.ddl.aql
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+drop dataverse TinyCollege if exists;
+create dataverse TinyCollege;
+use dataverse TinyCollege;
+
+create type MentorType as open
+{
+  name:string
+}
+
+create type StaffType as open
+{
+  name: string,
+  office: string,
+  employment: interval,
+  mentor: MentorType
+}
+
+create dataset Staff(StaffType) primary key name;
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.2.update.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.2.update.aql
new file mode 100644
index 000..66514f8
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/nestrecords/query-ASTERIXDB-1025/query-ASTERIXDB-1025.2.update.aql
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+use dataverse TinyCollege;
+
+insert into dataset Staff ({"name":"Alex", "office":"A", 
"employment":interval(date("2003-01-01"), date("2008-01-01")), "mentor":
+{"name":"Agent K", "status":"unknown"}
+, "kids":{"name":"Joe","age":13}});
+
+insert into dataset Staff ({"name":"Frank", "office":"A", 
"employment":interval(date("2004-01-01"), date("2009-01-01")), "mentor":
+{"name":"Agent K", "status":"unknown"}
+, "kids":{"name":"Wrae","age":10}});
+
+insert into dataset Staff ({"name":"Henry", "office":"C", 
"employment":interval(date("2003-01-01"), date("2008-01-01")), 
"mentor":{"name":"Agent K", "status":"unknown"}});
+
+insert into dataset Staff ({"name":"Mary", "office":"B", 
"employment":interval(date("2006-01-01"), date("2010-01-01")), "mentor":
+{"name":"Agent K", "status":"unknown"}
+, "kids":{"name":"Jill","age":11}});
+
+insert into dataset Staff ({"name":"Vicky", "office":"D",

Change in asterixdb[master]: ASTERIXDB-1025: a test case to verify the fix.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1025: a test case to verify the fix.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1579/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/905
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3297cdd00a3e9dd2bf0cf209c75eb1e1cc564c4b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Adding three interval join algorithms.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Adding three interval join algorithms.
..


Patch Set 19:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/457
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4f9be43eb0c500f04f99438c34e69503591641d
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Adding three interval join algorithms.

2016-06-03 Thread Preston Carman (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/457

to look at the new patch set (#19).

Change subject: Adding three interval join algorithms.
..

Adding three interval join algorithms.

The algorithms are based the following join approaches: sort-merge, 
partition-based, and index-based.
The change includes an range connector used to partition ordered data.

Change-Id: Id4f9be43eb0c500f04f99438c34e69503591641d
---
M .gitignore
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/AbstractIntervalJoinPOperator.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IntervalIndexJoinPOperator.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IntervalPartitionJoinPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceRandomPartitioningFeedComputationRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/temporal/TranslateIntervalExpressionRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/util/JoinUtils.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
A asterixdb/asterix-app/data/tinycollege/staff.adm
A asterixdb/asterix-app/data/tinycollege/students.adm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M asterixdb/asterix-app/src/test/resources/logging.properties
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/range-connector/sort-hint-on-closed-numeric-desc.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/range-connector/sort-hint-on-closed-numeric.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/range-connector/sort-hint-on-closed-string-desc.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/range-connector/sort-hint-on-closed-string.plan
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by-exception_01/order-by-exception_01.4.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by-exception_02/order-by-exception_02.4.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by/order-by.4.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by/order-by.5.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by/order-by.6.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by/order-by.7.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/TemporalQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_functions/interval_functions.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_functions/interval_functions.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_functions/interval_functions.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.10.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.11.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.12.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.13.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.14.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.15.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.16.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.17.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.18.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.19.query.aql
A

[jira] [Resolved] (ASTERIXDB-1378) Feeds cannot sustain instance restart with NPE

2016-06-03 Thread Abdullah Alamoudi (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abdullah Alamoudi resolved ASTERIXDB-1378.
--
Resolution: Fixed

> Feeds cannot sustain instance restart with NPE
> --
>
> Key: ASTERIXDB-1378
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1378
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Yingyi Bu
>Assignee: Abdullah Alamoudi
>Priority: Critical
> Attachments: cc.log, test_nc1.log, test_nc2.log
>
>
> I created a feeds and it works fine.
> However, after I restart the instance,  I connect the feeds again to the same 
> dataset.  I feed one tuple into the feeds.  Then, the dataset becomes not 
> query-able with a NPE.
> Logs are attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ASTERIXDB-867) string value turns into "null" value when not casted

2016-06-03 Thread Yingyi Bu (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu reassigned ASTERIXDB-867:
---

Assignee: Yingyi Bu  (was: Ildar Absalyamov)

> string value turns into "null" value when not casted
> 
>
> Key: ASTERIXDB-867
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-867
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB
>Reporter: asterixdb-importer
>Assignee: Yingyi Bu
>Priority: Minor
> Attachments: page_views_test.adm
>
>
> string value turns into "null" value when not casted



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ASTERIXDB-880) Nested IF-THEN-ELSE query - non implemented exception

2016-06-03 Thread Yingyi Bu (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu reassigned ASTERIXDB-880:
---

Assignee: Yingyi Bu  (was: Preston Carman)

> Nested IF-THEN-ELSE query - non implemented exception
> -
>
> Key: ASTERIXDB-880
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-880
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Optimizer
>Reporter: asterixdb-importer
>Assignee: Yingyi Bu
>
> Nested IF-THEN-ELSE query - non implemented exception



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ASTERIXDB-1131) The function-generated Null is omitted when construct a List

2016-06-03 Thread Yingyi Bu (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu reassigned ASTERIXDB-1131:


Assignee: Yingyi Bu  (was: Ildar Absalyamov)

> The function-generated Null is omitted when construct a List
> 
>
> Key: ASTERIXDB-1131
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1131
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Data Model
>Reporter: Jianfeng Jia
>Assignee: Yingyi Bu
>
> I hit a failed test case in which I was building a list with the elements 
> generated from a build-in function, as below,
> for $a in [
> starts-with("xyz",  null),
> starts-with("xy", "x")
> ]
> return $a
> If any of the elements is Null, it will be omitted in the returned list, e.g. 
> the above query returns the following result:
> [ true
>  ]
> However if I explicitly add a null in the list, all the Nulls will be 
> returned.
> the following query:
> for $a in [
> null,
> starts-with("xy",  null),
> starts-with("xy", "x")
> ]
> return $a
> will return the expected result:
> [ null
> , null
> , true
>  ]
> It applies for other similar functions which return an option value. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ASTERIXDB-1212) Close-type list doesn't handle NULL well

2016-06-03 Thread Yingyi Bu (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu reassigned ASTERIXDB-1212:


Assignee: Yingyi Bu  (was: Ildar Absalyamov)

> Close-type list doesn't handle NULL well 
> -
>
> Key: ASTERIXDB-1212
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1212
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Data Model
>Reporter: Jianfeng Jia
>Assignee: Yingyi Bu
>
> First, I observed the out of range access for the closed-type list and 
> open-type list are quite different:
> {code}
> // closed type:
> let $all := [ { "ka":"a1",  "kb":"b1"}, 
>  { "ka":"a2",  "kb":"b2"}]
> return $all[3].ka
> {code}
> It returns a "", I think it should be null. 
> If I change the type to a hytogenous type like below 
> {code}
> // open type:
> let $all := [ { "ka":"a1",  "kb":"b1"}, 
>  { "ka":2,  "kb":"b2"}]
> return $all[3].ka
> {code}
> It returns a null as expected. 
> Furthermore, the closed-type will return the wrong result by just access 
> field by index other than by name. Here is example
> {code}
> let $all := [ { "ka":"a1",  "kb":"b1"}, 
>{ "ka":"a2",  "kb":"b2"}]
> for $x in $all
> group by $k := $x.kb with $x
> return { "g": $k, "s1": $x[1].ka}
> {code}
> It returns
> {code}
> { "g": "b1", "s1": "b1" }
> { "g": "b2", "s1": "b2" }
> {code}
> It seems it skipped some offset directly without verify if the record is null 
> or not. 
> The open type doesn't have this problem. The following code 
> {code}
> let $all := [ { "ka":"a1",  "kb":"b1"}, 
>{ "ka":2,  "kb":"b2"}]  // change ka to 2 to make a 
> heterogenous type list
> for $x in $all
> group by $k := $x.kb with $x
> return { "g": $k, "s1": $x[1].ka}
> {code}
> will always return 
> {code}
> { "g": "b1", "s1": null }
> { "g": "b2", "s1": null }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1189: add a test case to verify the fix.

2016-06-03 Thread Jianfeng Jia (Code Review)

Jianfeng Jia has posted comments on this change.

Change subject: ASTERIXDB-1189: add a test case to verify the fix.
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/904
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-HasComments: No

Change in asterixdb[master]: Ignore asterix-opt

2016-06-03 Thread abdullah alamoudi (Code Review)

abdullah alamoudi has submitted this change and it was merged.

Change subject: Ignore asterix-opt
..


Ignore asterix-opt

This change adds asterix-opt to gitignore in order to not push
extension development code into the apache asterixdb repository

Change-Id: I5199c8c0d166ef5e5ed70b541e0b96e485801d68
Reviewed-on: https://asterix-gerrit.ics.uci.edu/903
Reviewed-by: Till Westmann 
Reviewed-by: Jenkins 
Tested-by: Jenkins 
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified



diff --git a/.gitignore b/.gitignore
index ced139e..636fb2f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,6 +12,7 @@
 asterix_logs
 build
 bin
+asterixdb/asterix-opt/
 asterixdb/asterix-app/src/test/resources/externallib/
 asterixdb/asterix-app/rttest/
 asterixdb/asterix-app/mdtest/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/903
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5199c8c0d166ef5e5ed70b541e0b96e485801d68
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: Optionally log image before when before image found in memor...

2016-06-03 Thread abdullah alamoudi (Code Review)

abdullah alamoudi has submitted this change and it was merged.

Change subject: Optionally log image before when before image found in memory 
component
..


Optionally log image before when before image found in memory component

In addition, this change fixes an issue with one of the test cases for
FrameSpiller.

Change-Id: Iaaed48f4c2ca8d83253e81cd7c60aad998b67b1e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/900
Tested-by: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexModificationOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexModificationOperationCallbackFactory.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/SecondaryIndexModificationOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/SecondaryIndexModificationOperationCallbackFactory.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/UpsertOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/UpsertOperationCallbackFactory.java
M asterixdb/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java
D 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriterFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
18 files changed, 250 insertions(+), 192 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified



diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
index 45e3b06..507a393 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
@@ -132,7 +132,7 @@
 /**
  * Constructor which wraps an IApplicationConfig.
  */
-public AsterixPropertiesAccessor (IApplicationConfig cfg) {
+public AsterixPropertiesAccessor(IApplicationConfig cfg) {
 this.cfg = cfg;
 instanceName = cfg.getString("asterix", "instance", 
"DEFAULT_INSTANCE");
 String mdNode = null;
@@ -234,7 +234,8 @@
 return interpreter.interpret(value);
 } catch (IllegalArgumentException e) {
 if (LOGGER.isLoggable(Level.SEVERE)) {
-StringBuilder msg = new StringBuilder("Invalid property value 
'" + value + "' for property '" + property + "'.\n");
+StringBuilder msg =
+new StringBuilder("Invalid property value '" + value + 
"' for property '" + property + "'.\n");
 if (p != null) {
 msg.append("See the description: \n" + p.getDescription() 
+ "\n");
 }
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
index 5445b11..9a76b40 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
@@ -48,7 +48,7 @@
 /**
  * The following three variables are used

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1576/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Optionally log image before when before image found in memor...

2016-06-03 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: Optionally log image before when before image found in memory 
component
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/900
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaed48f4c2ca8d83253e81cd7c60aad998b67b1e
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1575/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#11).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 10:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#10).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Ignore asterix-opt

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Ignore asterix-opt
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1573/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/903
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5199c8c0d166ef5e5ed70b541e0b96e485801d68
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Updated] (ASTERIXDB-1470) large amount of failed entries in failed record log

2016-06-03 Thread Christopher Green (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher Green updated ASTERIXDB-1470:
-
Attachment: sample_failed_record.log

Sample of the failed record log.

> large amount of failed entries in failed record log
> ---
>
> Key: ASTERIXDB-1470
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1470
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Feeds
>Reporter: Christopher Green
>Assignee: Abdullah Alamoudi
> Attachments: sample_failed_record.log
>
>
> Thank you again for your work in this space.  I have pulled down the new code 
> from the repository and built it Tuesday morning.  I understand from the 
> email message that I would have to remove the instance and create it from 
> scratch.  This wasn't an issue as we have a bunch of data stored up.  Once 
> the instance was deleted, I created the table and feeder and connected the 
> feeder.  We're at about 8 million entries this morning and a count of these 
> entries took about 113 seconds. 
> As of this morning, the failed error log is quite large.  I took a cursory 
> look at the failed entries and they don't appear to be very large entries.  
> Could this be an issue with parsing the classad expressions?
> Let me know if there's anything you need. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Optionally log image before when before image found in memor...

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Optionally log image before when before image found in memory 
component
..


Patch Set 7:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/900
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaed48f4c2ca8d83253e81cd7c60aad998b67b1e
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Optionally log image before when before image found in memor...

2016-06-03 Thread abdullah alamoudi (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/900

to look at the new patch set (#7).

Change subject: Optionally log image before when before image found in memory 
component
..

Optionally log image before when before image found in memory component

In addition, this change fixes an issue with one of the test cases for
FrameSpiller.

Change-Id: Iaaed48f4c2ca8d83253e81cd7c60aad998b67b1e
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexModificationOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexModificationOperationCallbackFactory.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/SecondaryIndexModificationOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/SecondaryIndexModificationOperationCallbackFactory.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/UpsertOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/UpsertOperationCallbackFactory.java
M asterixdb/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java
D 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriterFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
18 files changed, 250 insertions(+), 192 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/00/900/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/900
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaaed48f4c2ca8d83253e81cd7c60aad998b67b1e
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#9).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: WIP - QueryService API updates

2016-06-03 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: WIP - QueryService API updates
..


Patch Set 9:

patch set 9 is just a rebase

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: WIP - QueryService API updates

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: WIP - QueryService API updates
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1570/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: WIP - QueryService API updates

2016-06-03 Thread Till Westmann (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/896

to look at the new patch set (#9).

Change subject: WIP - QueryService API updates
..

WIP - QueryService API updates

- API returns non-JSON results (ADM/CSV) as arrays of (escaped) strings
- fix encoding and content-length of response
- run SQL++ query tests through QueryService API
- small API cleanup

Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
D 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/JSONUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/records/RecordsQueries.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
10 files changed, 640 insertions(+), 356 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/896/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu

Change in asterixdb[master]: small cleanup in APIFramework

2016-06-03 Thread Till Westmann (Code Review)

Till Westmann has submitted this change and it was merged.

Change subject: small cleanup in APIFramework
..


small cleanup in APIFramework

Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/902
Tested-by: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
1 file changed, 62 insertions(+), 108 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index 5cd049d..f07fb76 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -97,55 +97,42 @@
 }
 
 private static List> buildDefaultLogicalRewrites() {
-List> 
defaultLogicalRewrites = new ArrayList>();
+List> 
defaultLogicalRewrites = new ArrayList<>();
 SequentialFixpointRuleController seqCtrlNoDfs = new 
SequentialFixpointRuleController(false);
 SequentialFixpointRuleController seqCtrlFullDfs = new 
SequentialFixpointRuleController(true);
 SequentialOnceRuleController seqOnceCtrl = new 
SequentialOnceRuleController(true);
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildInitialTranslationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildTypeInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildAutogenerateIDRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildNormalizationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildLoadFieldsRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildInitialTranslationRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildTypeInferenceRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildAutogenerateIDRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildNormalizationRuleCollection()));
+defaultLogicalRewrites
+.add(new Pair<>(seqCtrlNoDfs, 
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildLoadFieldsRuleCollection()));
 // fj
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildFuzzyJoinRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildFuzzyJoinRuleCollection()));
 //
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildNormalizationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildLoadFieldsRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildDataExchangeRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildConsolidationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildAccessMethodRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildPlanCleanupRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildNormalizationRuleCollection()));
+

Change in asterixdb[master]: Optionally log image before when before image found in memor...

2016-06-03 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: Optionally log image before when before image found in memory 
component
..


Patch Set 6:

(1 comment)

Tons of line-length regressions in AqlMetadataProvider.java need to be fixed as 
well.

https://asterix-gerrit.ics.uci.edu/#/c/900/6/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/UpsertOperationCallback.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/UpsertOperationCallback.java:

Line 51: if (logBeforeImage) {
inline conditional op


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/900
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaed48f4c2ca8d83253e81cd7c60aad998b67b1e
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: small cleanup in APIFramework

2016-06-03 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: small cleanup in APIFramework
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/902
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1438) BufferCache spins indefinitely when cache is exceeded

2016-06-03 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314183#comment-15314183
 ] 

ASF subversion and git services commented on ASTERIXDB-1438:


Commit 4bab67bf282e650a6e8c41b338f357b0d47c9714 in incubator-asterixdb's branch 
refs/heads/master from [~mblow]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-asterixdb.git;h=4bab67b ]

ASTERIXDB-1438: BufferCache spins indefinitely...

Fixes ASTERIXDB-1438: BufferCache spins indefinitely when cache is exceeded

After three unsuccessful cycles (each traversing clock pages three times)
and waiting for dirty pages to be cleaned, an exception is thrown

Change-Id: I327a7423bd630c96e16601b1a3a2a21f558f9f50
Reviewed-on: https://asterix-gerrit.ics.uci.edu/894
Tested-by: Jenkins 
Reviewed-by: Till Westmann 


> BufferCache spins indefinitely when cache is exceeded
> -
>
> Key: ASTERIXDB-1438
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1438
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Michael Blow
>Assignee: Michael Blow
>Priority: Critical
>
> In case of cache exhaustion, BufferCache.findPage/confiscatePage() will spin 
> forever waiting for pages to be returned to the cache.  These should give up 
> and fail the request after a reasonable number of attempts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1438) BufferCache spins indefinitely when cache is exceeded

2016-06-03 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314184#comment-15314184
 ] 

ASF subversion and git services commented on ASTERIXDB-1438:


Commit 4bab67bf282e650a6e8c41b338f357b0d47c9714 in incubator-asterixdb's branch 
refs/heads/master from [~mblow]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-asterixdb.git;h=4bab67b ]

ASTERIXDB-1438: BufferCache spins indefinitely...

Fixes ASTERIXDB-1438: BufferCache spins indefinitely when cache is exceeded

After three unsuccessful cycles (each traversing clock pages three times)
and waiting for dirty pages to be cleaned, an exception is thrown

Change-Id: I327a7423bd630c96e16601b1a3a2a21f558f9f50
Reviewed-on: https://asterix-gerrit.ics.uci.edu/894
Tested-by: Jenkins 
Reviewed-by: Till Westmann 


> BufferCache spins indefinitely when cache is exceeded
> -
>
> Key: ASTERIXDB-1438
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1438
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Michael Blow
>Assignee: Michael Blow
>Priority: Critical
>
> In case of cache exhaustion, BufferCache.findPage/confiscatePage() will spin 
> forever waiting for pages to be returned to the cache.  These should give up 
> and fail the request after a reasonable number of attempts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1438: BufferCache spins indefinitely...

2016-06-03 Thread Michael Blow (Code Review)

Michael Blow has submitted this change and it was merged.

Change subject: ASTERIXDB-1438: BufferCache spins indefinitely...
..


ASTERIXDB-1438: BufferCache spins indefinitely...

Fixes ASTERIXDB-1438: BufferCache spins indefinitely when cache is exceeded

After three unsuccessful cycles (each traversing clock pages three times)
and waiting for dirty pages to be cleaned, an exception is thrown

Change-Id: I327a7423bd630c96e16601b1a3a2a21f558f9f50
Reviewed-on: https://asterix-gerrit.ics.uci.edu/894
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AsyncFIFOPageQueueManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/DelayPageCleanerPolicy.java
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/IPageCleanerPolicy.java
4 files changed, 131 insertions(+), 118 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AsyncFIFOPageQueueManager.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AsyncFIFOPageQueueManager.java
index 1bbe6db..114dcb8 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AsyncFIFOPageQueueManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AsyncFIFOPageQueueManager.java
@@ -125,6 +125,7 @@
 }
 }
 } catch (InterruptedException e) {
+Thread.currentThread().interrupt();
 // TODO what do we do here?
 e.printStackTrace();
 }
@@ -140,6 +141,7 @@
 try {
 entry = queue.take();
 } catch(InterruptedException e) {
+Thread.currentThread().interrupt();
 break;
 }
 if (entry.getQueueInfo() != null && 
entry.getQueueInfo().hasWaiters()){
diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
index 2b6dd73..201526b 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
@@ -54,6 +54,7 @@
 
 private static final int MIN_CLEANED_COUNT_DIFF = 3;
 private static final int PIN_MAX_WAIT_TIME = 50;
+private static final int MAX_PIN_ATTEMPT_CYCLES = 3;
 public static final boolean DEBUG = false;
 
 private final int pageSize;
@@ -74,7 +75,7 @@
 private ConcurrentHashMap pinnedPageOwner;
 //!DEBUG
 private IIOReplicationManager ioReplicationManager;
-private List cachedPages = new ArrayList<>();
+private final List cachedPages = new ArrayList<>();
 
 private boolean closed;
 
@@ -94,16 +95,16 @@
 this.fileMapManager = fileMapManager;
 
 Executor executor = Executors.newCachedThreadPool(threadFactory);
-fileInfoMap = new HashMap();
-virtualFiles = new HashSet();
+fileInfoMap = new HashMap<>();
+virtualFiles = new HashSet<>();
 cleanerThread = new CleanerThread();
 executor.execute(cleanerThread);
 closed = false;
 
 fifoWriter = new AsyncFIFOPageQueueManager(this);
 if( DEBUG ) {
-confiscatedPages = new ArrayList();
-confiscatedPagesOwner = new HashMap();
+confiscatedPages = new ArrayList<>();
+confiscatedPagesOwner = new HashMap<>();
 confiscateLock = new ReentrantLock();
 pinnedPageOwner = new ConcurrentHashMap<>();
 }
@@ -135,7 +136,7 @@
 
 // check whether file has been created and opened
 int fileId = BufferedFileHandle.getFileId(dpid);
-BufferedFileHandle fInfo = null;
+BufferedFileHandle fInfo;
 synchronized (fileInfoMap) {
 fInfo = fileInfoMap.get(fileId);
 }
@@ -185,7 +186,7 @@
 if (DEBUG) {
 pinSanityCheck(dpid);
 }
-CachedPage cPage = findPage(dpid,

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 8:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#8).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1569/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1568/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#7).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: small cleanup in APIFramework

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: small cleanup in APIFramework
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1567/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/902
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: small cleanup in APIFramework

2016-06-03 Thread Till Westmann (Code Review)

Till Westmann has uploaded a new patch set (#2).

Change subject: small cleanup in APIFramework
..

small cleanup in APIFramework

Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
1 file changed, 62 insertions(+), 108 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/02/902/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/902
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: ASTERIXDB-1438: BufferCache spins indefinitely...

2016-06-03 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1438: BufferCache spins indefinitely...
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/894
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I327a7423bd630c96e16601b1a3a2a21f558f9f50
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

54 matches

Mail list logo