Change in asterixdb[master]: ASTERIXDB-1625: NC2NC Messaging NCService Config

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1625: NC2NC Messaging NCService Config
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/789/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1231
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacfd3cabb084319cd7458c938fd43f82b2f7fe52
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1625: NC2NC Messaging NCService Config

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1625: NC2NC Messaging NCService Config
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/789/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1231
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacfd3cabb084319cd7458c938fd43f82b2f7fe52
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Default NCService PID to -1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Default NCService PID to -1
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/788/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If331fc62da4daf20539204ae38e9e29da047571b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: improve error messages

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: improve error messages
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/787/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1225
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia82cd34ae5099f924302d7d42b541247a258c9b9
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1625: NC2NC Messaging NCService Config

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1625: NC2NC Messaging NCService Config
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2843/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1231
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacfd3cabb084319cd7458c938fd43f82b2f7fe52
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1625: NC2NC Messaging NCService Config

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1231

Change subject: ASTERIXDB-1625: NC2NC Messaging NCService Config
..

ASTERIXDB-1625: NC2NC Messaging NCService Config

NC2NC Messaging networking parameters should be configurable when using
NCService.  Adds the following NCService INI configuration parameters:

- messaging.address
- messaging.port
- public.messaging.address
- public.messaging.port

Change-Id: Iacfd3cabb084319cd7458c938fd43f82b2f7fe52
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
1 file changed, 52 insertions(+), 22 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/31/1231/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
index de336ed..049a55a 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
@@ -34,7 +34,8 @@
 public class NCConfig implements Serializable {
 private static final long serialVersionUID = 2L;
 
-@Option(name = "-cc-host", usage = "Cluster Controller host name (required 
unless specified in config file)", required = false)
+@Option(name = "-cc-host", usage = "Cluster Controller host name (required 
unless specified in config file)",
+required = false)
 public String ccHost = null;
 
 @Option(name = "-cc-port", usage = "Cluster Controller port (default: 
1099)", required = false)
@@ -43,76 +44,100 @@
 @Option(name = "-address", usage = "IP Address for NC (default: 
localhost)", required = false)
 public String ipAddress = 
InetAddress.getLoopbackAddress().getHostAddress();
 
-@Option(name = "-cluster-net-ip-address", usage = "IP Address to bind 
cluster listener (default: same as -address)", required = false)
+@Option(name = "-cluster-net-ip-address", usage = "IP Address to bind 
cluster listener (default: same as -address)",
+required = false)
 public String clusterNetIPAddress;
 
-@Option(name = "-cluster-net-port", usage = "IP port to bind cluster 
listener (default: random port)", required = false)
+@Option(name = "-cluster-net-port", usage = "IP port to bind cluster 
listener (default: random port)",
+required = false)
 public int clusterNetPort = 0;
 
-@Option(name = "-cluster-net-public-ip-address", usage = "Public IP 
Address to announce cluster listener (default: same as 
-cluster-net-ip-address)", required = false)
+@Option(name = "-cluster-net-public-ip-address",
+usage = "Public IP Address to announce cluster listener (default: 
same as -cluster-net-ip-address)",
+required = false)
 public String clusterNetPublicIPAddress;
 
-@Option(name = "-cluster-net-public-port", usage = "Public IP port to 
announce cluster listener (default: same as -cluster-net-port; must set 
-cluser-net-public-ip-address also)", required = false)
+@Option(name = "-cluster-net-public-port",
+usage = "Public IP port to announce cluster listener (default: 
same as -cluster-net-port; " +
+"must set -cluster-net-public-ip-address also)", required 
= false)
 public int clusterNetPublicPort = 0;
 
-@Option(name = "-node-id", usage = "Logical name of node controller unique 
within the cluster (required unless specified in config file)", required = 
false)
+@Option(name = "-node-id", usage = "Logical name of node controller unique 
within the cluster (required unless " +
+"specified in config file)", required = false)
 public String nodeId = null;
 
-@Option(name = "-data-ip-address", usage = "IP Address to bind data 
listener (default: same as -address)", required = false)
+@Option(name = "-data-ip-address", usage = "IP Address to bind data 
listener (default: same as -address)",
+required = false)
 public String dataIPAddress;
 
 @Option(name = "-data-port", usage = "IP port to bind data listener 
(default: random port)", required = false)
 public int dataPort = 0;
 
-@Option(name = "-data-public-ip-address", usage = "Public IP Address to 
announce data listener (default: same as -data-ip-address)", required = false)
+@Option(name = "-data-public-ip-address",
+usage = "Public IP Address to announce data listener (default: 
same as -data-ip-address)", required = false)
 public String dataPublicIPAddress;
 
-

Change in asterixdb[master]: fix error message for union with set semantics

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix error message for union with set semantics
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/786/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1229
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b69ab843795221ef5c9a533839ed6d359b7c8e3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Default NCService PID to -1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Default NCService PID to -1
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2842/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If331fc62da4daf20539204ae38e9e29da047571b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Default NCService PID to -1

[Michael Blow (Code Review)]

Michael Blow has uploaded a new patch set (#2).

Change subject: Default NCService PID to -1
..

Default NCService PID to -1

As 0 is technically a valid PID, default the NCService PID to -1 in case
not supplied.

Change-Id: If331fc62da4daf20539204ae38e9e29da047571b
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1230/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If331fc62da4daf20539204ae38e9e29da047571b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Default NCService PID to -1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Default NCService PID to -1
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2841/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If331fc62da4daf20539204ae38e9e29da047571b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Default NCService PID to -1

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1230

Change subject: Default NCService PID to -1
..

Default NCService PID to -1

As 0 is technically a valid PID, default the NCService PID to -1 in case
not supplied.

Change-Id: If331fc62da4daf20539204ae38e9e29da047571b
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1230/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
index de336ed..e0c76cb 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
@@ -112,7 +112,6 @@
 @Option(name = "-config-file", usage = "Specify path to local 
configuration file (default: no local config)", required = false)
 public String configFile = null;
 
-//TODO add messaging values to NC start scripts
 @Option(name = "-messaging-ip-address", usage = "IP Address to bind 
messaging "
 + "listener (default: same as -address)", required = false)
 public String messagingIPAddress;
@@ -130,7 +129,7 @@
 public int messagingPublicPort = 0;
 
 @Option(name = "-ncservice-pid", usage = "PID of the NCService which 
launched this NCDriver", required = false)
-public int ncservicePid = 0;
+public int ncservicePid = -1;
 
 @Argument
 @Option(name = "--", handler = StopOptionHandler.class)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1230
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If331fc62da4daf20539204ae38e9e29da047571b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 

Change in asterixdb[master]: fix error message for union with set semantics

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix error message for union with set semantics
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/786/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1229
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b69ab843795221ef5c9a533839ed6d359b7c8e3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: improve error messages

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: improve error messages
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2840/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1225
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia82cd34ae5099f924302d7d42b541247a258c9b9
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: fix error message for union with set semantics

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix error message for union with set semantics
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2839/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1229
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b69ab843795221ef5c9a533839ed6d359b7c8e3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: improve error messages

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: improve error messages
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2838/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1225
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia82cd34ae5099f924302d7d42b541247a258c9b9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: improve error messages

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1225

to look at the new patch set (#2).

Change subject: improve error messages
..

improve error messages

Change-Id: Ia82cd34ae5099f924302d7d42b541247a258c9b9
---
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
2 files changed, 16 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/25/1225/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1225
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia82cd34ae5099f924302d7d42b541247a258c9b9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Full-text implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text implementation step 1
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2837/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1228
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1636) Feed cannot re-ingest after cluster restart

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534686#comment-15534686
 ] 

ASF subversion and git services commented on ASTERIXDB-1636:


Commit 2685b60d9e03a515fcc5260a3dd4399740f5ec40 in asterixdb's branch 
refs/heads/master from [~imaxon]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=2685b60 ]

Fixes for ASTERIXDB-1636

The index of the tuple field for filters from SecondaryIndexOperationsHelper 
and AqlMetadataProvider
differed. The one in AqlMetadataProvider was wrong, as it was attempting to 
take into account the
presence of a partitioning field in the incoming tuple, which is not there in 
the case of an
insert/upsert.

There was also an issue where on merge, for components with a filter page but 
no min/max, the merge
would fail. I fixed this by skipping over null entries while getting the 
min/max of merging components.

Finally, there was a very silly error in LSMComponentFilterManager which was 
causing the filter page
to appear as blank, because the page was being pinned with the wrong argument. 
That is also fixed.

Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1205
Sonar-Qube: Jenkins 
Reviewed-by: Taewoo Kim 
Tested-by: Jenkins 
Integration-Tests: Jenkins 


> Feed cannot re-ingest after cluster restart
> ---
>
> Key: ASTERIXDB-1636
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1636
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Feeds, Storage
> Environment: master
> commit c89d668f68e5430a6ba4455daf8f9cd6f7040dd8
> Date:   Tue Sep 6 18:29:23 2016 -0700
>Reporter: Jianfeng Jia
>Assignee: Ian Maxon
>Priority: Blocker
>  Labels: soon
>
> Here are steps to reproduce the problem:
> 1. start the cluster
> 2. ingest the initial data using file feed 
> [script|https://gist.github.com/JavierJia/9ed7744c938c5cb66aba63007b86a987]
> 2.1: file for ingestion: 
> https://drive.google.com/open?id=0B423M7wGZj9dNE5HenFqcjhuUFk
> 3. start another socket feed 
> [script|https://gist.github.com/JavierJia/565cefd9322df35c7abeefbfcfcee9f8] 
> to ingest the live data  
> 4. restart the cluster
> 5. start that live socket feed again.
> 6. with your own twitter credential you can use [this 
> script|https://github.com/ISG-ICS/cloudberry/blob/master/streamFeed.sh]  to 
> ingest the tweet
> 7. It will send at most 280 tweets and stops forever.
> [~imaxon] [~idleft] if you can help that will be great.
> related to ASTERIXDB-1264



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1611) AsterixDB + Hyracks daemon threads should have reasonable names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534685#comment-15534685
 ] 

ASF subversion and git services commented on ASTERIXDB-1611:


Commit 102ef590b1475731732feadf8c7e7302b7bb9968 in asterixdb's branch 
refs/heads/master from [~mblow]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=102ef59 ]

ASTERIXDB-1611: Improve Thread Names

Executor threads are now named as follows:

- "Executor-:"

Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1226
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 


> AsterixDB + Hyracks daemon threads should have reasonable names
> ---
>
> Key: ASTERIXDB-1611
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1611
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Hyracks
>Reporter: Michael Blow
>Assignee: Michael Blow
>
> A number of threads are started in AsterixDB that do not have well-named 
> threads.  This hinders the ability to debug / diagnose problems.
> This includes:
> - LogManager.FlushLogsLogger
> - LogFlusher
> - BufferCache.CleanerThread
> - ResultStateSweeper
> - (hyracks.control.common.work.)WorkQueue.WorkerThread
> - (asterix.hyracks.bootstrap.)ClusterWorkExecutor



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/785/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Ian Maxon (Code Review)]

Ian Maxon has submitted this change and it was merged.

Change subject: Fixes for ASTERIXDB-1636
..


Fixes for ASTERIXDB-1636

The index of the tuple field for filters from SecondaryIndexOperationsHelper 
and AqlMetadataProvider
differed. The one in AqlMetadataProvider was wrong, as it was attempting to 
take into account the
presence of a partitioning field in the incoming tuple, which is not there in 
the case of an
insert/upsert.

There was also an issue where on merge, for components with a filter page but 
no min/max, the merge
would fail. I fixed this by skipping over null entries while getting the 
min/max of merging components.

Finally, there was a very silly error in LSMComponentFilterManager which was 
causing the filter page
to appear as blank, because the page was being pinned with the wrong argument. 
That is also fixed.

Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1205
Sonar-Qube: Jenkins 
Reviewed-by: Taewoo Kim 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
---
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
3 files changed, 22 insertions(+), 19 deletions(-)

Approvals:
  Taewoo Kim: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
index 29087ba..e05aa25 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
@@ -1833,7 +1833,6 @@
 // One token (+ optional partitioning field) + primary keys: [token,
 // number of token, PK]
 int numKeys = primaryKeys.size() + secondaryKeys.size();
-int numTokenKeyPairFields = (!isPartitioned) ? 1 + primaryKeys.size() 
: 2 + primaryKeys.size();
 int numFilterFields = DatasetUtils.getFilterField(dataset) == null ? 0 
: 1;
 
 // generate field permutations
@@ -1960,8 +1959,9 @@
 }
 
 filterFieldsForNonBulkLoadOps = new int[numFilterFields];
-filterFieldsForNonBulkLoadOps[0] = numTokenKeyPairFields;
-invertedIndexFieldsForNonBulkLoadOps = new 
int[numTokenKeyPairFields];
+//for non-bulk-loads, there is only  in the incoming 
tuples
+filterFieldsForNonBulkLoadOps[0] = numKeys;
+invertedIndexFieldsForNonBulkLoadOps = new int[numKeys];
 for (int k = 0; k < 
invertedIndexFieldsForNonBulkLoadOps.length; k++) {
 invertedIndexFieldsForNonBulkLoadOps[k] = k;
 }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
index d0d7e69..93225cf 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
@@ -56,36 +56,33 @@
 }
 
 @Override
-public void writeFilterInfo(ILSMComponentFilter filter, ITreeIndex 
treeIndex ) throws HyracksDataException {
+public void writeFilterInfo(ILSMComponentFilter filter, ITreeIndex 
treeIndex) throws HyracksDataException {
 IMetaDataPageManager treeMetaManager = treeIndex.getMetaManager();
 ICachedPage filterPage = null;
 int componentFilterPageId = treeMetaManager.getFilterPageId();
 boolean appendOnly = false;
 int fileId = treeIndex.getFileId();
-if(componentFilterPageId == 
LinkedMetaDataPageManager.NO_FILTER_IN_PLACE){//in-place mode, no filter page 
yet
+if (componentFilterPageId == 
LinkedMetaDataPageManager.NO_FILTER_IN_PLACE) { //in-place mode, no filter page 
yet
 ITreeIndexMetaDataFrame metadataFrame = 
treeIndex.getMetaManager().getMetaDataFrameFactory().createFrame();
 int metaPageId 

[jira] [Updated] (ASTERIXDB-1665) Open indexes on non-int numbers aren't properly ENFORCED

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1665:

Assignee: Steven Jacobs  (was: Till)

> Open indexes on non-int numbers aren't properly ENFORCED
> 
>
> Key: ASTERIXDB-1665
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1665
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Optimizer, Other
> Environment: AsterixDB master and Mac OSX
>Reporter: Michael J. Carey
>Assignee: Steven Jacobs
>
> Suppose you have a beers dataset containing the following untyped JSON beer 
> records.  (Note that beers.abv is numeric but non-integer data.)
> {noformat}
> { "name": "Black Sand Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "", "style": "Porter", "category": "Irish Ale" }
> { "name": "Fire Rock Pale Ale", "abv": 5.8, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "", "style": "American-Style Pale Ale", "category": 
> "North American Ale" }
> { "name": "Lilikoi Wheat Ale", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "", "style": "Light American Wheat Ale or Lager", 
> "category": "Other Style" }
> { "name": "Longboard Lager", "abv": 5.5, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "", "style": "American-Style Lager", "category": 
> "North American Lager" }
> { "name": "Pipeline Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "Pipeline Porter is smooth and dark with a 
> distinctive roasty aroma and earthy complexity from its diverse blends of 
> premium malted barley. This celebration of malt unites with freshly roasted 
> 100% Kona coffee grown at Cornwell Estate on Hawaii’s Big Island, lending a 
> unique roasted aroma and flavor. A delicate blend of hops rounds out this 
> palate-pleasing brew.", "style": "Porter", "category": "Irish Ale" }
> { "name": "Stout", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, "type": 
> "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
> "description": "", "style": "American-Style Stout", "category": "North 
> American Ale" }
> { "name": "Wailua", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, "type": 
> "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
> "description": "Wailua is Hawaiian for two fresh water streams mingling. This 
> was just the inspiration we needed for our Limited Release wheat ale brewed 
> with tropical passion Fruit. A refreshing citrusy, sun-colored ale with the 
> cool taste of Hawaii.", "style": "Light American Wheat Ale or Lager", 
> "category": "Other Style" }
> {noformat}
> Suppose you now try to index beers.abv as follows:
> {noformat}
> CREATE INDEX beer_abv_index ON beers (abv: int?) ENFORCED;
> {noformat}
> This will succeed - but I believe it should NOT since you can't properly 
> index non-integer data with an integer index.  (Right?)
> Note that if you say:
> {noformat}
> CREATE INDEX  beer_abv_index ON beers (abv: string?) ENFORCED;
> {noformat}
> You properly get yelled at:
> {noformat}
> ASX: Field type DOUBLE can't be promoted to type STRING 
> [HyracksDataException]
> {noformat}
> I would have expected a similar response with INT in place of STRING...?
> Assigning to Till for an initial sanity check and then reassignment to 
> someone to fix it (Steven probably, since this was UCR work :-)).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1665) Open indexes on non-int numbers aren't properly ENFORCED

[Till (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534614#comment-15534614
 ] 

Till commented on ASTERIXDB-1665:
-

I would agree. If we supported indexes on expressions, we could interpret 
int-index to use a (modifying) cast expression for indexing. 
But for now this doesn't seem right.

> Open indexes on non-int numbers aren't properly ENFORCED
> 
>
> Key: ASTERIXDB-1665
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1665
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Optimizer, Other
> Environment: AsterixDB master and Mac OSX
>Reporter: Michael J. Carey
>Assignee: Till
>
> Suppose you have a beers dataset containing the following untyped JSON beer 
> records.  (Note that beers.abv is numeric but non-integer data.)
> {noformat}
> { "name": "Black Sand Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "", "style": "Porter", "category": "Irish Ale" }
> { "name": "Fire Rock Pale Ale", "abv": 5.8, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "", "style": "American-Style Pale Ale", "category": 
> "North American Ale" }
> { "name": "Lilikoi Wheat Ale", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "", "style": "Light American Wheat Ale or Lager", 
> "category": "Other Style" }
> { "name": "Longboard Lager", "abv": 5.5, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "", "style": "American-Style Lager", "category": 
> "North American Lager" }
> { "name": "Pipeline Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
> "type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 
> 20:00:20", "description": "Pipeline Porter is smooth and dark with a 
> distinctive roasty aroma and earthy complexity from its diverse blends of 
> premium malted barley. This celebration of malt unites with freshly roasted 
> 100% Kona coffee grown at Cornwell Estate on Hawaii’s Big Island, lending a 
> unique roasted aroma and flavor. A delicate blend of hops rounds out this 
> palate-pleasing brew.", "style": "Porter", "category": "Irish Ale" }
> { "name": "Stout", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, "type": 
> "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
> "description": "", "style": "American-Style Stout", "category": "North 
> American Ale" }
> { "name": "Wailua", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, "type": 
> "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
> "description": "Wailua is Hawaiian for two fresh water streams mingling. This 
> was just the inspiration we needed for our Limited Release wheat ale brewed 
> with tropical passion Fruit. A refreshing citrusy, sun-colored ale with the 
> cool taste of Hawaii.", "style": "Light American Wheat Ale or Lager", 
> "category": "Other Style" }
> {noformat}
> Suppose you now try to index beers.abv as follows:
> {noformat}
> CREATE INDEX beer_abv_index ON beers (abv: int?) ENFORCED;
> {noformat}
> This will succeed - but I believe it should NOT since you can't properly 
> index non-integer data with an integer index.  (Right?)
> Note that if you say:
> {noformat}
> CREATE INDEX  beer_abv_index ON beers (abv: string?) ENFORCED;
> {noformat}
> You properly get yelled at:
> {noformat}
> ASX: Field type DOUBLE can't be promoted to type STRING 
> [HyracksDataException]
> {noformat}
> I would have expected a similar response with INT in place of STRING...?
> Assigning to Till for an initial sanity check and then reassignment to 
> someone to fix it (Steven probably, since this was UCR work :-)).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1665) Open indexes on non-int numbers aren't properly ENFORCED

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1665:

Description: 
Suppose you have a beers dataset containing the following untyped JSON beer 
records.  (Note that beers.abv is numeric but non-integer data.)
{noformat}
{ "name": "Black Sand Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "Porter", "category": "Irish Ale" }
{ "name": "Fire Rock Pale Ale", "abv": 5.8, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "American-Style Pale Ale", "category": "North 
American Ale" }
{ "name": "Lilikoi Wheat Ale", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "Light American Wheat Ale or Lager", "category": 
"Other Style" }
{ "name": "Longboard Lager", "abv": 5.5, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "American-Style Lager", "category": "North American 
Lager" }
{ "name": "Pipeline Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "Pipeline Porter is smooth and dark with a distinctive roasty 
aroma and earthy complexity from its diverse blends of premium malted barley. 
This celebration of malt unites with freshly roasted 100% Kona coffee grown at 
Cornwell Estate on Hawaii’s Big Island, lending a unique roasted aroma and 
flavor. A delicate blend of hops rounds out this palate-pleasing brew.", 
"style": "Porter", "category": "Irish Ale" }
{ "name": "Stout", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, "type": 
"beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "American-Style Stout", "category": "North American 
Ale" }
{ "name": "Wailua", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, "type": 
"beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "Wailua is Hawaiian for two fresh water streams mingling. This 
was just the inspiration we needed for our Limited Release wheat ale brewed 
with tropical passion Fruit. A refreshing citrusy, sun-colored ale with the 
cool taste of Hawaii.", "style": "Light American Wheat Ale or Lager", 
"category": "Other Style" }
{noformat}
Suppose you now try to index beers.abv as follows:
{noformat}
CREATE INDEX beer_abv_index ON beers (abv: int?) ENFORCED;
{noformat}

This will succeed - but I believe it should NOT since you can't properly index 
non-integer data with an integer index.  (Right?)

Note that if you say:
{noformat}
CREATE INDEX  beer_abv_index ON beers (abv: string?) ENFORCED;
{noformat}

You properly get yelled at:
{noformat}
ASX: Field type DOUBLE can't be promoted to type STRING 
[HyracksDataException]
{noformat}

I would have expected a similar response with INT in place of STRING...?

Assigning to Till for an initial sanity check and then reassignment to someone 
to fix it (Steven probably, since this was UCR work :-)).

  was:
Suppose you have a beers dataset containing the following untyped JSON beer 
records.  (Note that beers.abv is numeric but non-integer data.)

{ "name": "Black Sand Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "Porter", "category": "Irish Ale" }
{ "name": "Fire Rock Pale Ale", "abv": 5.8, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "American-Style Pale Ale", "category": "North 
American Ale" }
{ "name": "Lilikoi Wheat Ale", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "Light American Wheat Ale or Lager", "category": 
"Other Style" }
{ "name": "Longboard Lager", "abv": 5.5, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "American-Style Lager", "category": "North American 
Lager" }
{ "name": "Pipeline Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "Pipeline Porter is smooth and dark with a distinctive roasty 
aroma and earthy complexity from its diverse blends of premium malted barley. 
This celebration of malt unites with freshly roasted 100% Kona coffee grown at 
Cornwell Estate on Hawaii’s Big Island, lending a unique roasted aroma and 
flavor. A delicate blend of hops 

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/785/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1205/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java:

Line 122: false);
> So, this is a current bug?
Yeah, I think it was masked by the other issues in this patch and from others 
however.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 6: Code-Review+2

LGTM

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1205/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java:

Line 122: false);
> The last argument is whether or not this is a new page, and this one isn't.
So, this is a current bug?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2836/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Ian Maxon (Code Review)]

Hello Jianfeng Jia, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1205

to look at the new patch set (#6).

Change subject: Fixes for ASTERIXDB-1636
..

Fixes for ASTERIXDB-1636

The index of the tuple field for filters from SecondaryIndexOperationsHelper 
and AqlMetadataProvider
differed. The one in AqlMetadataProvider was wrong, as it was attempting to 
take into account the
presence of a partitioning field in the incoming tuple, which is not there in 
the case of an
insert/upsert.

There was also an issue where on merge, for components with a filter page but 
no min/max, the merge
would fail. I fixed this by skipping over null entries while getting the 
min/max of merging components.

Finally, there was a very silly error in LSMComponentFilterManager which was 
causing the filter page
to appear as blank, because the page was being pinned with the wrong argument. 
That is also fixed.

Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
---
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
3 files changed, 22 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/05/1205/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1205/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java:

Line 122: false);
> The reason of changing true -> false?
The last argument is whether or not this is a new page, and this one isn't. If 
you set it to 'true' it will blank the page.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: Yes

[jira] [Created] (ASTERIXDB-1665) Open indexes on non-int numbers aren't properly ENFORCED

[Michael J. Carey (JIRA)]

Michael J. Carey created ASTERIXDB-1665:
---

 Summary: Open indexes on non-int numbers aren't properly ENFORCED
 Key: ASTERIXDB-1665
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1665
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: AsterixDB, Optimizer, Other
 Environment: AsterixDB master and Mac OSX
Reporter: Michael J. Carey
Assignee: Till


Suppose you have a beers dataset containing the following untyped JSON beer 
records.  (Note that beers.abv is numeric but non-integer data.)

{ "name": "Black Sand Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "Porter", "category": "Irish Ale" }
{ "name": "Fire Rock Pale Ale", "abv": 5.8, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "American-Style Pale Ale", "category": "North 
American Ale" }
{ "name": "Lilikoi Wheat Ale", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "Light American Wheat Ale or Lager", "category": 
"Other Style" }
{ "name": "Longboard Lager", "abv": 5.5, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "American-Style Lager", "category": "North American 
Lager" }
{ "name": "Pipeline Porter", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, 
"type": "beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "Pipeline Porter is smooth and dark with a distinctive roasty 
aroma and earthy complexity from its diverse blends of premium malted barley. 
This celebration of malt unites with freshly roasted 100% Kona coffee grown at 
Cornwell Estate on Hawaii’s Big Island, lending a unique roasted aroma and 
flavor. A delicate blend of hops rounds out this palate-pleasing brew.", 
"style": "Porter", "category": "Irish Ale" }
{ "name": "Stout", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, "type": 
"beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "", "style": "American-Style Stout", "category": "North American 
Ale" }
{ "name": "Wailua", "abv": 0.0, "ibu": 0.0, "srm": 0.0, "upc": 0, "type": 
"beer", "brewery_id": "kona_brewing", "updated": "2010-07-22 20:00:20", 
"description": "Wailua is Hawaiian for two fresh water streams mingling. This 
was just the inspiration we needed for our Limited Release wheat ale brewed 
with tropical passion Fruit. A refreshing citrusy, sun-colored ale with the 
cool taste of Hawaii.", "style": "Light American Wheat Ale or Lager", 
"category": "Other Style" }

Suppose you now try to index beers.abv as follows:
CREATE INDEX beer_abv_index ON beers (abv: int?) ENFORCED;

This will succeed - but I believe it should NOT since you can't properly index 
non-integer data with an integer index.  (Right?)

Note that if you say:
CREATE INDEX  beer_abv_index ON beers (abv: string?) ENFORCED;

You properly get yelled at:
ASX: Field type DOUBLE can't be promoted to type STRING 
[HyracksDataException]

I would have expected a similar response with INT in place of STRING...?

Assigning to Till for an initial sanity check and then reassignment to someone 
to fix it (Steven probably, since this was UCR work :-)).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1205/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java:

Line 655: }
> Yeah. If you do a flush of a component that is empty but still has a filter
Got it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1205/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java:

Line 655: }
> Do we have this case? I mean, LSMComponentFilter is not null and min or max
Yeah. If you do a flush of a component that is empty but still has a filter on 
it. In any case it shouldn't cause the merge to fail completely.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: ASTERIXDB-1611: Improve Thread Names
..


ASTERIXDB-1611: Improve Thread Names

Executor threads are now named as follows:

- "Executor-:"

Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1226
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/application/ApplicationContext.java
A 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/HyracksThreadFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/application/NCApplicationContext.java
7 files changed, 57 insertions(+), 25 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index f6dfe4a..9120aa5 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -95,7 +95,7 @@
 LOGGER.info("Starting Asterix cluster controller");
 }
 
-appCtx.setThreadFactory(new AsterixThreadFactory(new 
LifeCycleComponentManager()));
+appCtx.setThreadFactory(new 
AsterixThreadFactory(appCtx.getThreadFactory(), new 
LifeCycleComponentManager()));
 GlobalRecoveryManager.instantiate((HyracksConnection) 
getNewHyracksClientConnection());
 ILibraryManager libraryManager = new ExternalLibraryManager();
 AsterixResourceIdManager resourceIdManager = new 
AsterixResourceIdManager();
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
index c678bf3..f26afa8 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
@@ -95,7 +95,8 @@
 throw e;
 }
 
-ncAppCtx.setThreadFactory(new 
AsterixThreadFactory(ncAppCtx.getLifeCycleComponentManager()));
+ncAppCtx.setThreadFactory(new 
AsterixThreadFactory(ncAppCtx.getThreadFactory(),
+ncAppCtx.getLifeCycleComponentManager()));
 ncApplicationContext = ncAppCtx;
 nodeId = ncApplicationContext.getNodeId();
 if (LOGGER.isLoggable(Level.INFO)) {
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
index 6b4bf72..e215d6a 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
@@ -24,22 +24,19 @@
 
 public class AsterixThreadFactory implements ThreadFactory {
 
+private final ThreadFactory delegate;
 private final ILifeCycleComponentManager lccm;
 
-public AsterixThreadFactory(ILifeCycleComponentManager 
lifeCycleComponentManager) {
+public AsterixThreadFactory(ThreadFactory delegate, 
ILifeCycleComponentManager lifeCycleComponentManager) {
+this.delegate = delegate;
 this.lccm = lifeCycleComponentManager;
 }
 
 @Override
-public Thread newThread(Runnable r) {
-Thread t;
-if ((r instanceof Thread)) {
-t = (Thread) r;
-} else {
-t = new Thread(r);
-}
-t.setUncaughtExceptionHandler(lccm);
-return t;
+public Thread newThread(Runnable runnable) {
+Thread thread = delegate.newThread(runnable);
+

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1611: Improve Thread Names
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1226
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/784/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/8/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 15: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/783/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/7/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/6/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Index-only plan step 2: Added SplitOperator
..


Patch Set 10:

Got it.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1196
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator

[Jianfeng Jia (Code Review)]

Jianfeng Jia has posted comments on this change.

Change subject: Index-only plan step 2: Added SplitOperator
..


Patch Set 10:

Like this kind of test? 
:https://github.com/apache/asterixdb/blob/bce00de839d844e41de2958e1494a63efdde/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/unit/IntersectOperatorDescriptorTest.java

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1196
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Index-only plan step 2: Added SplitOperator
..


Patch Set 10:

PS: For your second comment, SplitOperatorDescriptor resides in Algebricks. So 
if we want to create one test, it should reside there.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1196
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Index-only plan step 2: Added SplitOperator
..


Patch Set 10:

(6 comments)

@Jianfeng: thanks for the comments. Regarding your first comments, I think we 
may need to check 
https://github.com/apache/asterixdb/commit/f6596f23ce61eb3b430ba6d9a33c6265ec4b39c4
 patch first.

https://asterix-gerrit.ics.uci.edu/#/c/1196/10/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SplitOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SplitOperator.java:

Line 32: private Mutable branchingExpression;
> Can this one be Immutable? we should not change the expression.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1196/10/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/SplitOperatorDescriptor.java
File 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/SplitOperatorDescriptor.java:

Line 73: builder.addTargetEdge(i, sma, pipelineOutputIndex++);
> isn't this `pipelineOutputIndex` == `i`?
Done


Line 91: private final boolean[] isOpen = new 
boolean[numberOfNonMaterializedOutputs];
> where does this `numberOfNonMaterializedOutputs` come from?
Initialized in the super class - AbstractReplicateOperatorDescriptor. For this 
split operator, the number of output is the same as 
numberOfNonMaterializedOutputs.


Line 111: builders = new 
ArrayTupleBuilder[numberOfNonMaterializedOutputs];
> this builder seems not be used
Done


Line 112: builderDatas = new 
GrowableArray[numberOfNonMaterializedOutputs];
> ditto
Done


https://asterix-gerrit.ics.uci.edu/#/c/1196/10/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/base/AbstractReplicateOperatorDescriptor.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/base/AbstractReplicateOperatorDescriptor.java:

Line 70: for (boolean flag : outputMaterializationFlags) {
> I'm confused by the original code. Based on the outputMaterializationFlags 
This was introduced by 
https://github.com/apache/asterixdb/commit/f6596f23ce61eb3b430ba6d9a33c6265ec4b39c4.
 So, you may check there. Frankly, I'm not understanding the code 100% for this 
part.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1196
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/5/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/4/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/784/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/3/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/2/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 15:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/783/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/1/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Steven Jacobs has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1227

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M 
src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
M src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
M src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
5 files changed, 40 insertions(+), 20 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad 
refs/changes/27/1227/1

diff --git 
a/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
 
b/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
index 7d0cb1a..21a3ef0 100644
--- 
a/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
+++ 
b/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
@@ -29,16 +29,22 @@
 import org.apache.asterix.bad.metadata.Channel;
 import org.apache.asterix.common.exceptions.AsterixException;
 import org.apache.asterix.common.functions.FunctionSignature;
+import org.apache.asterix.lang.aql.expression.FLWOGRExpression;
+import org.apache.asterix.lang.common.base.Clause;
 import org.apache.asterix.lang.common.base.Expression;
+import org.apache.asterix.lang.common.clause.LetClause;
 import org.apache.asterix.lang.common.expression.CallExpr;
+import org.apache.asterix.lang.common.expression.FieldAccessor;
 import org.apache.asterix.lang.common.expression.FieldBinding;
 import org.apache.asterix.lang.common.expression.LiteralExpr;
 import org.apache.asterix.lang.common.expression.RecordConstructor;
+import org.apache.asterix.lang.common.expression.VariableExpr;
 import org.apache.asterix.lang.common.literal.StringLiteral;
 import org.apache.asterix.lang.common.statement.InsertStatement;
 import org.apache.asterix.lang.common.statement.Query;
 import org.apache.asterix.lang.common.statement.UpsertStatement;
 import org.apache.asterix.lang.common.struct.Identifier;
+import org.apache.asterix.lang.common.struct.VarIdentifier;
 import org.apache.asterix.lang.common.visitor.base.ILangVisitor;
 import org.apache.asterix.metadata.MetadataManager;
 import org.apache.asterix.metadata.MetadataTransactionContext;
@@ -182,18 +188,32 @@
 subscriptionTuple.setVarCounter(varCounter);
 
 if (subscriptionId == null) {
-List returnField = new ArrayList<>();
-returnField.add(BADConstants.SubscriptionId);
+
+VariableExpr subscriptionVar = new VariableExpr(new 
VarIdentifier("$sub", 1));
+VariableExpr useSubscriptionVar = new VariableExpr(new 
VarIdentifier("$sub", 1));
+VariableExpr resultVar = new VariableExpr(new 
VarIdentifier("$result", 0));
+VariableExpr useResultVar = new VariableExpr(new 
VarIdentifier("$result", 0));
+useResultVar.setIsNewVar(false);
+useSubscriptionVar.setIsNewVar(false);
+Query returnQuery = new Query(false);
+List clauseList = new ArrayList<>();
+LetClause let = new LetClause(subscriptionVar,
+new FieldAccessor(useResultVar, new 
Identifier(BADConstants.SubscriptionId)));
+clauseList.add(let);
+FLWOGRExpression body = new FLWOGRExpression(clauseList, 
useSubscriptionVar);
+returnQuery.setBody(body);
+
 metadataProvider.setResultSetId(new 
ResultSetId(resultSetIdCounter++));
 metadataProvider.setResultAsyncMode(
 resultDelivery == ResultDelivery.ASYNC || 
resultDelivery == ResultDelivery.ASYNC_DEFERRED);
 InsertStatement insert = new InsertStatement(new 
Identifier(dataverse),
-new Identifier(subscriptionsDatasetName), 
subscriptionTuple, varCounter, false, returnField);
+new Identifier(subscriptionsDatasetName), 
subscriptionTuple, varCounter, resultVar,
+returnQuery);
 ((QueryTranslator) 
statementExecutor).handleInsertUpsertStatement(metadataProvider, insert, hcc, 
hdc,
 resultDelivery, stats, false);
 } else {
 UpsertStatement upsert = new UpsertStatement(new 
Identifier(dataverse),
-new Identifier(subscriptionsDatasetName), 
subscriptionTuple, varCounter);
+new Identifier(subscriptionsDatasetName), 
subscriptionTuple, varCounter, null, null);
 ((QueryTranslator) 

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1611: Improve Thread Names
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/782/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1226
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1205/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java:

Line 122: false);
The reason of changing true -> false?


https://asterix-gerrit.ics.uci.edu/#/c/1205/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java:

Line 655: }
Do we have this case? I mean, LSMComponentFilter is not null and min or max is 
null?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixes for ASTERIXDB-1636
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2835/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixes for ASTERIXDB-1636

[Ian Maxon (Code Review)]

Hello Jianfeng Jia, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1205

to look at the new patch set (#5).

Change subject: Fixes for ASTERIXDB-1636
..

Fixes for ASTERIXDB-1636

The index of the tuple field for filters from SecondaryIndexOperationsHelper 
and AqlMetadataProvider
differed. The one in AqlMetadataProvider was wrong, as it was attempting to 
take into account the
presence of a partitioning field in the incoming tuple, which is not there in 
the case of an
insert/upsert.

There was also an issue where on merge, for components with a filter page but 
no min/max, the merge
would fail. I fixed this by skipping over null entries while getting the 
min/max of merging components.

Finally, there was a very silly error in LSMComponentFilterManager which was 
causing the filter page
to appear as blank, because the page was being pinned with the wrong argument. 
That is also fixed.

Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
---
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
3 files changed, 22 insertions(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/05/1205/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1205
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 

Change in asterixdb[master]: Enhanced Insert AQL

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 15:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Refactor QueryTranslator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor QueryTranslator
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/781/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1215
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732b063be8b733af504cbefc9844721953c30621
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2834/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[Steven Jacobs (Code Review)]

Hello Michael Carey, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1150

to look at the new patch set (#15).

Change subject: Enhanced Insert AQL
..

Enhanced Insert AQL

The optional "as Variable" provides a variable binding for the inserted records
The optional "returning Query" allows users to run simple
queries/functions on the records returned by the insert, and can refer
to the variable bound in "as Variable"

Allow commits to be non-sink operators (contnue job pipeline after commit)

Additionally, this change makes small modifications to
the extension code to prepare for the BAD extension

Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
---
M asterixdb/asterix-active/pom.xml
M 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/CommitOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntimeFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/UpsertCommitRuntime.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceRapidFrameFlushProjectAssignRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java
R 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/insert-return-custom-result.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/insert-return-custom-result.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/dml/insert-return-records/insert-return-records.1.adm
A 

Change in asterixdb[master]: Refactor QueryTranslator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor QueryTranslator
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/781/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1215
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732b063be8b733af504cbefc9844721953c30621
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1611: Improve Thread Names
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1226
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1611: Improve Thread Names
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2833/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1226
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1226

to look at the new patch set (#2).

Change subject: ASTERIXDB-1611: Improve Thread Names
..

ASTERIXDB-1611: Improve Thread Names

Executor threads are now named as follows:

- "Executor-:"

Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/application/ApplicationContext.java
A 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/HyracksThreadFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/application/NCApplicationContext.java
7 files changed, 57 insertions(+), 25 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/26/1226/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1226
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1611: Improve Thread Names
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1226
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1611: Improve Thread Names
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2832/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1226
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1611: Improve Thread Names

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1226

Change subject: ASTERIXDB-1611: Improve Thread Names
..

ASTERIXDB-1611: Improve Thread Names

Executor threads are now named as follows:

- "Executor-:"

Change-Id: Iea54740c51a9ac9388337cf88260a8482ff4a334
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/application/ApplicationContext.java
A 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/HyracksThreadFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/application/NCApplicationContext.java
7 files changed, 57 insertions(+), 25 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/26/1226/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index f6dfe4a..9120aa5 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -95,7 +95,7 @@
 LOGGER.info("Starting Asterix cluster controller");
 }
 
-appCtx.setThreadFactory(new AsterixThreadFactory(new 
LifeCycleComponentManager()));
+appCtx.setThreadFactory(new 
AsterixThreadFactory(appCtx.getThreadFactory(), new 
LifeCycleComponentManager()));
 GlobalRecoveryManager.instantiate((HyracksConnection) 
getNewHyracksClientConnection());
 ILibraryManager libraryManager = new ExternalLibraryManager();
 AsterixResourceIdManager resourceIdManager = new 
AsterixResourceIdManager();
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
index c678bf3..f26afa8 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
@@ -95,7 +95,8 @@
 throw e;
 }
 
-ncAppCtx.setThreadFactory(new 
AsterixThreadFactory(ncAppCtx.getLifeCycleComponentManager()));
+ncAppCtx.setThreadFactory(new 
AsterixThreadFactory(ncAppCtx.getThreadFactory(),
+ncAppCtx.getLifeCycleComponentManager()));
 ncApplicationContext = ncAppCtx;
 nodeId = ncApplicationContext.getNodeId();
 if (LOGGER.isLoggable(Level.INFO)) {
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
index 6b4bf72..e215d6a 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadFactory.java
@@ -24,22 +24,19 @@
 
 public class AsterixThreadFactory implements ThreadFactory {
 
+private final ThreadFactory delegate;
 private final ILifeCycleComponentManager lccm;
 
-public AsterixThreadFactory(ILifeCycleComponentManager 
lifeCycleComponentManager) {
+public AsterixThreadFactory(ThreadFactory delegate, 
ILifeCycleComponentManager lifeCycleComponentManager) {
+this.delegate = delegate;
 this.lccm = lifeCycleComponentManager;
 }
 
 @Override
-public Thread newThread(Runnable r) {
-Thread t;
-if ((r instanceof Thread)) {
-t = (Thread) r;
-} else {
-t = new Thread(r);
-}
-t.setUncaughtExceptionHandler(lccm);
-return t;
+public Thread newThread(Runnable runnable) {
+Thread thread = delegate.newThread(runnable);
+thread.setUncaughtExceptionHandler(lccm);
+return thread;
 }
 
 }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java
 

Change in asterixdb[master]: Refactor QueryTranslator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor QueryTranslator
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2831/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1215
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732b063be8b733af504cbefc9844721953c30621
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Refactor QueryTranslator

[Murtadha Hubail (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1215

to look at the new patch set (#3).

Change subject: Refactor QueryTranslator
..

Refactor QueryTranslator

This change moves the implementation of each statement to the statement itself
instead of having all implementations in the QueryTranslator. Some statements
were not refactored in this change due to projects dependency issues or they
need special handling in the QueryTranslator itself.

Change-Id: I732b063be8b733af504cbefc9844721953c30621
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultReader.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/RunStatementTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
R asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/Job.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/AsterixRuntimeComponentsProvider.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/AsterixAppContextInfo.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JobSpecificationUtils.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JobUtils.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/HDFSUtils.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
R 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/CompiledStatements.java
R 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/ExternalIndexingOperations.java
R 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/IStatementExecutor.java
R 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/IndexOperations.java
R 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/SecondaryBTreeOperationsHelper.java
R 

Change in asterixdb[master]: improve error messages

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: improve error messages
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2830/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1225
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia82cd34ae5099f924302d7d42b541247a258c9b9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: improve error messages

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1225

Change subject: improve error messages
..

improve error messages

Change-Id: Ia82cd34ae5099f924302d7d42b541247a258c9b9
---
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
2 files changed, 16 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/25/1225/1

diff --git 
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
 
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
index 94866eb..2bc78a1 100644
--- 
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
+++ 
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
@@ -116,7 +116,7 @@
 messageBuilder.append("function " + 
functionDecls.get(functionDecls.size() - 1).getSignature()
 + " depends upon function " + signature + " which 
is undefined");
 } else {
-messageBuilder.append("function " + signature + " is 
undefined ");
+messageBuilder.append("function " + signature + " is not 
defined");
 }
 throw new AsterixException(messageBuilder.toString());
 }
diff --git a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj 
b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
index 697439d..f330f40 100644
--- a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
+++ b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
@@ -2187,15 +2187,27 @@
 }
   | 
 {
-  lit.setValue(new LongIntegerLiteral(new Long(token.image)));
+try {
+lit.setValue(new LongIntegerLiteral(Long.valueOf(token.image)));
+} catch (NumberFormatException e) {
+throw new ParseException("Could not parse numeric literal \"" + 
token.image +'"');
+}
 }
   | 
 {
-  lit.setValue(new FloatLiteral(new Float(token.image)));
+try {
+lit.setValue(new FloatLiteral(Float.valueOf(token.image)));
+} catch (NumberFormatException e) {
+throw new ParseException("Could not parse numeric literal \"" + 
token.image +'"');
+}
 }
   | 
 {
-  lit.setValue(new DoubleLiteral(new Double(token.image)));
+try {
+lit.setValue(new DoubleLiteral(Double.valueOf(token.image)));
+} catch (NumberFormatException e) {
+throw new ParseException("Could not parse numeric literal \"" + 
token.image +'"');
+}
 }
   | 
 {

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1225
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia82cd34ae5099f924302d7d42b541247a258c9b9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 

Change in asterixdb[master]: Misc Cleanup / Spelling Fixes

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: Misc Cleanup / Spelling Fixes
..


Misc Cleanup / Spelling Fixes

Change-Id: Ide31f439561b5ddd04881328fe7863176aeb287d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1222
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
Integration-Tests: Jenkins 
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java
index 4eb3ebf..019ac41 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java
@@ -43,7 +43,7 @@
 
 public void sendApplicationMessageToCC(Serializable message, DeploymentId 
deploymentId) throws Exception;
 
-public void sendApplicationMessageToCC(byte[] message, DeploymentId 
deploymendId) throws Exception;
+public void sendApplicationMessageToCC(byte[] message, DeploymentId 
deploymentId) throws Exception;
 
 public void setSharedObject(Object object);
 
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
index ecc37e8..e589ece 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
@@ -53,7 +53,7 @@
 if (ctx.getMessageBroker() != null) {
 ctx.getMessageBroker().receivedMessage(data, nodeId);
 } else {
-LOGGER.log(Level.WARNING, "Messsage was sent, but no Message 
Broker set!");
+LOGGER.log(Level.WARNING, "Message was sent, but no Message 
Broker set!");
 }
 } catch (Exception e) {
 Logger.getLogger(this.getClass().getName()).log(Level.WARNING, 
"Error in application message delivery!", e);
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
index b585199..98f2097 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
@@ -133,7 +133,7 @@
 createInputChannels(td, inputs));
 IOperatorNodePushable operator = han.createPushRuntime(task, 
rdp, partition, td.getPartitionCount());
 
-List collectors = new 
ArrayList();
+List collectors = new ArrayList<>();
 
 if (inputs != null) {
 for (int i = 0; i < inputs.size(); ++i) {

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1222
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide31f439561b5ddd04881328fe7863176aeb287d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: move SessionConfig to translator

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: move SessionConfig to translator
..


move SessionConfig to translator

Change-Id: I06d85aa361bb5d50f885311aad2545514d8a94b7
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1224
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
R 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/QueryTranslatorTest.java
14 files changed, 24 insertions(+), 26 deletions(-)

Approvals:
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
index 9addc87..05fde09 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
@@ -20,7 +20,6 @@
 
 import java.util.List;
 
-import org.apache.asterix.common.app.SessionConfig;
 import org.apache.asterix.compiler.provider.ILangCompilationProvider;
 import org.apache.asterix.lang.common.base.Statement;
 
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/app/SessionConfig.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
similarity index 99%
rename from 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/app/SessionConfig.java
rename to 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
index f4e3be2..fc4f655 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/app/SessionConfig.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.asterix.common.app;
+package org.apache.asterix.translator;
 
 import java.io.PrintWriter;
 import java.util.HashMap;
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index 9c0f66c..eb1764c 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -29,7 +29,6 @@
 import org.apache.asterix.api.common.Job.SubmissionMode;
 import org.apache.asterix.app.cc.CompilerExtensionManager;
 import org.apache.asterix.app.result.ResultUtil;
-import org.apache.asterix.common.app.SessionConfig;
 import org.apache.asterix.common.config.AsterixCompilerProperties;
 import org.apache.asterix.common.config.AsterixExternalProperties;
 import org.apache.asterix.common.config.OptimizationConfUtil;
@@ -57,6 +56,7 @@
 import 
org.apache.asterix.transaction.management.service.transaction.JobIdFactory;
 import org.apache.asterix.translator.CompiledStatements.ICompiledDmlStatement;
 import org.apache.asterix.translator.IStatementExecutor.Stats;
+import org.apache.asterix.translator.SessionConfig;
 import 
org.apache.hyracks.algebricks.common.constraints.AlgebricksPartitionConstraint;
 import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
 import org.apache.hyracks.algebricks.common.utils.Pair;
diff --git 

Change in asterixdb[master]: Misc Cleanup / Spelling Fixes

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Misc Cleanup / Spelling Fixes
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/780/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1222
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide31f439561b5ddd04881328fe7863176aeb287d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: move SessionConfig to translator

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: move SessionConfig to translator
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1224
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06d85aa361bb5d50f885311aad2545514d8a94b7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Run Active Shutdown On Separate Thread

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: Run Active Shutdown On Separate Thread
..


Run Active Shutdown On Separate Thread

- As feed shutdown can be slow, do it on another thread to not tie up
  worker.
- use nc thread executor for feed adapter thread
- error handling

Change-Id: I8fd9bc454b290420682160364ac78e4b91a9abc3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1223
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
M 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterRuntimeManager.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java
5 files changed, 37 insertions(+), 40 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
 
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
index bd6dae9..b15cfca 100644
--- 
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
+++ 
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
@@ -20,6 +20,7 @@
 
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executor;
 
 import org.apache.asterix.active.message.ActiveManagerMessage;
 import org.apache.asterix.common.memory.ConcurrentFramePool;
@@ -29,11 +30,14 @@
 public class ActiveManager {
 
 private static final Logger LOGGER = 
Logger.getLogger(ActiveManager.class.getName());
+private final Executor executor;
 private final Map runtimes;
 private final ConcurrentFramePool activeFramePool;
 private final String nodeId;
 
-public ActiveManager(String nodeId, long activeMemoryBudget, int 
frameSize) throws HyracksDataException {
+public ActiveManager(Executor executor, String nodeId, long 
activeMemoryBudget, int frameSize)
+throws HyracksDataException {
+this.executor = executor;
 this.nodeId = nodeId;
 this.activeFramePool = new ConcurrentFramePool(nodeId, 
activeMemoryBudget, frameSize);
 this.runtimes = new ConcurrentHashMap<>();
@@ -69,7 +73,7 @@
 stopRuntime(message);
 break;
 default:
-LOGGER.warn("Unknown message type received");
+LOGGER.warn("Unknown message type received: " + 
message.getKind());
 }
 }
 
@@ -79,12 +83,14 @@
 if (runtime == null) {
 LOGGER.warn("Request to stop a runtime that is not registered " + 
runtimeId);
 } else {
-try {
-runtime.stop();
-} catch (HyracksDataException | InterruptedException e) {
-// TODO(till) Figure out a better way to handle failure to 
stop a runtime
-LOGGER.warn("Failed to stop runtime: " + runtimeId, e);
-}
+executor.execute(() -> {
+try {
+runtime.stop();
+} catch (Exception e) {
+// TODO(till) Figure out a better way to handle failure to 
stop a runtime
+LOGGER.warn("Failed to stop runtime: " + runtimeId, e);
+}
+});
 }
 }
 }
diff --git 
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
 
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
index 1cda298..7f25896 100644
--- 
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
+++ 
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
@@ -55,15 +55,10 @@
 
 @Override
 public final void stop() throws HyracksDataException, InterruptedException 
{
-try {
-abort();
-} finally {
-if (!done) {
-synchronized (this) {
-while (!done) {
-wait();
-}
-}
+abort();
+synchronized (this) {
+while (!done) {
+wait();
 }
 }
 }
diff --git 

Change in asterixdb[master]: Misc Cleanup / Spelling Fixes

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Misc Cleanup / Spelling Fixes
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/780/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1222
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide31f439561b5ddd04881328fe7863176aeb287d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Misc Cleanup / Spelling Fixes

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Misc Cleanup / Spelling Fixes
..


Patch Set 1:

TRIGGER asterix-gerrit-integration-tests

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1222
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide31f439561b5ddd04881328fe7863176aeb287d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Revise builtin function documents.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Revise builtin function documents.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2829/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1221
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Revise builtin function documents.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1221

to look at the new patch set (#4).

Change subject: Revise builtin function documents.
..

Revise builtin function documents.

- splitted the original function document,
- shared all function documents between SQL++ and AQL,
  except the aggregation function document.

Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83
---
M asterixdb/asterix-doc/pom.xml
A asterixdb/asterix-doc/src/main/markdown/builtins/0_toc.md
A asterixdb/asterix-doc/src/main/markdown/builtins/10_comparison.md
A asterixdb/asterix-doc/src/main/markdown/builtins/11_others.md
A asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md
A asterixdb/asterix-doc/src/main/markdown/builtins/2_string.md
A asterixdb/asterix-doc/src/main/markdown/builtins/3_binary.md
A asterixdb/asterix-doc/src/main/markdown/builtins/4_spatial.md
A asterixdb/asterix-doc/src/main/markdown/builtins/5_similarity.md
A asterixdb/asterix-doc/src/main/markdown/builtins/6_tokenizing.md
A asterixdb/asterix-doc/src/main/markdown/builtins/7_allens.md
A asterixdb/asterix-doc/src/main/markdown/builtins/7_temporal.md
A asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md
A asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_aql.md
A asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/1_intro.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/4_ddl.md
D asterixdb/asterix-doc/src/site/markdown/aql/allens.md
D asterixdb/asterix-doc/src/site/markdown/aql/functions.md
M asterixdb/asterix-doc/src/site/site.xml
23 files changed, 4,251 insertions(+), 2,972 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1221/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1221
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: move SessionConfig to translator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: move SessionConfig to translator
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/779/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1224
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06d85aa361bb5d50f885311aad2545514d8a94b7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Revise builtin function documents.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Revise builtin function documents.
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/778/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1221
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: move SessionConfig to translator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: move SessionConfig to translator
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/779/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1224
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06d85aa361bb5d50f885311aad2545514d8a94b7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Revise builtin function documents.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Revise builtin function documents.
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/778/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1221
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: move SessionConfig to translator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: move SessionConfig to translator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2828/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1224
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06d85aa361bb5d50f885311aad2545514d8a94b7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: move SessionConfig to translator

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1224

Change subject: move SessionConfig to translator
..

move SessionConfig to translator

Change-Id: I06d85aa361bb5d50f885311aad2545514d8a94b7
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
R 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/QueryTranslatorTest.java
14 files changed, 24 insertions(+), 26 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/24/1224/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
index 9addc87..05fde09 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java
@@ -20,7 +20,6 @@
 
 import java.util.List;
 
-import org.apache.asterix.common.app.SessionConfig;
 import org.apache.asterix.compiler.provider.ILangCompilationProvider;
 import org.apache.asterix.lang.common.base.Statement;
 
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/app/SessionConfig.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
similarity index 99%
rename from 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/app/SessionConfig.java
rename to 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
index f4e3be2..fc4f655 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/app/SessionConfig.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.asterix.common.app;
+package org.apache.asterix.translator;
 
 import java.io.PrintWriter;
 import java.util.HashMap;
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index 9c0f66c..eb1764c 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -29,7 +29,6 @@
 import org.apache.asterix.api.common.Job.SubmissionMode;
 import org.apache.asterix.app.cc.CompilerExtensionManager;
 import org.apache.asterix.app.result.ResultUtil;
-import org.apache.asterix.common.app.SessionConfig;
 import org.apache.asterix.common.config.AsterixCompilerProperties;
 import org.apache.asterix.common.config.AsterixExternalProperties;
 import org.apache.asterix.common.config.OptimizationConfUtil;
@@ -57,6 +56,7 @@
 import 
org.apache.asterix.transaction.management.service.transaction.JobIdFactory;
 import org.apache.asterix.translator.CompiledStatements.ICompiledDmlStatement;
 import org.apache.asterix.translator.IStatementExecutor.Stats;
+import org.apache.asterix.translator.SessionConfig;
 import 
org.apache.hyracks.algebricks.common.constraints.AlgebricksPartitionConstraint;
 import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
 import org.apache.hyracks.algebricks.common.utils.Pair;
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
index b811172..f32e451 100644
--- 

Change in asterixdb[master]: Revise builtin function documents.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Revise builtin function documents.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2827/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1221
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Revise builtin function documents.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1221

to look at the new patch set (#3).

Change subject: Revise builtin function documents.
..

Revise builtin function documents.

- splitted the original function document,
- shared all function documents between SQL++ and AQL,
  except the aggregation function document.

Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83
---
M asterixdb/asterix-doc/pom.xml
A asterixdb/asterix-doc/src/main/markdown/builtins/0_toc.md
A asterixdb/asterix-doc/src/main/markdown/builtins/10_comparison.md
A asterixdb/asterix-doc/src/main/markdown/builtins/11_others.md
A asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md
A asterixdb/asterix-doc/src/main/markdown/builtins/2_string.md
A asterixdb/asterix-doc/src/main/markdown/builtins/3_binary.md
A asterixdb/asterix-doc/src/main/markdown/builtins/4_spatial.md
A asterixdb/asterix-doc/src/main/markdown/builtins/5_similarity.md
A asterixdb/asterix-doc/src/main/markdown/builtins/6_tokenizing.md
A asterixdb/asterix-doc/src/main/markdown/builtins/7_allens.md
A asterixdb/asterix-doc/src/main/markdown/builtins/7_temporal.md
A asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md
A asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_aql.md
A asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/1_intro.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/4_ddl.md
D asterixdb/asterix-doc/src/site/markdown/aql/allens.md
D asterixdb/asterix-doc/src/site/markdown/aql/functions.md
M asterixdb/asterix-doc/src/site/site.xml
23 files changed, 4,251 insertions(+), 2,972 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1221/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1221
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Run Active Shutdown On Separate Thread

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Run Active Shutdown On Separate Thread
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1223
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fd9bc454b290420682160364ac78e4b91a9abc3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No