Change in asterixdb[master]: Add user-stream for Twitter Adaptor

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1272

to look at the new patch set (#2).

Change subject: Add user-stream for Twitter Adaptor
..

Add user-stream for Twitter Adaptor

1. Add user-stream option for Twitter Adaptor
2. Refactor part of TwitterRecordReaderFactory
3. To create a user-stream feed, using following ddl:
  create feed TwitterFeed using twitter_user_stream(
  ("format"="twitter-status"),
  ("type-name"="Tweet"),
  ...
   // rest is same as push feed

Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java
5 files changed, 251 insertions(+), 76 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/72/1272/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1272
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Fixed UsedVariableVisitor for the Splitoperator

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Fixed UsedVariableVisitor for the Splitoperator
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1273
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae861c1339cf00c5a53aa2b5b5b14113ec53484b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add result location HTTP API.

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Add result location HTTP API.
..


Patch Set 2:

(1 comment)

Hi, see https://asterix-gerrit.ics.uci.edu/#/c/1170/ for examples of two ways 
variable results are now suported.  for regexadm result files, there is a 
line-by-line regex match.  For regex result files, each line of the regex file 
is matched against the entirety of the actual result.  A - in front of the 
expression indicates that a match in the actual result is forbidden, and should 
fail if matched.  Hope this helps...

https://asterix-gerrit.ics.uci.edu/#/c/1178/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java:

Line 44: public class QueryResultLocationsAPIServlets extends HttpServlet {
Should this be just *Servlet instead of *Servlets?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: Yes

Change in asterixdb[master]: DO NOT MERGE: Audit Incorrect Uses Of SynchronizableWork

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: DO NOT MERGE: Audit Incorrect Uses Of SynchronizableWork
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/902/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1275
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39b6c2cf764799e5b2a0846cd4b23660d24f4cb7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1687 - Configure Timeout On HTTP Connection

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1687 - Configure Timeout On HTTP Connection
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2993/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1276
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice9606acaec8f27b56d1d8ed947cc1588074ff2f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1687 - Configure Timeout On HTTP Connection

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1276

Change subject: ASTERIXDB-1687 - Configure Timeout On HTTP Connection
..

ASTERIXDB-1687 - Configure Timeout On HTTP Connection

Fixes ASTERIXDB-1687 - asterixhelper get_cluster_state can hang forever,
by configuring a timeout on connect and read for HTTP calls, in the
event the CC is in a bad state and cannot answer requests

Change-Id: Ice9606acaec8f27b56d1d8ed947cc1588074ff2f
---
M 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/76/1276/1

diff --git 
a/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
 
b/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
index 031a721..7e1e318 100644
--- 
a/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
+++ 
b/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
@@ -23,6 +23,7 @@
 import java.net.HttpURLConnection;
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.util.concurrent.TimeUnit;
 
 import org.apache.asterix.clienthelper.Args;
 
@@ -64,6 +65,8 @@
 protected HttpURLConnection openConnection(String path, Method method) 
throws IOException {
 URL url = new URL("http://; + hostPort + "/" + path);
 HttpURLConnection conn = (HttpURLConnection)url.openConnection();
+conn.setConnectTimeout((int) 
TimeUnit.SECONDS.toMillis(args.getTimeoutSecs()));
+conn.setReadTimeout((int) 
TimeUnit.SECONDS.toMillis(args.getTimeoutSecs()));
 conn.setRequestMethod(method.name());
 return conn;
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1276
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice9606acaec8f27b56d1d8ed947cc1588074ff2f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 

Change in asterixdb[master]: DO NOT MERGE: Audit Incorrect Uses Of SynchronizableWork

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: DO NOT MERGE: Audit Incorrect Uses Of SynchronizableWork
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2992/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1275
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39b6c2cf764799e5b2a0846cd4b23660d24f4cb7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: DO NOT MERGE: Audit Incorrect Uses Of SynchronizableWork

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1275

Change subject: DO NOT MERGE: Audit Incorrect Uses Of SynchronizableWork
..

DO NOT MERGE: Audit Incorrect Uses Of SynchronizableWork

Change-Id: I39b6c2cf764799e5b2a0846cd4b23660d24f4cb7
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/SynchronizableWork.java
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/75/1275/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/SynchronizableWork.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/SynchronizableWork.java
index f9952db..f597021 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/SynchronizableWork.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/SynchronizableWork.java
@@ -23,6 +23,8 @@
 
 public abstract class SynchronizableWork extends AbstractWork {
 private boolean done;
+private boolean runCalled;
+private boolean syncCalled;
 
 private Exception e;
 
@@ -35,6 +37,7 @@
 
 @Override
 public final void run() {
+runCalled = true;
 try {
 doRun();
 } catch (Exception ex) {
@@ -49,6 +52,7 @@
 }
 
 public final synchronized void sync() throws Exception {
+syncCalled = true;
 while (!done) {
 wait();
 }
@@ -56,4 +60,10 @@
 throw e;
 }
 }
+
+protected void finalize() throws Throwable {
+if (runCalled && !syncCalled) {
+Logger.getLogger(getClass().getName()).severe("instance of 
SynchronizableWork not sync()'d");
+}
+}
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1275
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39b6c2cf764799e5b2a0846cd4b23660d24f4cb7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 

Change in asterixdb[master]: Fixed UsedVariableVisitor for the Splitoperator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixed UsedVariableVisitor for the Splitoperator
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/901/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1273
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae861c1339cf00c5a53aa2b5b5b14113ec53484b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixed UsedVariableVisitor for the Splitoperator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixed UsedVariableVisitor for the Splitoperator
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2991/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1273
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae861c1339cf00c5a53aa2b5b5b14113ec53484b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in incubator-asterixdb-site[asf-site]: Add Wenhai into the committer list.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: Add Wenhai into the committer list.
..


Add Wenhai into the committer list.

Change-Id: Id2a21b3640cc71030d219e2d4c3fc5aa79128621
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1274
Reviewed-by: Till Westmann 
---
M community.md
M content/community.html
A content/img/team/wenhai_li.jpg
A img/team/wenhai_li.jpg
4 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved



diff --git a/community.md b/community.md
index 593be05..64fb14a 100644
--- a/community.md
+++ b/community.md
@@ -72,6 +72,7 @@
 
||---|||
 | | Inci 
Cetindil | UC Irvine  | icetindil  |
 | | Markus 
Dreseler   | HPI| mrks   |
+| | Wenhai 
Li | Wuhan University   | lwhay  |
 
 
 
diff --git a/content/community.html b/content/community.html
index 7735f6c..8ada863 100644
--- a/content/community.html
+++ b/content/community.html
@@ -373,6 +373,12 @@
   HPI
   mrks
 
+
+  
+  Wenhai Li
+  Wuhan University
+  lwhay
+
   
 
 
diff --git a/content/img/team/wenhai_li.jpg b/content/img/team/wenhai_li.jpg
new file mode 100644
index 000..ef8e46d
--- /dev/null
+++ b/content/img/team/wenhai_li.jpg
Binary files differ
diff --git a/img/team/wenhai_li.jpg b/img/team/wenhai_li.jpg
new file mode 100644
index 000..ef8e46d
--- /dev/null
+++ b/img/team/wenhai_li.jpg
Binary files differ

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1274
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2a21b3640cc71030d219e2d4c3fc5aa79128621
Gerrit-PatchSet: 2
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in incubator-asterixdb-site[asf-site]: Add Wenhai into the committer list.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add Wenhai into the committer list.
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1274
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a21b3640cc71030d219e2d4c3fc5aa79128621
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

[Jianfeng Jia (Code Review)]

Jianfeng Jia has posted comments on this change.

Change subject: Not suppose to MERGE, for discussion purpose The following 
commits from your working branch will be included:
..


Patch Set 1:

That `println` only print if anything wrong happens. So it shouldn't be the 
problem.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1135
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d437ccff51adb236f4e69c78761a2c336ae71a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 17: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/900/ : 
UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in incubator-asterixdb-site[asf-site]: Add Wenhai into the committer list.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1274

Change subject: Add Wenhai into the committer list.
..

Add Wenhai into the committer list.

Change-Id: Id2a21b3640cc71030d219e2d4c3fc5aa79128621
---
M community.md
M content/community.html
A content/img/team/wenhai_li.jpg
A img/team/wenhai_li.jpg
4 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/incubator-asterixdb-site 
refs/changes/74/1274/1

diff --git a/community.md b/community.md
index 593be05..64fb14a 100644
--- a/community.md
+++ b/community.md
@@ -72,6 +72,7 @@
 
||---|||
 | | Inci 
Cetindil | UC Irvine  | icetindil  |
 | | Markus 
Dreseler   | HPI| mrks   |
+| | Wenhai 
Li | Wuhan University   | lwhay  |
 
 
 
diff --git a/content/community.html b/content/community.html
index 7735f6c..8ada863 100644
--- a/content/community.html
+++ b/content/community.html
@@ -373,6 +373,12 @@
   HPI
   mrks
 
+
+  
+  Wenhai Li
+  Wuhan University
+  lwhay
+
   
 
 
diff --git a/content/img/team/wenhai_li.jpg b/content/img/team/wenhai_li.jpg
new file mode 100644
index 000..ef8e46d
--- /dev/null
+++ b/content/img/team/wenhai_li.jpg
Binary files differ
diff --git a/img/team/wenhai_li.jpg b/img/team/wenhai_li.jpg
new file mode 100644
index 000..ef8e46d
--- /dev/null
+++ b/img/team/wenhai_li.jpg
Binary files differ

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1274
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2a21b3640cc71030d219e2d4c3fc5aa79128621
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Yingyi Bu 

Change in incubator-asterixdb-site[asf-site]: Add Wenhai into the committer list.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Wenhai into the committer list.
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asf-site/90/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1274
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a21b3640cc71030d219e2d4c3fc5aa79128621
Gerrit-PatchSet: 1
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Closed] (ASTERIXDB-1589) Proxy parameters for TwitterFeed

[Yingyi Bu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu closed ASTERIXDB-1589.

Resolution: Fixed

> Proxy parameters for TwitterFeed
> 
>
> Key: ASTERIXDB-1589
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1589
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: AsterixDB, Feeds
>Reporter: Wail Alkowaileet
>Assignee: Wail Alkowaileet
>Priority: Blocker
>
> TwitterFeed currently doesn't run if AsterixDB is behind a proxy.
> I want to extend TwitterFeed config parameters to accept ``proxy-address`` 
> and ``proxy-port``. 
> I just want to get the approval if the parameters' names are fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (ASTERIXDB-1627) create-polygon() from array of double is giving wrong numbers

[Yingyi Bu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu closed ASTERIXDB-1627.

Resolution: Fixed

Fixed with regression tests.

> create-polygon() from array of double is giving wrong numbers
> -
>
> Key: ASTERIXDB-1627
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1627
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Data Formats, Data Model
>Reporter: Wail Alkowaileet
>Assignee: Wail Alkowaileet
>
> Hi,
> Data:
> https://www.dropbox.com/s/52c6uxufuldqzmm/statesJson.zip?dl=0
> DDL:
> {noformat}
> drop dataverse TwitterDataverse if exists
> create dataverse TwitterDataverse
> use dataverse TwitterDataverse
> create type StateType as {
> uid: uuid
> }
> create dataset States(StateType) 
> primary key uid autogenerated
> {noformat}
> DML:
> {noformat}
> use dataverse TwitterDataverse
> load dataset States using localfs
> (("path"="localhost:///path/to/statesJson"),
> ("format"="adm"))
> {noformat}
> Get the array of doubles from the GeoJSON:
> {noformat}
> use dataverse TwitterDataverse
> let $polygon := (for $x in dataset States
> where $x.features[0].geometry.'type' = "Polygon"
> limit 1
> let $list := (for $i in $x.features[0].geometry.coordinates[0]
> for $j in $i
> for $k in $j
> return $k
> )
> return $list
> )
> return $polygon
> {noformat}
> Output:
> {noformat}
> [ -87.359296, 35.00118, -85.606675, 34.984749, -85.431413, 34.124869, 
> -85.184951, 32.859696, -85.069935, 32.580372, -84.960397, 32.421541, 
> -85.004212, 32.322956, -84.889196, 32.262709, -85.058981, 32.13674, 
> -85.053504, 32.01077, -85.141136, 31.840985, -85.042551, 31.539753, 
> -85.113751, 31.27686, -85.004212, 31.003013, -85.497137, 30.997536, 
> -87.600282, 30.997536, -87.633143, 30.86609, -87.408589, 30.674397, 
> -87.446927, 30.510088, -87.37025, 30.427934, -87.518128, 30.280057, 
> -87.655051, 30.247195, -87.90699, 30.411504, -87.934375, 30.657966, 
> -88.011052, 30.685351, -88.10416, 30.499135, -88.137022, 30.318396, 
> -88.394438, 30.367688, -88.471115, 31.895754, -88.241084, 33.796253, 
> -88.098683, 34.891641, -88.202745, 34.995703, -87.359296, 35.00118 ]
> {noformat}
> applying create-polygon() on the resulting array:
> {noformat}
> use dataverse TwitterDataverse
> let $polygon := (for $x in dataset States
> where $x.features[0].geometry.'type' = "Polygon"
> limit 1
> let $list := (for $i in $x.features[0].geometry.coordinates[0]
> for $j in $i
> for $k in $j
> return $k
> )
> return $list
> )
> return create-polygon($polygon)
> {noformat}
> Output:
> {noformat}
> polygon("2.920390972995509E-247,1.1352293178511514E-249 
> 2.920084986948524E-247,1.1352270767181132E-249 
> 2.9200543883612843E-247,1.1351097919833495E-249 
> 2.920011359130714E-247,1.1349372266489597E-249 
> 2.919991278753279E-247,1.1348991277964998E-249 
> 2.919972154767195E-247,1.1348774637832571E-249 
> 2.919979804326711E-247,1.1348640171214245E-249 
> 2.919959723949276E-247,1.1348557996336175E-249 
> 2.919989366319753E-247,1.1348386178864513E-249 
> 2.91998841010299E-247,1.1348214360028882E-249 
> 2.9200037095711975E-247,1.1347765887907304E-249 
> 2.919986497844052E-247,1.134694414731042E-249 
> 2.9199989284873825E-247,1.1346226992921991E-249 
> 2.919979804326711E-247,1.1345479956759716E-249 
> 2.92006586296244E-247,1.1345465015872795E-249 
> 2.920433046183905E-247,1.1345465015872795E-249 
> 2.920438783309895E-247,1.1345106440042545E-249 
> 2.920399578946376E-247,1.134458351445616E-249 
> 2.920406272289129E-247,1.134413529057645E-249 
> 2.9203928854290354E-247,1.13439111856E-249 
> 2.920418703107048E-247,1.1343507781509548E-249 
> 2.9204426081769465E-247,1.134341813618802E-249 
> 2.9204865936242805E-247,1.134386636006773E-249 
> 2.920491374708095E-247,1.1344538691795396E-249 
> 2.920504761568189E-247,1.1344613396230002E-249 
> 2.920521017078572E-247,1.1344105411530538E-249 
> 2.92052675437915E-247,1.1343612367717997E-249 
> 2.9205716960432465E-247,1.1343746832972356E-249 
> 2.92058508290334E-247,1.1347915294048584E-249 
> 2.9205449223230584E-247,1.1350649698681716E-249 
> 2.9205200608618086E-247,1.1352143771006265E-249 
> 2.920538228805718E-247,1.1352285708068053E-249 
> 2.920390972995509E-247,1.1352293178511514E-249")
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (ASTERIXDB-1673) ARecordCaster potential object creation problem

[Yingyi Bu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu closed ASTERIXDB-1673.

Resolution: Fixed

> ARecordCaster potential object creation problem
> ---
>
> Key: ASTERIXDB-1673
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1673
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Data Model
>Reporter: Wail Alkowaileet
>Assignee: Wail Alkowaileet
>Priority: Trivial
>
> I use ACastVIsitor extensively in my work and I found that on 
> loadRequiredType:
> The allocator will keep allocating Pointables (for typetag and fieldNames) 
> which would never be cleared.
> I ran an experiment and got more than 6 million objects on a dataset of size 
> 1.5GB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1673) ARecordCaster potential object creation problem

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570479#comment-15570479
 ] 

ASF subversion and git services commented on ASTERIXDB-1673:


Commit e65a57ab27a92670f9ef42d188c1b62a11fe765d in asterixdb's branch 
refs/heads/master from [~wyk]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=e65a57a ]

ASTERIXDB-1673 and some small cleanups

- Fix potential object creation issue in ARecordCaster.
- refactor getFieldOffsetById() in ARecordSerializerDeserailzer.
- remove dead code in method set() in ARecordVisitablePointable.
- Introduce unrestable allocation in PointableAllocator as static method.

Change-Id: I3802a5a33b46b58967ffb4a28a70ebe9671bfabf
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1260
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 


> ARecordCaster potential object creation problem
> ---
>
> Key: ASTERIXDB-1673
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1673
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Data Model
>Reporter: Wail Alkowaileet
>Assignee: Wail Alkowaileet
>Priority: Trivial
>
> I use ACastVIsitor extensively in my work and I found that on 
> loadRequiredType:
> The allocator will keep allocating Pointables (for typetag and fieldNames) 
> which would never be cleared.
> I ran an experiment and got more than 6 million objects on a dataset of size 
> 1.5GB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1673 and some small cleanups

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: ASTERIXDB-1673 and some small cleanups
..


ASTERIXDB-1673 and some small cleanups

- Fix potential object creation issue in ARecordCaster.
- refactor getFieldOffsetById() in ARecordSerializerDeserailzer.
- remove dead code in method set() in ARecordVisitablePointable.
- Introduce unrestable allocation in PointableAllocator as static method.

Change-Id: I3802a5a33b46b58967ffb4a28a70ebe9671bfabf
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1260
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/PointableAllocator.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ACastVisitor.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/AListCaster.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
6 files changed, 74 insertions(+), 95 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
index 55c9d13..fb5d0c7 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
@@ -214,8 +214,7 @@
 
 @SuppressWarnings("unchecked")
 public static void serializeSimpleSchemalessRecord(List> record, DataOutput dataOutput,
-boolean writeTypeTag)
-throws HyracksDataException {
+boolean writeTypeTag) throws HyracksDataException {
 ISerializerDeserializer stringSerde = 
AqlSerializerDeserializerProvider.INSTANCE
 .getSerializerDeserializer(BuiltinType.ASTRING);
 RecordBuilder confRecordBuilder = new RecordBuilder();
@@ -268,67 +267,39 @@
 
 public static final int getFieldOffsetById(byte[] serRecord, int offset, 
int fieldId, int nullBitmapSize,
 boolean isOpen) {
-byte nullTestCode = (byte) (1 << (7 - 2 * (fieldId % 4)));
-byte missingTestCode = (byte) (1 << (7 - 2 * (fieldId % 4) - 1));
+final byte nullTestCode = (byte) (1 << (7 - 2 * (fieldId % 4)));
+final byte missingTestCode = (byte) (1 << (7 - 2 * (fieldId % 4) - 1));
+
+//early exit if not Record
+if (serRecord[offset] != ATypeTag.SERIALIZED_RECORD_TYPE_TAG) {
+return -1;
+}
+
+//advance to isExpanded or numberOfSchemaFields
+int pointer = offset + 5;
+
 if (isOpen) {
-if (serRecord[0 + offset] == ATypeTag.RECORD.serialize()) {
-// 5 is the index of the byte that determines whether the 
record
-// is expanded or not, i.e. it has an open part.
-if (serRecord[5 + offset] == 1) { // true
-if (nullBitmapSize > 0) {
-// 14 = tag (1) + record Size (4) + isExpanded (1) +
-// offset of openPart (4) + number of closed fields (4)
-int pos = 14 + offset + fieldId / 4;
-if ((serRecord[pos] & nullTestCode) == 0) {
-// the field value is null
-return 0;
-}
-if ((serRecord[pos] & missingTestCode) == 0) {
-// the field value is missing
-return -1;
-}
-}
-return offset + 
AInt32SerializerDeserializer.getInt(serRecord,
-14 + offset + nullBitmapSize + (4 * fieldId));
-} else {
-if (nullBitmapSize > 0) {
-// 9 = tag (1) + record Size (4) + isExpanded (1) +
-// number of closed fields (4)
-int pos = 10 + offset + fieldId / 4;
-if ((serRecord[pos] & nullTestCode) == 0) {
-// the field value is null
-return 0;
-}
-if 

Change in asterixdb[master]: ASTERIXDB-1673 and some small cleanups

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1673 and some small cleanups
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1260
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3802a5a33b46b58967ffb4a28a70ebe9671bfabf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

[jira] [Closed] (ASTERIXDB-1300) Hint for desired index names

[Yingyi Bu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu closed ASTERIXDB-1300.

Resolution: Fixed

The feature can be achieved by using skip index hints.

> Hint for desired index names
> 
>
> Key: ASTERIXDB-1300
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1300
> Project: Apache AsterixDB
>  Issue Type: Improvement
>Reporter: Yingyi Bu
>Assignee: Jianfeng Jia
>  Labels: soon
>
> Add a hint in the filter expression in the where clause to allow a user to 
> specify desired indexes to use for a particular query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Not suppose to MERGE, for discussion purpose The following 
commits from your working branch will be included:
..


Patch Set 1:

Jianfeng, if you don't println, is it still take long time to run?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1135
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d437ccff51adb236f4e69c78761a2c336ae71a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1300) Hint for desired index names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570453#comment-15570453
 ] 

ASF subversion and git services commented on ASTERIXDB-1300:


Commit eb88f0e52a538fbe8e4667c738fc301d43d6e945 in asterixdb's branch 
refs/heads/master from [~javierjia]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=eb88f0e ]

Add tests for ASTERIXDB-1300

The intersection for multiple-secondary indexes will follow the skip-index hint.

Change-Id: I797bdb37fda1c29c9cfc45efb6fbcba4e7b6c29e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1093
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 


> Hint for desired index names
> 
>
> Key: ASTERIXDB-1300
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1300
> Project: Apache AsterixDB
>  Issue Type: Improvement
>Reporter: Yingyi Bu
>Assignee: Jianfeng Jia
>  Labels: soon
>
> Add a hint in the filter expression in the where clause to allow a user to 
> specify desired indexes to use for a particular query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Add tests for ASTERIXDB-1300

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Add tests for ASTERIXDB-1300
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1093
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I797bdb37fda1c29c9cfc45efb6fbcba4e7b6c29e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1627) create-polygon() from array of double is giving wrong numbers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570449#comment-15570449
 ] 

ASF subversion and git services commented on ASTERIXDB-1627:


Commit 019ebf888c46bd4c7a6e486c8c344ce3bf9b548d in asterixdb's branch 
refs/heads/master from [~wyk]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=019ebf8 ]

ASTERIXDB-1589, ASTERIXDB-1627 addition and fix.

- Add support for proxy when using TwitterFeed.
- Fix corrupted polygon values when created from open list of doubles.
- Add regression test for ASTERIXDB-1627.

Change-Id: Ia8bdd0fbb63310212364ab9e52d34fec675a4c71
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1261
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 


> create-polygon() from array of double is giving wrong numbers
> -
>
> Key: ASTERIXDB-1627
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1627
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Data Formats, Data Model
>Reporter: Wail Alkowaileet
>Assignee: Wail Alkowaileet
>
> Hi,
> Data:
> https://www.dropbox.com/s/52c6uxufuldqzmm/statesJson.zip?dl=0
> DDL:
> {noformat}
> drop dataverse TwitterDataverse if exists
> create dataverse TwitterDataverse
> use dataverse TwitterDataverse
> create type StateType as {
> uid: uuid
> }
> create dataset States(StateType) 
> primary key uid autogenerated
> {noformat}
> DML:
> {noformat}
> use dataverse TwitterDataverse
> load dataset States using localfs
> (("path"="localhost:///path/to/statesJson"),
> ("format"="adm"))
> {noformat}
> Get the array of doubles from the GeoJSON:
> {noformat}
> use dataverse TwitterDataverse
> let $polygon := (for $x in dataset States
> where $x.features[0].geometry.'type' = "Polygon"
> limit 1
> let $list := (for $i in $x.features[0].geometry.coordinates[0]
> for $j in $i
> for $k in $j
> return $k
> )
> return $list
> )
> return $polygon
> {noformat}
> Output:
> {noformat}
> [ -87.359296, 35.00118, -85.606675, 34.984749, -85.431413, 34.124869, 
> -85.184951, 32.859696, -85.069935, 32.580372, -84.960397, 32.421541, 
> -85.004212, 32.322956, -84.889196, 32.262709, -85.058981, 32.13674, 
> -85.053504, 32.01077, -85.141136, 31.840985, -85.042551, 31.539753, 
> -85.113751, 31.27686, -85.004212, 31.003013, -85.497137, 30.997536, 
> -87.600282, 30.997536, -87.633143, 30.86609, -87.408589, 30.674397, 
> -87.446927, 30.510088, -87.37025, 30.427934, -87.518128, 30.280057, 
> -87.655051, 30.247195, -87.90699, 30.411504, -87.934375, 30.657966, 
> -88.011052, 30.685351, -88.10416, 30.499135, -88.137022, 30.318396, 
> -88.394438, 30.367688, -88.471115, 31.895754, -88.241084, 33.796253, 
> -88.098683, 34.891641, -88.202745, 34.995703, -87.359296, 35.00118 ]
> {noformat}
> applying create-polygon() on the resulting array:
> {noformat}
> use dataverse TwitterDataverse
> let $polygon := (for $x in dataset States
> where $x.features[0].geometry.'type' = "Polygon"
> limit 1
> let $list := (for $i in $x.features[0].geometry.coordinates[0]
> for $j in $i
> for $k in $j
> return $k
> )
> return $list
> )
> return create-polygon($polygon)
> {noformat}
> Output:
> {noformat}
> polygon("2.920390972995509E-247,1.1352293178511514E-249 
> 2.920084986948524E-247,1.1352270767181132E-249 
> 2.9200543883612843E-247,1.1351097919833495E-249 
> 2.920011359130714E-247,1.1349372266489597E-249 
> 2.919991278753279E-247,1.1348991277964998E-249 
> 2.919972154767195E-247,1.1348774637832571E-249 
> 2.919979804326711E-247,1.1348640171214245E-249 
> 2.919959723949276E-247,1.1348557996336175E-249 
> 2.919989366319753E-247,1.1348386178864513E-249 
> 2.91998841010299E-247,1.1348214360028882E-249 
> 2.9200037095711975E-247,1.1347765887907304E-249 
> 2.919986497844052E-247,1.134694414731042E-249 
> 2.9199989284873825E-247,1.1346226992921991E-249 
> 2.919979804326711E-247,1.1345479956759716E-249 
> 2.92006586296244E-247,1.1345465015872795E-249 
> 2.920433046183905E-247,1.1345465015872795E-249 
> 2.920438783309895E-247,1.1345106440042545E-249 
> 2.920399578946376E-247,1.134458351445616E-249 
> 2.920406272289129E-247,1.134413529057645E-249 
> 2.9203928854290354E-247,1.13439111856E-249 
> 2.920418703107048E-247,1.1343507781509548E-249 
> 2.9204426081769465E-247,1.134341813618802E-249 
> 2.9204865936242805E-247,1.134386636006773E-249 
> 2.920491374708095E-247,1.1344538691795396E-249 
> 2.920504761568189E-247,1.1344613396230002E-249 
> 2.920521017078572E-247,1.1344105411530538E-249 
> 2.92052675437915E-247,1.1343612367717997E-249 
> 2.9205716960432465E-247,1.1343746832972356E-249 
> 2.92058508290334E-247,1.1347915294048584E-249 
> 2.9205449223230584E-247,1.1350649698681716E-249 
> 

[jira] [Commented] (ASTERIXDB-1589) Proxy parameters for TwitterFeed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570448#comment-15570448
 ] 

ASF subversion and git services commented on ASTERIXDB-1589:


Commit 019ebf888c46bd4c7a6e486c8c344ce3bf9b548d in asterixdb's branch 
refs/heads/master from [~wyk]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=019ebf8 ]

ASTERIXDB-1589, ASTERIXDB-1627 addition and fix.

- Add support for proxy when using TwitterFeed.
- Fix corrupted polygon values when created from open list of doubles.
- Add regression test for ASTERIXDB-1627.

Change-Id: Ia8bdd0fbb63310212364ab9e52d34fec675a4c71
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1261
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 


> Proxy parameters for TwitterFeed
> 
>
> Key: ASTERIXDB-1589
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1589
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: AsterixDB, Feeds
>Reporter: Wail Alkowaileet
>Assignee: Wail Alkowaileet
>Priority: Blocker
>
> TwitterFeed currently doesn't run if AsterixDB is behind a proxy.
> I want to extend TwitterFeed config parameters to accept ``proxy-address`` 
> and ``proxy-port``. 
> I just want to get the approval if the parameters' names are fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1627) create-polygon() from array of double is giving wrong numbers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570450#comment-15570450
 ] 

ASF subversion and git services commented on ASTERIXDB-1627:


Commit 019ebf888c46bd4c7a6e486c8c344ce3bf9b548d in asterixdb's branch 
refs/heads/master from [~wyk]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=019ebf8 ]

ASTERIXDB-1589, ASTERIXDB-1627 addition and fix.

- Add support for proxy when using TwitterFeed.
- Fix corrupted polygon values when created from open list of doubles.
- Add regression test for ASTERIXDB-1627.

Change-Id: Ia8bdd0fbb63310212364ab9e52d34fec675a4c71
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1261
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 


> create-polygon() from array of double is giving wrong numbers
> -
>
> Key: ASTERIXDB-1627
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1627
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Data Formats, Data Model
>Reporter: Wail Alkowaileet
>Assignee: Wail Alkowaileet
>
> Hi,
> Data:
> https://www.dropbox.com/s/52c6uxufuldqzmm/statesJson.zip?dl=0
> DDL:
> {noformat}
> drop dataverse TwitterDataverse if exists
> create dataverse TwitterDataverse
> use dataverse TwitterDataverse
> create type StateType as {
> uid: uuid
> }
> create dataset States(StateType) 
> primary key uid autogenerated
> {noformat}
> DML:
> {noformat}
> use dataverse TwitterDataverse
> load dataset States using localfs
> (("path"="localhost:///path/to/statesJson"),
> ("format"="adm"))
> {noformat}
> Get the array of doubles from the GeoJSON:
> {noformat}
> use dataverse TwitterDataverse
> let $polygon := (for $x in dataset States
> where $x.features[0].geometry.'type' = "Polygon"
> limit 1
> let $list := (for $i in $x.features[0].geometry.coordinates[0]
> for $j in $i
> for $k in $j
> return $k
> )
> return $list
> )
> return $polygon
> {noformat}
> Output:
> {noformat}
> [ -87.359296, 35.00118, -85.606675, 34.984749, -85.431413, 34.124869, 
> -85.184951, 32.859696, -85.069935, 32.580372, -84.960397, 32.421541, 
> -85.004212, 32.322956, -84.889196, 32.262709, -85.058981, 32.13674, 
> -85.053504, 32.01077, -85.141136, 31.840985, -85.042551, 31.539753, 
> -85.113751, 31.27686, -85.004212, 31.003013, -85.497137, 30.997536, 
> -87.600282, 30.997536, -87.633143, 30.86609, -87.408589, 30.674397, 
> -87.446927, 30.510088, -87.37025, 30.427934, -87.518128, 30.280057, 
> -87.655051, 30.247195, -87.90699, 30.411504, -87.934375, 30.657966, 
> -88.011052, 30.685351, -88.10416, 30.499135, -88.137022, 30.318396, 
> -88.394438, 30.367688, -88.471115, 31.895754, -88.241084, 33.796253, 
> -88.098683, 34.891641, -88.202745, 34.995703, -87.359296, 35.00118 ]
> {noformat}
> applying create-polygon() on the resulting array:
> {noformat}
> use dataverse TwitterDataverse
> let $polygon := (for $x in dataset States
> where $x.features[0].geometry.'type' = "Polygon"
> limit 1
> let $list := (for $i in $x.features[0].geometry.coordinates[0]
> for $j in $i
> for $k in $j
> return $k
> )
> return $list
> )
> return create-polygon($polygon)
> {noformat}
> Output:
> {noformat}
> polygon("2.920390972995509E-247,1.1352293178511514E-249 
> 2.920084986948524E-247,1.1352270767181132E-249 
> 2.9200543883612843E-247,1.1351097919833495E-249 
> 2.920011359130714E-247,1.1349372266489597E-249 
> 2.919991278753279E-247,1.1348991277964998E-249 
> 2.919972154767195E-247,1.1348774637832571E-249 
> 2.919979804326711E-247,1.1348640171214245E-249 
> 2.919959723949276E-247,1.1348557996336175E-249 
> 2.919989366319753E-247,1.1348386178864513E-249 
> 2.91998841010299E-247,1.1348214360028882E-249 
> 2.9200037095711975E-247,1.1347765887907304E-249 
> 2.919986497844052E-247,1.134694414731042E-249 
> 2.9199989284873825E-247,1.1346226992921991E-249 
> 2.919979804326711E-247,1.1345479956759716E-249 
> 2.92006586296244E-247,1.1345465015872795E-249 
> 2.920433046183905E-247,1.1345465015872795E-249 
> 2.920438783309895E-247,1.1345106440042545E-249 
> 2.920399578946376E-247,1.134458351445616E-249 
> 2.920406272289129E-247,1.134413529057645E-249 
> 2.9203928854290354E-247,1.13439111856E-249 
> 2.920418703107048E-247,1.1343507781509548E-249 
> 2.9204426081769465E-247,1.134341813618802E-249 
> 2.9204865936242805E-247,1.134386636006773E-249 
> 2.920491374708095E-247,1.1344538691795396E-249 
> 2.920504761568189E-247,1.1344613396230002E-249 
> 2.920521017078572E-247,1.1344105411530538E-249 
> 2.92052675437915E-247,1.1343612367717997E-249 
> 2.9205716960432465E-247,1.1343746832972356E-249 
> 2.92058508290334E-247,1.1347915294048584E-249 
> 2.9205449223230584E-247,1.1350649698681716E-249 
> 

Change in asterixdb[master]: ASTERIXDB-1589, ASTERIXDB-1627 addition and fix.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: ASTERIXDB-1589, ASTERIXDB-1627 addition and fix.
..


ASTERIXDB-1589, ASTERIXDB-1627 addition and fix.

- Add support for proxy when using TwitterFeed.
- Fix corrupted polygon values when created from open list of doubles.
- Add regression test for ASTERIXDB-1627.

Change-Id: Ia8bdd0fbb63310212364ab9e52d34fec675a4c71
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1261
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreatePolygonDescriptor.java
8 files changed, 132 insertions(+), 13 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.1.ddl.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.1.ddl.aql
new file mode 100644
index 000..faf6082
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.1.ddl.aql
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+* Description  : Fix corrupted polygon values from open list of doubles
+* Expected Res : Success
+* Issue: 1627
+* Date : 07th Oct. 2016
+*/
+drop dataverse test if exists;
+create dataverse test
+use dataverse test
+
+create type StateType as {
+id: int32
+}
+
+create dataset States(StateType)
+primary key id
\ No newline at end of file
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.2.update.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.2.update.aql
new file mode 100644
index 000..5beb303
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/constructor/polygon-from-open-list_issue1627/polygon-from-open-list_issue1627.2.update.aql
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+* Description  : Fix corrupted 

Change in asterixdb[master]: ASTERIXDB-1589, ASTERIXDB-1627 addition and fix.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1589, ASTERIXDB-1627 addition and fix.
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1261
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bdd0fbb63310212364ab9e52d34fec675a4c71
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text implementation step 1
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/899/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1228
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 13: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/898/ : 
UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 17:

One more question:

What's the difference between ASYNC and ASYNC_DEFERRED?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 17:

(13 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java:

Line 160: public void fail() throws HyracksDataException {
Just to be consistent with other places:

if(isSink){
   return;
}
writer.fail();


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java:

Line 88: Stack opStack = new Stack<>();
Stack is thread-safe and slower.
Use ArrayDeque which is not thread-safe.


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

Line 675: if (expr.getExpressionTag() != 
LogicalExpressionTag.FUNCTION_CALL) {
Add a comment in the code why this if-check is needed?


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.1.ddl.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.1.ddl.aql:

Line 1: /*
ASF copy right header?


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.3.query.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.3.query.aql:

Line 3:  * Description : Check records returned on insert
ASF copyright header?


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.1.ddl.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.1.ddl.aql:

Line 9: drop dataverse test if exists;
ASF copyright header?


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.3.query.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.3.query.aql:

Line 3:  * Description : Check fields returned on insert
ASF header


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.1.ddl.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.1.ddl.aql:

Line 5:  * Date: Mar 2015
ASF header


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.3.query.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.3.query.aql:

Line 7: 
ASF header?


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml:

Line 1710: 
add a negative test to check error message if the returning query refers to a 
dataset.


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-doc/src/site/markdown/aql/manual.md
File asterixdb/asterix-doc/src/site/markdown/aql/manual.md:

Line 839: The optional "returning Query" allows users to run simple 
queries/functions on the records returned by the insert
Document that the "returning query" should not refer a dataset.


https://asterix-gerrit.ics.uci.edu/#/c/1150/17/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
File asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj:

Line 943:   query = Query() ( "returning" returnQuery = Query())?
Put "returning" into the keyword list and use  here.


Line 945:   query.setTopLevel(true); 
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 

Change in asterixdb[master]: Enhanced Insert AQL

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 17:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/900/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-1692) Case statement referring to aggregated value throws ArrayIndexOutOfBoundsException

[Vignesh Raghunathan (JIRA)]

Vignesh Raghunathan created ASTERIXDB-1692:
--

 Summary: Case statement referring to aggregated value throws 
ArrayIndexOutOfBoundsException
 Key: ASTERIXDB-1692
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1692
 Project: Apache AsterixDB
  Issue Type: Bug
 Environment: Master branch with latest commit 
76a4f9e36e841d9325bedb3bb96e7
Reporter: Vignesh Raghunathan


To reproduce the issue, run the following SQL++ statements:

{code}
drop dataverse sampdb if exists;
create dataverse sampdb;
use sampdb;

create type samptabletype as closed {
  id1: int8,
  id2:int8?
};

create dataset samptable1(samptabletype) primary key id1;

insert into samptable1 ({'id1' : 1, 'id2':5});
insert into samptable1 ({'id1' : 2, 'id2':10});

with st1 as (
select id1, sum(id2) id2sum
from samptable1
group by id1)
select *
from st1
where (case when id2sum > 5 then (id2sum/id2sum) = 1 else true end);
{code}

Result:

{code}
4 [ArrayIndexOutOfBoundsException]
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Full-text implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text implementation step 1
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/899/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1228
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Introduce XML Reader & Parser

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Introduce XML Reader & Parser
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/897/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 13:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/898/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

[Steven Jacobs (Code Review)]

Steven Jacobs has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 12:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java:

Line 190: if (annotation != null && !((Boolean) annotation)) {
> OK, can you give me an example that moving a non-pure call is fine?
In this case, it is actually deciding whether the field access can be pushed 
through op2. This is okay even when op2 is nonPure.


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

Line 668: //Get Variables used by afterSelectRefs that were created before 
the datasource
> But retainInput changes the semantics?
I don't quite understand this question. This method makes it so that, in the 
select case, if variables are used after the select, they are retained after 
the select.


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java:

Line 80: ILogicalExpression[] getConstantExpressions();
> Does the constant mean a real "constant" in the query, or it means a relati
Constants will only be "real constants" after this change. Previous changes 
allowed for other cases, but we will not allow for these anymore.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add user-stream for Twitter Adaptor

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add user-stream for Twitter Adaptor
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/896/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1272
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixed UsedVariableVisitor for the Splitoperator

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fixed UsedVariableVisitor for the Splitoperator
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2990/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1273
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae861c1339cf00c5a53aa2b5b5b14113ec53484b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixed UsedVariableVisitor for the Splitoperator

[Taewoo Kim (Code Review)]

Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1273

Change subject: Fixed UsedVariableVisitor for the Splitoperator
..

Fixed UsedVariableVisitor for the Splitoperator

 - The used variables of SplitOperator and ReplicateOperator
   now don't include the used variables from their output(s).

Change-Id: Iae861c1339cf00c5a53aa2b5b5b14113ec53484b
---
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/73/1273/1

diff --git 
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java
 
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java
index cfe2a37..3daa00f 100644
--- 
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java
+++ 
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java
@@ -428,17 +428,12 @@
 
 @Override
 public Void visitReplicateOperator(ReplicateOperator op, Void arg) throws 
AlgebricksException {
-for (Mutable outputOp : op.getOutputs()) {
-VariableUtilities.getUsedVariables(outputOp.getValue(), 
usedVariables);
-}
 return null;
 }
 
 @Override
 public Void visitSplitOperator(SplitOperator op, Void arg) throws 
AlgebricksException {
-for (Mutable outputOp : op.getOutputs()) {
-VariableUtilities.getUsedVariables(outputOp.getValue(), 
usedVariables);
-}
+op.getBranchingExpression().getValue().getUsedVariables(usedVariables);
 return null;
 }
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1273
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae861c1339cf00c5a53aa2b5b5b14113ec53484b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 12:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java:

Line 190: if (annotation != null && !((Boolean) annotation)) {
> I changed OperatorPropertiesUtil.isMovable to return false in the case of a
OK, can you give me an example that moving a non-pure call is fine?


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

Line 668: //Get Variables used by afterSelectRefs that were created before 
the datasource
> This method isn't getting used in the join case.
But retainInput changes the semantics?

It propagates the input regardless it has a match or not in the BTree...
Do you have post-validate filters to prevent wrong results be generated?


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java:

Line 80: ILogicalExpression[] getConstantExpressions();
> This is just a quick way to find out whether there are any constants involv
Does the constant mean a real "constant" in the query, or it means a relative 
constant?


For example,

for $i in dataset foo

  let $j=current_time()

  for $k in dataset bar
  where
return ...


$j is not real constant, but a relative constant to the nested for loop.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Introduce XML Reader & Parser

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Introduce XML Reader & Parser
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/897/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Enhanced Insert AQL
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2989/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: fix escaping of strings in JSON values

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix escaping of strings in JSON values
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/895/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1271
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68c1c4606501dbd205e67d6a73f4086a8f0b793
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Add user-stream for Twitter Adaptor

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add user-stream for Twitter Adaptor
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/896/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1272
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: fix escaping of strings in JSON values

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: fix escaping of strings in JSON values
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1271
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68c1c4606501dbd205e67d6a73f4086a8f0b793
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Enhanced Insert AQL

[abdullah alamoudi (Code Review)]

Hello Michael Carey, Michael Blow, Steven Jacobs, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1150

to look at the new patch set (#17).

Change subject: Enhanced Insert AQL
..

Enhanced Insert AQL

The optional "as Variable" provides a variable binding for the inserted records
The optional "returning Query" allows users to run simple
queries/functions on the records returned by the insert, and can refer
to the variable bound in "as Variable"

Allow commits to be non-sink operators (contnue job pipeline after commit)

Additionally, this change makes small modifications to
the extension code to prepare for the BAD extension

Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
---
M asterixdb/asterix-active/pom.xml
M 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/CommitOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntimeFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/UpsertCommitRuntime.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceRapidFrameFlushProjectAssignRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java
R 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/insert-return-custom-result.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/insert-return-custom-result.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-return-records/insert-return-records.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-returning-fieldname/insert-returning-fieldname.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/dml/insert-return-records/insert-return-records.1.adm
A 

Change in asterixdb[master]: Full-text implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text implementation step 1
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1228
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Introduce XML Reader & Parser

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Introduce XML Reader & Parser
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2986/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Add user-stream for Twitter Adaptor

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add user-stream for Twitter Adaptor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2985/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1272
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add user-stream for Twitter Adaptor

[Xikui Wang (Code Review)]

Xikui Wang has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1272

Change subject: Add user-stream for Twitter Adaptor
..

Add user-stream for Twitter Adaptor

1. Add user-stream option for Twitter Adaptor
2. Refactor part of TwitterRecordReaderFactory
3. To create a user-stream feed, using following ddl:
  create feed TwitterFeed using twitter_user_stream(
  ("format"="twitter-status"),
  ("type-name"="Tweet"),
  ...
   // rest is same as push feed

Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java
5 files changed, 278 insertions(+), 93 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/72/1272/1

diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
index 9ead8a9..c296bc6 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
@@ -26,6 +26,8 @@
 import org.apache.asterix.external.dataflow.AbstractFeedDataFlowController;
 import org.apache.asterix.external.input.record.GenericRecord;
 import org.apache.asterix.external.util.FeedLogManager;
+import org.apache.asterix.external.util.TwitterUtil;
+import twitter4j.DirectMessage;
 import twitter4j.FilterQuery;
 import twitter4j.StallWarning;
 import twitter4j.Status;
@@ -33,27 +35,43 @@
 import twitter4j.StatusListener;
 import twitter4j.TwitterObjectFactory;
 import twitter4j.TwitterStream;
+import twitter4j.User;
+import twitter4j.UserList;
+import twitter4j.UserStreamListener;
 
 public class TwitterPushRecordReader implements IRecordReader {
 private LinkedBlockingQueue inputQ;
 private TwitterStream twitterStream;
 private GenericRecord record;
+private StatusListener tweetListener;
 private boolean closed = false;
 
-public TwitterPushRecordReader(TwitterStream twitterStream, FilterQuery 
query) {
-record = new GenericRecord<>();
-inputQ = new LinkedBlockingQueue<>();
-this.twitterStream = 
twitterStream;//TwitterUtil.getTwitterStream(configuration);
-this.twitterStream.addListener(new TweetListener(inputQ));
+public TwitterPushRecordReader(TwitterStream twitterStream, 
TwitterUtil.TweetListener tweetListener,
+FilterQuery query) {
+init(twitterStream);
+tweetListener.setInputQ(inputQ);
+this.twitterStream.addListener(tweetListener);
 this.twitterStream.filter(query);
 }
 
-public TwitterPushRecordReader(TwitterStream twitterStream) {
+public TwitterPushRecordReader(TwitterStream twitterStream, 
TwitterUtil.TweetListener tweetListener) {
+init(twitterStream);
+tweetListener.setInputQ(inputQ);
+this.twitterStream.addListener(tweetListener);
+twitterStream.sample();
+}
+
+public TwitterPushRecordReader(TwitterStream twitterStream, 
TwitterUtil.UserTweetsListener tweetListener) {
+init(twitterStream);
+tweetListener.setInputQ(inputQ);
+this.twitterStream.addListener(tweetListener);
+twitterStream.user();
+}
+
+private void init(TwitterStream twitterStream) {
 record = new GenericRecord<>();
 inputQ = new LinkedBlockingQueue<>();
-this.twitterStream = twitterStream;//
-this.twitterStream.addListener(new TweetListener(inputQ));
-twitterStream.sample();
+this.twitterStream = twitterStream;
 }
 
 @Override
@@ -89,46 +107,6 @@
 return false;
 }
 return true;
-}
-
-private class TweetListener implements StatusListener {
-
-private LinkedBlockingQueue inputQ;
-
-public TweetListener(LinkedBlockingQueue inputQ) {
-this.inputQ = inputQ;
-}
-
-@Override
-public void onStatus(Status tweet) {
-String jsonTweet = TwitterObjectFactory.getRawJSON(tweet);
-inputQ.add(jsonTweet);
-}
-
-@Override
-public void 

Change in asterixdb[master]: fix escaping of strings in JSON values

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix escaping of strings in JSON values
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/895/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1271
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68c1c4606501dbd205e67d6a73f4086a8f0b793
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: fix escaping of strings in JSON values

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: fix escaping of strings in JSON values
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2984/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1271
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68c1c4606501dbd205e67d6a73f4086a8f0b793
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: fix escaping of strings in JSON values

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1271

Change subject: fix escaping of strings in JSON values
..

fix escaping of strings in JSON values

Change-Id: If68c1c4606501dbd205e67d6a73f4086a8f0b793
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/71/1271/1

diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
index fd89c5e..0cbf1b9 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
@@ -49,7 +49,7 @@
 } else if (o instanceof JSONArray) {
 return append(sb, (JSONArray) o, indent);
 } else if (o instanceof String) {
-return quote(sb, (String) o);
+return quoteAndEscape(sb, (String) o);
 } else if (JSONObject.NULL.equals(o) || o instanceof Number || o 
instanceof Boolean) {
 return sb.append(String.valueOf(o));
 }
@@ -102,10 +102,11 @@
 }
 
 public static String quoteAndEscape(String str) {
-StringBuilder sb = new StringBuilder();
-sb.append('"');
-escape(sb, str);
-return sb.append('"').toString();
+return quoteAndEscape(new StringBuilder(), str).toString();
+}
+
+private static StringBuilder quoteAndEscape(StringBuilder sb, String str) {
+return escape(sb.append('"'), str).append('"');
 }
 
 public static String escape(String str) {

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1271
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If68c1c4606501dbd205e67d6a73f4086a8f0b793
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 12:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java:

Line 190: if (annotation != null && !((Boolean) annotation)) {
why that is moved out from OperatorPropertiesUtil?
Only called here?


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

Line 668: //Get Variables used by afterSelectRefs that were created before 
the datasource
I'm not sure if I understand well how this method is used.

But from the name, as far as I understand, retainInputs is not entirely that 
the variables will be used later, but also because of the left-outer join 
semantics?  It means "no matter there is a match or not in the index, output 
the input".

If it's an index left outer join, you have to anyway retain the input so that 
the semantics is correct.


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java:

Line 80: ILogicalExpression[] getConstantExpressions();
Why non-pure requires the addition of getConstantExpressions()?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add Checkpoint Test

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Checkpoint Test
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/894/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Checkpoint Test

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Checkpoint Test
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/894/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Checkpoint Test

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1270

Change subject: Add Checkpoint Test
..

Add Checkpoint Test

This change adds a unit test case which validates that
checkpoints do not delete log files that are still required
for recovery, and delete those that are no longer needed.

Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
---
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixTransactionProperties.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
6 files changed, 282 insertions(+), 44 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/70/1270/1

diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
index a548b3a..bce556d 100644
--- 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
@@ -32,11 +32,8 @@
 import org.apache.asterix.common.context.TransactionSubsystemProvider;
 import 
org.apache.asterix.common.dataflow.AsterixLSMInsertDeleteOperatorNodePushable;
 import 
org.apache.asterix.common.dataflow.AsterixLSMTreeInsertDeleteOperatorDescriptor;
-import org.apache.asterix.common.exceptions.ACIDException;
-import org.apache.asterix.common.exceptions.AsterixException;
 import 
org.apache.asterix.common.ioopcallbacks.LSMBTreeIOOperationCallbackFactory;
 import org.apache.asterix.common.transactions.IRecoveryManager.ResourceType;
-import org.apache.asterix.runtime.util.AsterixRuntimeComponentsProvider;
 import org.apache.asterix.common.transactions.ITransactionManager;
 import org.apache.asterix.formats.nontagged.AqlBinaryComparatorFactoryProvider;
 import org.apache.asterix.formats.nontagged.AqlSerializerDeserializerProvider;
@@ -46,6 +43,7 @@
 import org.apache.asterix.om.types.ARecordType;
 import org.apache.asterix.om.types.IAType;
 import org.apache.asterix.runtime.formats.NonTaggedDataFormat;
+import org.apache.asterix.runtime.util.AsterixRuntimeComponentsProvider;
 import org.apache.asterix.test.runtime.ExecutionTestUtil;
 import 
org.apache.asterix.transaction.management.opcallbacks.PrimaryIndexModificationOperationCallbackFactory;
 import 
org.apache.asterix.transaction.management.opcallbacks.PrimaryIndexOperationTrackerProvider;
@@ -67,7 +65,6 @@
 import org.apache.hyracks.api.dataflow.value.ITypeTraits;
 import org.apache.hyracks.api.dataflow.value.RecordDescriptor;
 import org.apache.hyracks.api.exceptions.HyracksDataException;
-import org.apache.hyracks.api.exceptions.HyracksException;
 import org.apache.hyracks.api.job.JobId;
 import org.apache.hyracks.api.job.JobSpecification;
 import org.apache.hyracks.api.util.HyracksConstants;
@@ -115,8 +112,12 @@
 private JobId jobId;
 private long jobCounter = 0L;
 private IHyracksJobletContext jobletCtx;
+private final String testConfigFileName;
+private final boolean runHDFS;
 
-public TestNodeController() throws AsterixException, HyracksException, 
ACIDException {
+public TestNodeController(String testConfigFileName, boolean runHDFS) {
+this.testConfigFileName = testConfigFileName;
+this.runHDFS = runHDFS;
 }
 
 public void init() throws Exception {
@@ -125,7 +126,9 @@
 outdir.mkdirs();
 // remove library directory
 TestLibrarian.removeLibraryDir();
-ExecutionTestUtil.setUp(cleanupOnStart);
+ExecutionTestUtil.setUp(cleanupOnStart,
+testConfigFileName == null ? TEST_CONFIG_FILE_NAME : 
testConfigFileName,
+ExecutionTestUtil.integrationUtil, runHDFS);
 } catch (Throwable th) {
 th.printStackTrace();
 throw th;
@@ -299,7 +302,7 @@
 PrimaryIndexInfo primaryIndexInfo = new PrimaryIndexInfo(dataset, 
primaryKeyTypes, recordType, metaType,
 mergePolicyFactory, mergePolicyProperties, filterFields);
 TreeIndexCreateOperatorDescriptor indexOpDesc = 
getIndexCreateOpDesc(primaryIndexInfo);
-return getPrimaryIndexDataflowHelper(createTestContext(), 
primaryIndexInfo, indexOpDesc);
+return getPrimaryIndexDataflowHelper(createTestContext(true), 
primaryIndexInfo, indexOpDesc);
 }
 
 public void 

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 19: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/893/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: Introduce XML Reader & Parser

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Introduce XML Reader & Parser
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2982/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Introduce XML Reader & Parser

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1269

to look at the new patch set (#4).

Change subject: Introduce XML Reader & Parser
..

Introduce XML Reader & Parser

1. Add a record reader for XML document.
2. Add xml parser based on XML to JSON and ADMParser.
3. Fix ASTERIX-1690: deadlock between close() and take() in FileSystemWatcher

Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
---
A asterixdb/asterix-app/data/xml/ER.xml
A asterixdb/asterix-app/data/xml/HSA.xml
A asterixdb/asterix-app/data/xml/STA.xml
A asterixdb/asterix-app/data/xml/small_ER.xml
M asterixdb/asterix-app/src/test/resources/runtimets/only.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/xml-adaptor/xml-adaptor.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/xml-adaptor/xml-adaptor.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/xml-adaptor/xml-adaptor.3.sleep.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/xml-adaptor/xml-adaptor.4.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/xml-adaptor/xml-adaptor.5.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/xml-adaptor/xml-adaptor.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/XMLFileRecordReader.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/XMLFileParser.java
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/XMLFileParserFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/StreamRecordReaderProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
21 files changed, 529 insertions(+), 34 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/69/1269/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 19:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/893/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-1691) intra-module dependencies should be consumed via maven artifacts

[Michael Blow (JIRA)]

Michael Blow created ASTERIXDB-1691:
---

 Summary: intra-module dependencies should be consumed via maven 
artifacts
 Key: ASTERIXDB-1691
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1691
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: AsterixDB
Reporter: Michael Blow
Assignee: Abdullah Alamoudi


The asterix-app tests fail if run only with 'test' target at the top level.  
This is due to the execution tests consuming test-lib-zip-binaryassembly.zip 
directly instead of by way of maven dependency.

Asterix-app should be updated to consume test-lib-zip-binaryassembly.zip as a 
maven dependency, and also to stage in 'target/'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/20/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/19/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/18/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

[Steven Jacobs (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#3).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
R asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.2.ddl.aql
R 

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 19:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2981/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Wenhai Li 
Gerrit-HasComments: No

Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...

[Wenhai Li (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1076

to look at the new patch set (#19).

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
..

Applied the multiway fuzzyjoin based on the prefix-based join and the 
selectFuzzyJoin testCases.

- Enabled the fuzzyjoin rule.
- Introduced six existing rules in FuzzyJoinRuleCollections after applied the 
fuzzyjoin rule.
  - Extract the common expressions in the star-like multiple fuzzyjoin 
substitutions of ~=.
  - Translate the generated subplan from the ~= substitution into join in case 
of nested schemas.
  - Remove the unused assign/vars after the new select-push-down and 
inlineSubplanInpurForNestedTupl
eSource are applied.
- Add three new optimization Cases for multi-fuzzyjoin.
- Add a running Cases for select-fuzzyjoin.
- Change the inverted-based fuzzyjoin onto prefix-based join due to the 
efficiency considerations.

Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/FuzzyUtils.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
A asterixdb/asterix-app/data/dblp-small/csx-small-multi-id.txt
A asterixdb/asterix-app/data/dblp-small/dblp-small-multi-id.txt
A asterixdb/asterix-app/data/pub-small/csx-small-multi-id.txt
A asterixdb/asterix-app/data/pub-small/dblp-small-multi-id.txt
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-hybrid.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-selflink.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-simple.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-star.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx-hybrid.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx-selflink.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx-simple.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/fj-dblp-csx-star.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join-noeqjoin/ngram-jaccard-inline.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join-noeqjoin/word-jaccard-inline.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/issue741.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/leftouterjoin-probe-pidx-with-join-jaccard-check-idx_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-fuzzyeq-jaccard_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard-check_04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/ngram-jaccard_04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-fuzzyeq-jaccard_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-fuzzyeq-jaccard_02.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-fuzzyeq-jaccard_03.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard-check-after-btree-access.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard-check_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inverted-index-join/word-jaccard-check_02.plan
M 

Change in asterixdb[master]: Introduce XML Adaptor & Parser

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Introduce XML Adaptor & Parser
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/892/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Introduce XML Adaptor & Parser

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Introduce XML Adaptor & Parser
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2980/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No