date:20171009

[jira] [Commented] (ASTERIXDB-2121) Assertion Errors are Suppressed during Hyracks Job Execution

2017-10-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198193#comment-16198193
 ] 

ASF subversion and git services commented on ASTERIXDB-2121:


Commit 64965900c4fc4a33fe97bc1db6fa9ba946621b31 in asterixdb's branch 
refs/heads/master from [~luochen01]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=6496590 ]

[ASTERIXDB-2121][HYR] Handle Throwables during job execution

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Currently, only exceptions are handled and logged during Hyracks job
execution. However, throwables, such as errors, are not handled and
simply ignored saliently. This patch handles all throwabls during job
execution.

Change-Id: Ibbe09d5231fe2bdfa12d834bb1a6adb46b355a48
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2051
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 


> Assertion Errors are Suppressed during Hyracks Job Execution
> 
>
> Key: ASTERIXDB-2121
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2121
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: HYR - Hyracks
>Reporter: Chen Luo
>Assignee: Chen Luo
>
> Currently during the execution of Hyracks jobs, only Exceptions are logged, 
> while other Throwable, such as Assertion Errors, are missed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2121][HYR] Handle Throwables during job execution

2017-10-09 Thread Luo Chen (Code Review)

Luo Chen has submitted this change and it was merged.

Change subject: [ASTERIXDB-2121][HYR] Handle Throwables during job execution
..


[ASTERIXDB-2121][HYR] Handle Throwables during job execution

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Currently, only exceptions are handled and logged during Hyracks job
execution. However, throwables, such as errors, are not handled and
simply ignored saliently. This patch handles all throwabls during job
execution.

Change-Id: Ibbe09d5231fe2bdfa12d834bb1a6adb46b355a48
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2051
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/HyracksThreadFactory.java
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; ; Verified
  Michael Blow: Looks good to me, approved



diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/HyracksThreadFactory.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/HyracksThreadFactory.java
index 52631bf..c9ef4d0 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/HyracksThreadFactory.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/HyracksThreadFactory.java
@@ -18,12 +18,17 @@
  */
 package org.apache.hyracks.control.common.utils;
 
+import java.lang.Thread.UncaughtExceptionHandler;
 import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.atomic.AtomicInteger;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 public class HyracksThreadFactory implements ThreadFactory {
 private final String identifier;
 private final AtomicInteger threadId = new AtomicInteger();
+
+private static final Logger LOGGER = 
Logger.getLogger(HyracksThreadFactory.class.getName());
 
 public HyracksThreadFactory(String identifier) {
 this.identifier = identifier;
@@ -33,6 +38,12 @@
 public Thread newThread(Runnable runnable) {
 Thread t = new Thread(runnable, "Executor-" + 
threadId.incrementAndGet() + ":" + identifier);
 t.setDaemon(true);
+t.setUncaughtExceptionHandler(new UncaughtExceptionHandler() {
+@Override
+public void uncaughtException(Thread t, Throwable e) {
+LOGGER.log(Level.SEVERE, "Uncaught exception by " + 
t.getName(), e);
+}
+});
 return t;
 }
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2051
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbe09d5231fe2bdfa12d834bb1a6adb46b355a48
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4225/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4224/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4223/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4225/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2065/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5223/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1504/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1841/
 (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1164/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1782/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4224/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6719/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Michael Blow (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2061

to look at the new patch set (#2).

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..

[NO ISSUE][*DB][API] Emit exception text on diag eval error

Failure to evaluate diagnostic info generates log & emits exception
string as value, instead of generating 500 & displaying no diag info

Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
1 file changed, 14 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/61/2061/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1882/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1176/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1174/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4223/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4222/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6718/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2064/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1503/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1173/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1881/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Michael Blow (Code Review)

Hello Jenkins, Dmitry Lychagin,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2060

to look at the new patch set (#2).

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..

[ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

- Generate & send NC heartbeats in their own thread to prevent starvation
/ scheduling issues
- Fix retries on IPC connections
- Don't spin on heartbeat send failure

Change-Id: Ieae21b1596013a699f27975fb21894244c536395
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCSystem.java
7 files changed, 80 insertions(+), 57 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/60/2060/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1840/
 (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5222/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1781/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1175/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1163/ 
(1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1914/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4221/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3: Contrib-1

Analytics Compatibility Tests Failed Build 2730
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1914/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4: Contrib-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1913/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1913/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4222/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2063/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1: Contrib-1

Analytics Compatibility Tests Failed Build 2729
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Murtadha Hubail (Code Review)

Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1: -Code-Review

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1880/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1839/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Murtadha Hubail (Code Review)

Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1174/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1780/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1162/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6717/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5221/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1172/ 
(1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1502/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

2017-10-09 Thread Ildar Absalyamov (Code Review)

Hello Luo Chen, Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2014

to look at the new patch set (#24).

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..

[NO ISSUE][STO][IDX] LSM storage cleanup

- user model changes: no
- storage format changes: no
- interface changes: yes

- Replaced component lifecycle-related fabric methods in AbstractLSMIndex
  with direct method calls of lsmComponent functions.
- Extracted common lifecycle-related functionality from index-specific
  disk/memory lsmComponents to interfaces.
- Introduced composable disk component bulkloader design which assembles the
  proper bulkload pipeline from individual elements populating lsmFilters,
  bloomFilters, buddyBTrees\deletedKeysBTrees, bTress\rTrees\invIndexes.
- Changed methods to return index-specific versions of objects (accessors,
  components, index instances) to avoid nasty downcasting.

Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallback.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java
D 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeMemoryComponent.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeOpContext.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponent.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyAbstractCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponent.java
D 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponentBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyMemoryComponent.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBuddyBTreeMergeCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
M

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4221/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1171/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1501/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1838/
 (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1173/
 (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1779/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5220/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6716/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1879/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1161/ 
(1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Ahmed Eldawy (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2056

to look at the new patch set (#4).

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..

Standard geometry support in AsterixDB through Esri Geometry API.

The following commits from your working branch will be included:

commit 45cc86f21ce214f6edc4fbc5885aaac2dfa1ec8f
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:43:35 2017 -0700

Reverted an import change that is not necessary

commit fa8066d6467839a8f6082c71e2a83048f5560252
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:29:23 2017 -0700

Reverted a minor unnecessary change

commit 73b05382fe34b334e7b334142a8ab59f3304925c
Author: Ahmed Eldawy 
Date:   Wed Oct 4 16:10:59 2017 -0700

Removed some redundant files

commit 344157c4780f156e34d5201ad8d71aee35aa9957
Merge: 9ea90ca ca8cd25
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:54:16 2017 -0700

Merged with the latest work from Riyafa/geometry

commit 9ea90caaeaf5953f43752a585b0255f34bfe8722
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:51:26 2017 -0700

Removed the source code of Esri Geometry API and rely on Maven

commit 2d7e6a9109c75f377d601dafde2ab9db13911365
Merge: 7204fcc b2e50b7
Author: Ahmed Eldawy 
Date:   Wed Oct 4 13:39:20 2017 -0700

Merged with the master and did minor refactors

commit 7204fcc3304be79df6e47c47215751a09b70a985
Author: Ahmed Eldawy 
Date:   Wed Oct 4 11:27:49 2017 -0700

Reverted a change that collapses imports since it is irrelevant to geometry 
functions

commit ca8cd2502bb0e9abfc6276dc5c286cf3a984c701
Author: riyafa 
Date:   Sun Sep 3 21:25:56 2017 +0530

Use the newly released esri api as a maven dependencyc

commit ef295946d8c19bcdd18a65b72efa5e43662a3b40
Author: riyafa 
Date:   Sat Aug 26 09:00:48 2017 +0530

Update pom files

commit 9e8c42e2b462a880f5a0210cee1df61f45a4d190
Author: riyafa 
Date:   Mon Aug 21 20:48:09 2017 +0530

Add test cases

commit 8467da56445787f218035e789490521690a7dd47
Author: riyafa 
Date:   Mon Aug 21 20:47:46 2017 +0530

Add test cases

commit d802d527520fb5a5727cb3755cd3d359e26e16b6
Author: riyafa 
Date:   Thu Aug 17 20:46:29 2017 +0530

add function st_polygonize

commit 454953b68b9b0fd2ed55714f7832857054af8a83
Author: riyafa 
Date:   Wed Aug 16 19:17:07 2017 +0530

Changes to get things working

commit ee29d8142a11132c38c5c4a54fffb2b295045952
Author: Till Westmann 
Date:   Fri Jul 28 16:49:31 2017 -0700

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing functionality and functions for
datatype 'geometry'
interface changes: no

details:
- temporarily adds a new module "esri-geometry-api" which is taken from
  
https://github.com/Esri/geometry-api-java/commit/b0bc20e9f3a8e6ea880dbfefebeb54d2552b97fe
  It should be removed and retrieved from a maven repository instead as
  soon as Esri releases a version of the API that does not depend on
  the JSON license

commit 10e2c9b8d18926d8152dca42e37512049abd9fca
Author: riyafa 
Date:   Fri Aug 25 14:31:08 2017 +0530

Ignore dependency change

commit f57004205bebb8dc3efd8102d5f8db2dfac94701
Author: riyafa 
Date:   Tue Aug 22 19:56:00 2017 +0530

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing  functionality and functions for 
datatype 'geometry'
interface changes: no

Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/analysis.12.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.17.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/primitive.4.query.sqlpp
A

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2062/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1912/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1912/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4219/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4220/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4218/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2061/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1911/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1911/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1878/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1837/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6715/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5219/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1172/
 (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1170/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1778/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1160/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Standard geometry support in AsterixDB through Esri Geometry...

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Standard geometry support in AsterixDB through Esri Geometry 
API.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1500/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4219/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2060/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1877/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1836/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1171/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1169/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5218/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6714/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Michael Blow (Code Review)

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2061

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..

[NO ISSUE][*DB][API] Emit exception text on diag eval error

Failure to evaluate diagnostic info generates log & emits exception
string as value, instead of generating 500 & displaying no diag info

Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/61/2061/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
index 3fe591f..b828b32 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
@@ -128,10 +128,15 @@
 }
 
 protected Map resolveFutures(Map futureMap)
-throws ExecutionException, InterruptedException {
+throws InterruptedException {
 Map result = new HashMap<>();
 for (Map.Entry entry : futureMap.entrySet()) 
{
-result.put(entry.getKey(), entry.getValue().get());
+try {
+result.put(entry.getKey(), entry.getValue().get());
+} catch (ExecutionException e) {
+LOGGER.log(Level.WARNING, "unexpected exception obtaining 
value for " + entry.getKey(), e);
+result.put(entry.getKey(), new TextNode("unexpected error, see 
logs for details: " + e));
+}
 }
 return result;
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1499/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1777/ (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][*DB][API] Emit exception text on diag eval error

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB][API] Emit exception text on diag eval error
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1159/ 
(1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2061
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4997c57ec3aca4b17c975098865486a6cd72531
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4218/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2059/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Michael Blow (Code Review)

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2060

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..

[ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

Generate & send NC heartbeats in their own thread to prevent starvation
/ scheduling issues

Change-Id: Ieae21b1596013a699f27975fb21894244c536395
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
1 file changed, 22 insertions(+), 17 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/60/2060/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
index 350343b..c34abc8 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
@@ -27,7 +27,6 @@
 import java.lang.management.OperatingSystemMXBean;
 import java.lang.management.RuntimeMXBean;
 import java.lang.management.ThreadMXBean;
-import java.lang.reflect.Field;
 import java.net.InetSocketAddress;
 import java.util.Arrays;
 import java.util.Hashtable;
@@ -133,7 +132,7 @@
 
 private NodeParameters nodeParameters;
 
-private HeartbeatTask heartbeatTask;
+private Thread heartbeatThread;
 
 private final ServerContext serverCtx;
 
@@ -308,15 +307,12 @@
 
 workQueue.start();
 
-heartbeatTask = new HeartbeatTask(ccs);
+// Start heartbeat generator.
+heartbeatThread = new Thread(new HeartbeatTask(ccs, 
nodeParameters.getHeartbeatPeriod()), id + "-Heartbeat");
+heartbeatThread.setPriority(Thread.MAX_PRIORITY);
+heartbeatThread.setDaemon(true);
+heartbeatThread.start();
 
-// Use reflection to set the priority of the timer thread.
-Field threadField = timer.getClass().getDeclaredField("thread");
-threadField.setAccessible(true);
-Thread timerThread = (Thread) threadField.get(timer); // The internal 
timer thread of the Timer object.
-timerThread.setPriority(Thread.MAX_PRIORITY);
-// Schedule heartbeat generator.
-timer.schedule(heartbeatTask, 0, nodeParameters.getHeartbeatPeriod());
 // Schedule tracing a human-readable datetime
 timer.schedule(new TraceCurrentTimeTask(serviceCtx.getTracer()), 0, 
6);
 
@@ -401,7 +397,8 @@
  * Stop heartbeat after NC has stopped to avoid false node failure 
detection
  * on CC if an NC takes a long time to stop.
  */
-heartbeatTask.cancel();
+heartbeatThread.interrupt();
+heartbeatThread.join();
 LOGGER.log(Level.INFO, "Stopped NodeControllerService");
 } else {
 LOGGER.log(Level.SEVERE, "Duplicate shutdown call; original: " + 
Arrays.toString(shutdownCallStack),
@@ -478,17 +475,15 @@
 return workQueue;
 }
 
-public ThreadMXBean getThreadMXBean() {
-return threadMXBean;
-}
-
-private class HeartbeatTask extends TimerTask {
+private class HeartbeatTask implements Runnable {
 private IClusterController cc;
+private final int heartbeatPeriod;
 
 private final HeartbeatData hbData;
 
-public HeartbeatTask(IClusterController cc) {
+HeartbeatTask(IClusterController cc, int heartbeatPeriod) {
 this.cc = cc;
+this.heartbeatPeriod = heartbeatPeriod;
 hbData = new HeartbeatData();
 hbData.gcCollectionCounts = new long[gcMXBeans.size()];
 hbData.gcCollectionTimes = new long[gcMXBeans.size()];
@@ -496,6 +491,13 @@
 
 @Override
 public void run() {
+while (!Thread.currentThread().isInterrupted()) {
+execute();
+}
+LOGGER.log(Level.INFO, "Heartbeat thread interrupted; shutting 
down");
+}
+
+private void execute() {
 MemoryUsage heapUsage = memoryMXBean.getHeapMemoryUsage();
 hbData.heapInitSize = heapUsage.getInit();
 hbData.heapUsedSize = heapUsage.getUsed();
@@ -541,6 +543,9 @@
 
 try {
 cc.nodeHeartbeat(id, hbData);
+Thread.sleep(heartbeatPeriod);
+} catch (InterruptedException e) {
+Thread.currentThread().interrupt();
 } catch (Exception e) {
 LOGGER.log(Level.SEVERE, "Exception sending heartbeat", e);
 }

-- 
To view, visit

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1168/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

2017-10-09 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1076][HYR] Generate heartbeats in their own thread
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6713/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2060
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae21b1596013a699f27975fb21894244c536395
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

1 2 >

1 - 100 of 123 matches

Mail list logo