Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2: Contrib-1

Analytics Compatibility Tests Failed Build 2784
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1966/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1966/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2141/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-18 Thread Luo Chen (Code Review) 
Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

> Cool stuff, do you see improved sort speeds with more memory with
 > this improvement?

 > Cool stuff, do you see improved sort speeds with more memory with
 > this improvement?

Hi Ian, some experiment results can be found at 
https://drive.google.com/file/d/0B43D7FK4h0PiM0dWdXQzeDhyLXM/view?usp=sharing.

But this only fixes the merge phase. The sort phase is still not cache/memory 
efficient, which is a future project to improve...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

[jira] [Resolved] (ASTERIXDB-2135) NPE in LSMBTreePointSearchCursor on Failure

2017-10-18 Thread Murtadha Hubail (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Murtadha Hubail resolved ASTERIXDB-2135.

Resolution: Fixed

> NPE in LSMBTreePointSearchCursor on Failure
> ---
>
> Key: ASTERIXDB-2135
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2135
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: IDX - Indexes
>Reporter: Murtadha Hubail
>Assignee: Murtadha Hubail
>
> If a failure happens before LSMBTreePointSearchCursor.hasNext is called to 
> initialize the search cursor, LSMBTreePointSearchCursor.close is called as 
> part of the pipeline failure and leads to NPE.
> Stacktrace:
> {code:java}
> Caused by: java.lang.NullPointerException at 
> org.apache.hyracks.storage.am.lsm.btree.impls.LSMBTreePointSearchCursor.close(LSMBTreePointSearchCursor.java:218)
>   at 
> org.apache.hyracks.storage.am.lsm.btree.impls.LSMBTreeSearchCursor.close(LSMBTreeSearchCursor.java:77)
>   at 
> org.apache.asterix.runtime.operators.LSMPrimaryUpsertOperatorNodePushable.close(LSMPrimaryUpsertOperatorNodePushable.java:360)
>   at 
> org.apache.asterix.external.feed.dataflow.SyncFeedRuntimeInputHandler.close(SyncFeedRuntimeInputHandler.java:64)
>   at 
> org.apache.asterix.external.operators.FeedMetaStoreNodePushable.close(FeedMetaStoreNodePushable.java:155)
>   at org.apache.hyracks.control.nc.Task.pushFrames(Task.java:409)
>   at org.apache.hyracks.control.nc.Task.run(Task.java:323)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ASTERIXDB-2135) NPE in LSMBTreePointSearchCursor on Failure

2017-10-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209940#comment-16209940
 ] 

ASF subversion and git services commented on ASTERIXDB-2135:


Commit 89e6a93277205a9dbc76c18e249919a745d224d2 in asterixdb's branch 
refs/heads/master from [~mhubail]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=89e6a93 ]

[ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Prevent NPE on LSMBTreePointSearchCursor.close

Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2081
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Ian Maxon 


> NPE in LSMBTreePointSearchCursor on Failure
> ---
>
> Key: ASTERIXDB-2135
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2135
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: IDX - Indexes
>Reporter: Murtadha Hubail
>Assignee: Murtadha Hubail
>
> If a failure happens before LSMBTreePointSearchCursor.hasNext is called to 
> initialize the search cursor, LSMBTreePointSearchCursor.close is called as 
> part of the pipeline failure and leads to NPE.
> Stacktrace:
> {code:java}
> Caused by: java.lang.NullPointerException at 
> org.apache.hyracks.storage.am.lsm.btree.impls.LSMBTreePointSearchCursor.close(LSMBTreePointSearchCursor.java:218)
>   at 
> org.apache.hyracks.storage.am.lsm.btree.impls.LSMBTreeSearchCursor.close(LSMBTreeSearchCursor.java:77)
>   at 
> org.apache.asterix.runtime.operators.LSMPrimaryUpsertOperatorNodePushable.close(LSMPrimaryUpsertOperatorNodePushable.java:360)
>   at 
> org.apache.asterix.external.feed.dataflow.SyncFeedRuntimeInputHandler.close(SyncFeedRuntimeInputHandler.java:64)
>   at 
> org.apache.asterix.external.operators.FeedMetaStoreNodePushable.close(FeedMetaStoreNodePushable.java:155)
>   at org.apache.hyracks.control.nc.Task.pushFrames(Task.java:409)
>   at org.apache.hyracks.control.nc.Task.run(Task.java:323)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Murtadha Hubail (Code Review) 
Murtadha Hubail has submitted this change and it was merged.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


[ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Prevent NPE on LSMBTreePointSearchCursor.close

Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2081
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Ian Maxon 
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
1 file changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; ; Verified
  Ian Maxon: Looks good to me, approved

Objections:
  Anon. E. Moose #1000171: 



diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
index c178b51..0f7aa38 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
@@ -214,9 +214,7 @@
 public void close() throws HyracksDataException {
 if (lsmHarness != null) {
 try {
-for (int i = 0; i < rangeCursors.length; i++) {
-rangeCursors[i].close();
-}
+closeCursors();
 rangeCursors = null;
 } finally {
 lsmHarness.endSearch(opCtx);
@@ -265,4 +263,13 @@
 return false;
 }
 
+private void closeCursors() throws HyracksDataException {
+if (rangeCursors != null) {
+for (int i = 0; i < rangeCursors.length; ++i) {
+if (rangeCursors[i] != null) {
+rangeCursors[i].close();
+}
+}
+}
+}
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4304/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1252/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1859/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2140/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Xikui Wang (Code Review) 
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2082

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..

[ASTERIXDB-2136][FUN] Prevent blind result write in external UDF

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Current the result from UDF doesn't have type check. It's possible to
write data into result frame with a different datatype. This will cause
unpredicted behavior when reading the data. Also, to keep things
simpler, when return data type is not valid, we throw exception instead
of return null.

Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.2.lib.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.3.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.4.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_sqlpp.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/AddHashTagsFunction.java
11 files changed, 157 insertions(+), 13 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/82/2082/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5300/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1580/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-2136) External UDF writes records without checking datatype

2017-10-18 Thread Xikui Wang (JIRA) 
Xikui Wang created ASTERIXDB-2136:
-

 Summary: External UDF writes records without checking datatype
 Key: ASTERIXDB-2136
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2136
 Project: Apache AsterixDB
  Issue Type: Bug
Reporter: Xikui Wang
Assignee: Xikui Wang


The result returned by external UDF is not verified by datatype. If the record 
type doesn't conform to the configuration, execution result will be written 
successfully, but it cannot be accessed by record reader due to the record type 
mismatch. 

Also, we intend to return NULL for an invalid input parameter, but it's not 
clear when the return type is a record, how to set the record to be 
MISSING/NULL. This will also cause a reading exception. For simplicity, we will 
throw an exception when UDF cannot produce the expected result.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6796/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1956/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1920/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1251/
 (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2136][FUN] Prevent blind result write in external...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1243/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful Build 2783
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4303/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1965/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1965/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4303/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2139/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1858/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5299/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1251/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1242/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Xikui Wang (Code Review) 
Xikui Wang has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2082

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..

[ISSUE PENDING][FUN] Prevent blind result write in external UDF

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Current the result from UDF doesn't have type check. It's possible to
write data into result frame with a different datatype. This will cause
unpredicted behavior when reading the data. Also, to keep things
simpler, when return data type is not valid, we throw exception instead
of return null.

Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.2.lib.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.3.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.4.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_sqlpp.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunctionProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/AddHashTagsFunction.java
11 files changed, 157 insertions(+), 13 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/82/2082/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.1.ddl.sqlpp
new file mode 100644
index 000..e375558
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.1.ddl.sqlpp
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+drop dataverse externallibtest if exists;
+create dataverse externallibtest;
+use externallibtest;
+
+create type TwitterUserType as closed {
+ screen_name: string,
+ language: string,
+ friends_count: int32,
+ status_count: int32,
+ name: string,
+ followers_count: int32
+};
+
+create type Tweet as closed {
+ id: int64,
+ user: TwitterUserType,
+ latitude: double,
+ longitude: double,
+ message_text: string,
+ created_at: string,
+ country: string
+};
+
+create type ProcessedTweet if not exists as open {
+id: int64,
+user_name:string,
+location:point,
+created_at:string,
+message_text:string,
+country: string,
+topics: {{string}}
+};
+
+create dataset SyntheticTweets(Tweet) primary key id;
+
+create feed  SyntheticTweetFeed using stream
+(("duration"="1"),
+("stream-source"="org.apache.asterix.external.input.stream.factory.TwitterFirehoseStreamFactory"),
+("tps"="50"),
+("type-name"="Tweet"),
+("tput-duration"="1"),
+("dataverse-dataset"="feeds:SyntheticTweets"),
+("format"="adm"),
+("mode"="controlled"));
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.2.lib.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.2.lib.sqlpp
new file mode 100644
index 000..d1e0e87
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/return_invalid_type/return_invalid_type.2.lib.sqlpp
@@

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1579/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6795/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1919/
 (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1955/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ISSUE PENDING][FUN] Prevent blind result write in external UDF

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ISSUE PENDING][FUN] Prevent blind result write in external UDF
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1250/
 (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2082
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-18 Thread Ian Maxon (Code Review) 
Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Cool stuff, do you see improved sort speeds with more memory with this 
improvement?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Ian Maxon (Code Review) 
Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1: Contrib-1

Analytics Compatibility Tests Failed Build 2782
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4302/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1964/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1964/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4302/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1578/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2138/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1857/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1918/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1241/ 
(10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6794/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1250/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1249/
 (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1954/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Murtadha Hubail (Code Review) 
Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2081

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..

[ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Prevent NPE on LSMBTreePointSearchCursor.close

Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
1 file changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/81/2081/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
index c178b51..0f7aa38 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
@@ -214,9 +214,7 @@
 public void close() throws HyracksDataException {
 if (lsmHarness != null) {
 try {
-for (int i = 0; i < rangeCursors.length; i++) {
-rangeCursors[i].close();
-}
+closeCursors();
 rangeCursors = null;
 } finally {
 lsmHarness.endSearch(opCtx);
@@ -265,4 +263,13 @@
 return false;
 }
 
+private void closeCursors() throws HyracksDataException {
+if (rangeCursors != null) {
+for (int i = 0; i < rangeCursors.length; ++i) {
+if (rangeCursors[i] != null) {
+rangeCursors[i].close();
+}
+}
+}
+}
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail

Change in asterixdb[master]: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2135][IDX] Prevent NPE in LSMBTreePointSearchCursor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5298/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2081
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I062c1200d9c5a1a574a1ccdb32be0ac011406d92
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-2135) NPE in LSMBTreePointSearchCursor on Failure

2017-10-18 Thread Murtadha Hubail (JIRA) 
Murtadha Hubail created ASTERIXDB-2135:
--

 Summary: NPE in LSMBTreePointSearchCursor on Failure
 Key: ASTERIXDB-2135
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2135
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: IDX - Indexes
Reporter: Murtadha Hubail
Assignee: Murtadha Hubail


If a failure happens before LSMBTreePointSearchCursor.hasNext is called to 
initialize the search cursor, LSMBTreePointSearchCursor.close is called as part 
of the pipeline failure and leads to NPE.

Stacktrace:

{code:java}
Caused by: java.lang.NullPointerException at 
org.apache.hyracks.storage.am.lsm.btree.impls.LSMBTreePointSearchCursor.close(LSMBTreePointSearchCursor.java:218)
at 
org.apache.hyracks.storage.am.lsm.btree.impls.LSMBTreeSearchCursor.close(LSMBTreeSearchCursor.java:77)
at 
org.apache.asterix.runtime.operators.LSMPrimaryUpsertOperatorNodePushable.close(LSMPrimaryUpsertOperatorNodePushable.java:360)
at 
org.apache.asterix.external.feed.dataflow.SyncFeedRuntimeInputHandler.close(SyncFeedRuntimeInputHandler.java:64)
at 
org.apache.asterix.external.operators.FeedMetaStoreNodePushable.close(FeedMetaStoreNodePushable.java:155)
at org.apache.hyracks.control.nc.Task.pushFrames(Task.java:409)
at org.apache.hyracks.control.nc.Task.run(Task.java:323)

{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4301/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-2134) Remove AbstractFrameAppender.flush(IFrameWrite, ITrace, String, String, String)

2017-10-18 Thread Till (JIRA) 
Till created ASTERIXDB-2134:
---

 Summary: Remove AbstractFrameAppender.flush(IFrameWrite, ITrace, 
String, String, String)
 Key: ASTERIXDB-2134
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2134
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: RT - Runtime
Reporter: Till
Assignee: Till


Find a better way to allow for tracing without a separate method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4301/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTH] Appender flush call with tracing call normal...

2017-10-18 Thread Michael Blow (Code Review) 
Michael Blow has submitted this change and it was merged.

Change subject: [NO ISSUE][OTH] Appender flush call with tracing call normal 
flush
..


[NO ISSUE][OTH] Appender flush call with tracing call normal flush

- user model changes: no
- storage format changes: no
- interface changes: no

details:
- The flush with tracing now calls the normal flush. This enables
  sub appenders overriding the flush call to maintain correctness.

Change-Id: I3f649798fa4cac049f66cc3621acdb28b1c94694
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2080
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Till Westmann 
Integration-Tests: Jenkins 
---
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/AbstractFrameAppender.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/PartitionDataWriter.java
3 files changed, 28 insertions(+), 16 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified



diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
index b1c7ff3..56a45c6 100644
--- 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
@@ -49,6 +49,7 @@
 import 
org.apache.hyracks.dataflow.std.connectors.MToNPartitioningWithMessageConnectorDescriptor;
 import 
org.apache.hyracks.dataflow.std.connectors.PartitionWithMessageDataWriter;
 import org.apache.hyracks.test.support.TestUtils;
+import org.apache.hyracks.util.trace.ITracer;
 import org.junit.Assert;
 import org.junit.Test;
 import org.mockito.Mockito;
@@ -81,8 +82,9 @@
 BooleanSerializerDeserializer.INSTANCE, new 
UTF8StringSerializerDeserializer() };
 RecordDescriptor rDesc = new RecordDescriptor(serdes);
 TestPartitionWriterFactory partitionWriterFactory = new 
TestPartitionWriterFactory();
-IFrameWriter partitioner = connector.createPartitioner(ctx, rDesc, 
partitionWriterFactory,
-CURRENT_PRODUCER, NUMBER_OF_CONSUMERS, 
NUMBER_OF_CONSUMERS);
+PartitionWithMessageDataWriter partitioner =
+(PartitionWithMessageDataWriter) 
connector.createPartitioner(ctx, rDesc, partitionWriterFactory,
+CURRENT_PRODUCER, NUMBER_OF_CONSUMERS, 
NUMBER_OF_CONSUMERS);
 List recipients = new ArrayList<>();
 try {
 partitioner.open();
@@ -90,7 +92,7 @@
 for (IFrameWriter writer : 
partitionWriterFactory.getWriters().values()) {
 recipients.add((TestFrameWriter) writer);
 }
-partitioner.flush();
+partitioner.flush(ITracer.NONE, null, null, null);
 for (TestFrameWriter writer : recipients) {
 Assert.assertEquals(writer.nextFrameCount(), 1);
 fta.reset(writer.getLastFrame());
@@ -102,7 +104,7 @@
 message.getBuffer().clear();
 
message.getBuffer().put(MessagingFrameTupleAppender.ACK_REQ_FEED_MESSAGE);
 message.getBuffer().flip();
-partitioner.flush();
+partitioner.flush(ITracer.NONE, null, null, null);;
 for (TestFrameWriter writer : recipients) {
 Assert.assertEquals(writer.nextFrameCount(), 2);
 fta.reset(writer.getLastFrame());
@@ -115,7 +117,7 @@
 message.getBuffer().clear();
 
message.getBuffer().put(MessagingFrameTupleAppender.NULL_FEED_MESSAGE);
 message.getBuffer().flip();
-partitioner.flush();
+partitioner.flush(ITracer.NONE, null, null, null);;
 for (TestFrameWriter writer : recipients) {
 Assert.assertEquals(writer.nextFrameCount(), 3);
 fta.reset(writer.getLastFrame());
@@ -159,15 +161,16 @@
 BooleanSerializerDeserializer.INSTANCE, new 
UTF8StringSerializerDeserializer() };
 RecordDescriptor rDesc = new RecordDescriptor(serdes);
 TestPartitionWriterFactory partitionWriterFactory = new 
TestPartitionWriterFactory();
-

Change in asterixdb[master]: [NO ISSUE][OTH] Appender flush call with tracing call normal...

2017-10-18 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][OTH] Appender flush call with tracing call normal 
flush
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful Build 2781
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2080
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f649798fa4cac049f66cc3621acdb28b1c94694
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTH] Appender flush call with tracing call normal...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Appender flush call with tracing call normal 
flush
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4300/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2080
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f649798fa4cac049f66cc3621acdb28b1c94694
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes

2017-10-18 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
..


Patch Set 27: Contrib+1

Analytics Compatibility Tests Successful Build 2780
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2025
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d
Gerrit-PatchSet: 27
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTH] Appender flush call with tracing call normal...

2017-10-18 Thread Till Westmann (Code Review) 
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][OTH] Appender flush call with tracing call normal 
flush
..


Patch Set 2: Code-Review+2

This works to fix the issue. But please file an issue to remove the flush 
method with the ITracer parameter. We need to find a more generic solution for 
this.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2080
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f649798fa4cac049f66cc3621acdb28b1c94694
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No