Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1: Contrib+2

Analytics Compatibility Tests Successful Build 2993
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4659/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1: Contrib+2

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2174/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2174/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4659/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7180/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2319/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1962/ 
(9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5682/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2297/
 (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1640/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2508/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1628/ 
(5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/827/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2255/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2165

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..

[NO ISSUE][TX] Make TxnLogFile Close Idempotent

- user model changes: no
- storage format changes: no
- interface changes: yes
  Renamed ILogReader.initializeScan to setPosition and added
  javadocs.

Details:
Currently there is an explicit check that the file channel
of a TxnLogFile is open before closing it. However, the
channel could be closed due to interrupts and therefore
we should remove the explicit check and always try to close
it. However, we should always decrement the TxnLogFile
references counter even if the channel is not open since
that TxnLogFile is not accessed anymore.

Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogReader.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
4 files changed, 47 insertions(+), 47 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/65/2165/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
index 7bc5697..19966fe 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
@@ -201,7 +201,7 @@
 jobId2WinnerEntitiesMap = new HashMap<>();
 //set log reader to the lowWaterMarkLsn
 ILogRecord logRecord;
-logReader.initializeScan(lowWaterMarkLSN);
+logReader.setPosition(lowWaterMarkLSN);
 logRecord = logReader.next();
 while (logRecord != null) {
 if (IS_DEBUG_MODE) {
@@ -300,7 +300,7 @@
 
 ILogRecord logRecord = null;
 try {
-logReader.initializeScan(lowWaterMarkLSN);
+logReader.setPosition(lowWaterMarkLSN);
 logRecord = logReader.next();
 while (logRecord != null) {
 if (IS_DEBUG_MODE) {
@@ -540,7 +540,7 @@
 Set activePartitions = 
localResourceRepository.getActivePartitions();
 ILogReader logReader = logMgr.getLogReader(false);
 try {
-logReader.initializeScan(firstLSN);
+logReader.setPosition(firstLSN);
 ILogRecord logRecord = null;
 while (currentLSN < lastLSN) {
 logRecord = logReader.next();
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogReader.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogReader.java
index da188e3..8539e2b 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogReader.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogReader.java
@@ -18,18 +18,34 @@
  */
 package org.apache.asterix.common.transactions;
 
-import org.apache.asterix.common.exceptions.ACIDException;
-
 public interface ILogReader {
 
-public void initializeScan(long beginLSN) throws ACIDException;
+/**
+ * Sets the log reader position at log sequence number with value {@code 
lsn}.
+ *
+ * @param lsn
+ */
+void setPosition(long lsn);
 
-//for scanning
-public ILogRecord next() throws ACIDException;
+/**
+ * Reads and returns the log record located at the log reader current 
position. After reading the log record,
+ * the log reader position is incremented by the size of the read log.
+ *
+ * @return the log record
+ */
+ILogRecord next();
 
-//for random reading
-public ILogRecord read(long readLSN) throws ACIDException;
+/**
+ * Reads and returns the log record with log sequence number {@code lsn}.
+ *
+ * @param lsn
+ * @return The log record
+ */
+ILogRecord read(long lsn);
 
-public void close() throws ACIDException;
+/**
+ * Closes the log reader and any resources used.
+ */
+void close();
 
-}
+}
\ No newline at end of file
diff --git 
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
 
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
index dd0a5c7..1cf7a50 100644
--- 
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
+++ 

Change in asterixdb[master]: [NO ISSUE][TX] Make TxnLogFile Close Idempotent

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1647/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2165
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2: Contrib+2

Analytics Compatibility Tests Successful Build 2992
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4658/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2: Contrib+2

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2173/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2173/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4658/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7179/ (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1627/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/826/
 (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1961/ 
(3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2296/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2254/ (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1646/
 (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5681/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2507/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2318/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP] Expression cleanup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1639/ 
(9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][COMP] Expression cleanup

[Dmitry Lychagin (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2164

to look at the new patch set (#2).

Change subject: [NO ISSUE][COMP] Expression cleanup
..

[NO ISSUE][COMP] Expression cleanup

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove unused IndependentSubquery expression
- Make all expressions extend AbstractExpression
- Cleanup QueryPrintVisitor and subclasses

Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/expression/FLWOGRExpression.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/expression/UnionExpr.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/visitor/AQLAstPrintVisitor.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/visitor/AQLFormatPrintVisitor.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/AbstractExpression.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/Expression.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/AbstractAccessor.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/IfExpr.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/ListConstructor.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/LiteralExpr.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/OperatorExpr.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/QuantifiedExpression.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/RecordConstructor.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/UnaryExpr.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/VariableExpr.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/QueryPrintVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/CaseExpression.java
D 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/IndependentSubquery.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/SelectExpression.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppInlineUdfsVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckDatasetOnlyResolutionVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSql92AggregateVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSubqueryVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/DeepCopyVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/FreeVariableVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppCloneAndSubstituteVariablesVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppFormatPrintVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppAstVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppExpressionScopingVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppSimpleExpressionVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/ISqlppVisitor.java
36 files changed, 39 insertions(+), 262 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/64/2164/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2164
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a
Gerrit-PatchSet: 2

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4657/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Analytics Compatibility Tests Successful Build 2991
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4657/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2172/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2: Code-Review+2 Integration-Tests+1 Verified+1

(1 comment)

Forwarding +2 after addressing formatting comment.

https://asterix-gerrit.ics.uci.edu/#/c/2161/1/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionManager.java:

PS1, Line 105:  * Sets the maximum txn id to the bigger value of {@code 
txnId} and its current value.
 :  *
> seems like this would fit on one line...
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


[NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Initialize the value of max txn id on the NC to
  the value stored in the latest checkpoint or the
  maximum txn id encountered during recovery. This
  ensures that the correct max value is reported
  to the CC after NC startup.

Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2161
Reviewed-by: Murtadha Hubail 
Integration-Tests: Murtadha Hubail 
Tested-by: Murtadha Hubail 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Checkpoint.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionManager.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionManager.java
5 files changed, 24 insertions(+), 12 deletions(-)

Approvals:
  Murtadha Hubail: Looks good to me, approved; Verified; Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
index 2435b60..7bc5697 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
@@ -280,7 +280,7 @@
 private synchronized void startRecoveryRedoPhase(Set partitions, 
ILogReader logReader,
 long lowWaterMarkLSN, Set winnerTxnSet) throws IOException, 
ACIDException {
 int redoCount = 0;
-long jobId;
+long txnId = 0;
 
 long resourceId;
 long maxDiskLastLsn;
@@ -307,16 +307,16 @@
 LOGGER.info(logRecord.getLogRecordForDisplay());
 }
 lsn = logRecord.getLSN();
-jobId = logRecord.getTxnId();
+txnId = logRecord.getTxnId();
 foundWinner = false;
 switch (logRecord.getLogType()) {
 case LogType.UPDATE:
 if 
(partitions.contains(logRecord.getResourcePartition())) {
-if (winnerTxnSet.contains(jobId)) {
+if (winnerTxnSet.contains(txnId)) {
 foundWinner = true;
-} else if 
(jobId2WinnerEntitiesMap.containsKey(jobId)) {
-jobEntityWinners = 
jobId2WinnerEntitiesMap.get(jobId);
-tempKeyTxnEntityId.setTxnId(jobId, 
logRecord.getDatasetId(), logRecord.getPKHashValue(),
+} else if 
(jobId2WinnerEntitiesMap.containsKey(txnId)) {
+jobEntityWinners = 
jobId2WinnerEntitiesMap.get(txnId);
+tempKeyTxnEntityId.setTxnId(txnId, 
logRecord.getDatasetId(), logRecord.getPKHashValue(),
 logRecord.getPKValue(), 
logRecord.getPKValueSize());
 if 
(jobEntityWinners.containsEntityCommitForTxnId(lsn, tempKeyTxnEntityId)) {
 foundWinner = true;
@@ -396,6 +396,7 @@
 }
 LOGGER.info("Logs REDO phase completed. Redo logs count: " + 
redoCount);
 } finally {
+txnSubsystem.getTransactionManager().ensureMaxTxnId(txnId);
 //close all indexes
 Set resourceIdList = resourceId2MaxLSNMap.keySet();
 for (long r : resourceIdList) {
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java
index 4752481..f922832 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java
@@ -80,10 +80,13 @@
 }
 checkpointManager = CheckpointManagerFactory.create(this, 
checkpointProperties, replicationEnabled);
 final Checkpoint latestCheckpoint = checkpointManager.getLatest();
-if (latestCheckpoint != null && latestCheckpoint.getStorageVersion() 
!= StorageConstants.VERSION) {
-throw new IllegalStateException(
-String.format("Storage version mismatch. Current version 
(%s). On disk version: 

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2317/ 
(2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1638/ 
(5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1645/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1960/ 
(9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7178/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2253/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5680/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2506/ (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2295/
 (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/825/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1626/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

[Murtadha Hubail (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins, Michael Blow,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2161

to look at the new patch set (#2).

Change subject: [NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup
..

[NO ISSUE][TX] Ensure NC Max Txn ID is Initialized on Startup

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Initialize the value of max txn id on the NC to
  the value stored in the latest checkpoint or the
  maximum txn id encountered during recovery. This
  ensures that the correct max value is reported
  to the CC after NC startup.

Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Checkpoint.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionManager.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionManager.java
5 files changed, 24 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/61/2161/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2161
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib529d41c5c219f4b761752a68398127388286d67
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi