Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


[NO ISSUE][FUN] Add docs for array functions, handle FP.

- user model changes: no
- storage format changes: no
- interface changes: no

details:
Add docs for array functions and remove error codes from
error messages in test suite.
This patch also includes handling of floating-point number
arguments for array_range(), array_insert(), array_repeat().

Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2794
Reviewed-by: Till Westmann 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_insert/array_insert.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_range/array_range.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_repeat/array_repeat.1.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_insert/array_insert.3.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_range/array_range.3.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_repeat/array_repeat.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayAppendDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayConcatDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayContainsDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayDistinctDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayFlattenDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayInsertDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayIntersectDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayPositionDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayPrependDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayPutDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRangeDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRemoveDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRepeatDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayReplaceDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayReverseDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySortDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayStarDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySymDiffDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySymDiffnDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayUnionDescriptor.java
27 files changed, 249 insertions(+), 46 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; ; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_insert/array_insert.3.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_insert/array_insert.3.query.sqlpp
index fdc35cc..c0b65e7 100755
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_insert/array_insert.3.query.sqlpp
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_insert/array_insert.3.query.sqlpp
@@ -33,12 +33,15 @@
   "t11": (array_insert([], 0, 10, 12.0, "sth")),  // OK
   "t12": (array_insert([6], "a", 9)), // null, position non-numeric
   "t13": (array_insert([6], 1.0, 9)), // OK
-  "t14": (array_insert([6], 1.5, 9)), // OK
+  "t14": (array_insert([6], 1.5, 9)), // null, position with 
decimals
   "t15": (array_insert(null, 3, 9)),   

Change in asterixdb[master]: [NO ISSUE][API] Return Plan as Result For Explain

2018-07-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][API] Return Plan as Result For Explain
..


[NO ISSUE][API] Return Plan as Result For Explain

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Return optimized logical plan in the results field
  on explain only requests.
- Default plan format to string in test framework.

Change-Id: I615dca6267b925fffd8ab995f0fd0546a0d889b6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2823
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Murtadha Hubail 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
3 files changed, 23 insertions(+), 12 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified
  Murtadha Hubail: Looks good to me, but someone else must approve



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index ca96a96..d57be82 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -104,6 +104,7 @@
 import org.apache.hyracks.api.client.IHyracksClientConnection;
 import org.apache.hyracks.api.client.NodeControllerInfo;
 import org.apache.hyracks.api.config.IOptionType;
+import org.apache.hyracks.api.exceptions.HyracksDataException;
 import org.apache.hyracks.api.exceptions.HyracksException;
 import org.apache.hyracks.api.exceptions.SourceLocation;
 import org.apache.hyracks.api.job.JobId;
@@ -199,6 +200,7 @@
 final boolean isLoad = statement != null && statement.getKind() == 
Statement.Kind.LOAD;
 final SourceLocation sourceLoc =
 query != null ? query.getSourceLocation() : statement != null 
? statement.getSourceLocation() : null;
+final boolean isExplainOnly = isQuery && query.isExplain();
 
 SessionConfig conf = output.config();
 if (isQuery && !conf.is(SessionConfig.FORMAT_ONLY_PHYSICAL_OPS)
@@ -245,7 +247,7 @@
 ICompiler compiler = compilerFactory.createCompiler(plan, 
metadataProvider, t.getVarCounter());
 if (conf.isOptimize()) {
 compiler.optimize();
-if (conf.is(SessionConfig.OOB_OPTIMIZED_LOGICAL_PLAN)) {
+if (conf.is(SessionConfig.OOB_OPTIMIZED_LOGICAL_PLAN) || 
isExplainOnly) {
 if (conf.is(SessionConfig.FORMAT_ONLY_PHYSICAL_OPS)) {
 // For Optimizer tests.
 AlgebricksAppendable buffer = new 
AlgebricksAppendable(output.out());
@@ -257,16 +259,12 @@
 }
 }
 }
-if (isQuery && query.isExplain()) {
-try {
-LogicalOperatorPrettyPrintVisitor pvisitor = new 
LogicalOperatorPrettyPrintVisitor();
-PlanPrettyPrinter.printPlan(plan, pvisitor, 0);
-
ResultUtil.printResults(metadataProvider.getApplicationContext(), 
pvisitor.get().toString(), output,
-new Stats(), null);
-return null;
-} catch (IOException e) {
-throw new AlgebricksException(e);
+if (isExplainOnly) {
+printPlanAsResult(metadataProvider, output);
+if (!conf.is(SessionConfig.OOB_OPTIMIZED_LOGICAL_PLAN)) {
+executionPlans.setOptimizedLogicalPlan(null);
 }
+return null;
 }
 
 if (!conf.isGenerateJobSpec()) {
@@ -308,6 +306,18 @@
 return spec;
 }
 
+private void printPlanAsResult(MetadataProvider metadataProvider, 
SessionOutput output) throws AlgebricksException {
+final SessionConfig conf = output.config();
+boolean quoteResult = output.config().getPlanFormat() == 
SessionConfig.PlanFormat.STRING;
+conf.set(SessionConfig.FORMAT_QUOTE_RECORD, quoteResult);
+try {
+ResultUtil.printResults(metadataProvider.getApplicationContext(), 
executionPlans.getOptimizedLogicalPlan(),
+output, new Stats(), null);
+} catch (HyracksDataException e) {
+throw new AlgebricksException(e);
+}
+}
+
 protected PhysicalOptimizationConfig 
getPhysicalOptimizationConfig(CompilerProperties compilerProperties,
 Map querySpecificConfig, SourceLocation sourceLoc) 
throws AlgebricksException {
 int frameSize = compilerProperties.getFrameSize();
diff --git 

Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/4DTNZV : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6997/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3484/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3484/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4542/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Analytics Compatibility Compilation Successful
https://goo.gl/bJGEUF : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6997/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4692/ (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4052/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4139/ 
(12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8077/ (3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4570/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/422/ 
(11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4142/
 (8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4361/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9614/ (6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/385/ 
(7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4104/ 
(9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Add docs for array functions, handle FP.

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add docs for array functions, handle FP.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2151/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2794
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][API] Return Plan as Result For Explain

2018-07-28 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][API] Return Plan as Result For Explain
..


Patch Set 3: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2823/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java:

PS3, Line 195: 
 : 
Yay!


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2823
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I615dca6267b925fffd8ab995f0fd0546a0d889b6
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6996/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/mzH6kh : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6995/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4541/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4569/ 
(12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/W1kDPg : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/384/ 
(11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6996/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4360/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4051/ 
(9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4138/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8076/ (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4540/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9613/ (6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/421/ (5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://goo.gl/ouvxUt : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Analytics Compatibility Compilation Successful
https://goo.gl/DyfJYZ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4691/ (3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2150/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4141/
 (2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Less "branded" description of the query language

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Less "branded" description of the query language
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4103/ 
(1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2728
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20534fcc9a7464ff352280a36b48d8574a46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6995/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4568/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/383/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4137/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4690/ (6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/420/ (8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4359/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][TEST] Introduce TestExecutor.extractResult

2018-07-28 Thread Till Westmann (Code Review)
Till Westmann has abandoned this change.

Change subject: [NO ISSUE][TEST] Introduce TestExecutor.extractResult
..


Abandoned

old branch

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2646
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9612/ (12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4102/ 
(7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8075/ (11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4140/
 (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4050/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Introduce TestExecutor.extractResult

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE] Introduce TestExecutor.extractResult
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2149/ 
(9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd239fa4a3997006c7fa2b27579956ac9660a2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


[jira] [Commented] (ASTERIXDB-2314) Dataset appears in class names in Hyracks and is confusing

2018-07-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560857#comment-16560857
 ] 

ASF subversion and git services commented on ASTERIXDB-2314:


Commit 51819b77a6068d92eed284624ff6550530b93d05 in asterixdb-bad's branch 
refs/heads/master from Till Westmann
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb-bad.git;h=51819b7 ]

[ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

Change-Id: I333fa410df5efe7da9d4f0e9b7143f9f6928b88b


> Dataset appears in class names in Hyracks and is confusing
> --
>
> Key: ASTERIXDB-2314
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2314
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: RT - Runtime
>Reporter: Abdullah Alamoudi
>Assignee: Till
>Priority: Minor
>  Labels: triaged
>
> Dataset appears frequently in Hyracks in the result distribution context.
> They should be renamed as [Dataset] -> [Result]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb-bad[master]: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

2018-07-28 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged.

Change subject: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks
..


[ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

Change-Id: I333fa410df5efe7da9d4f0e9b7143f9f6928b88b
---
M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M 
asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java
6 files changed, 25 insertions(+), 24 deletions(-)

Approvals:
  Jenkins: Verified
  Murtadha Hubail: Looks good to me, approved



diff --git 
a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java 
b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
index c48ec54..5ec4852 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java
@@ -51,11 +51,11 @@
 import org.apache.asterix.translator.IRequestParameters;
 import org.apache.asterix.translator.IStatementExecutor;
 import org.apache.hyracks.api.client.IHyracksClientConnection;
-import org.apache.hyracks.api.dataset.IHyracksDataset;
-import org.apache.hyracks.api.dataset.ResultSetId;
 import org.apache.hyracks.api.job.DeployedJobSpecId;
 import org.apache.hyracks.api.job.JobId;
 import org.apache.hyracks.api.job.JobSpecification;
+import org.apache.hyracks.api.result.IResultSet;
+import org.apache.hyracks.api.result.ResultSetId;
 
 /**
  * Provides functionality for channel jobs
@@ -122,7 +122,7 @@
 }
 
 public static long runDeployedJobSpec(DeployedJobSpecId distributedId, 
IHyracksClientConnection hcc,
-IHyracksDataset hdc, Map jobParameters, EntityId 
entityId, ITxnIdFactory txnIdFactory,
+IResultSet resultSet, Map jobParameters, EntityId 
entityId, ITxnIdFactory txnIdFactory,
 ICcApplicationContext appCtx, DeployedJobSpecEventListener 
listener, QueryTranslator statementExecutor)
 throws Exception {
 listener.waitWhileAtState(ActivityState.SUSPENDED);
@@ -138,7 +138,7 @@
 long executionMilliseconds = Instant.now().toEpochMilli() - startTime;
 
 if (listener.getType() == 
DeployedJobSpecEventListener.PrecompiledType.QUERY) {
-ResultReader resultReader = new ResultReader(hdc, jobId, new 
ResultSetId(0));
+ResultReader resultReader = new ResultReader(resultSet, jobId, new 
ResultSetId(0));
 
 ResultUtil.printResults(appCtx, resultReader, 
statementExecutor.getSessionOutput(),
 new IStatementExecutor.Stats(), null);
@@ -235,7 +235,7 @@
 //Procedures
 metadataProvider.setResultSetId(new ResultSetId(0));
 IStatementExecutor.ResultDelivery resultDelivery = 
requestParameters.getResultProperties().getDelivery();
-IHyracksDataset hdc = requestParameters.getHyracksDataset();
+IResultSet hdc = requestParameters.getResultSet();
 IStatementExecutor.Stats stats = requestParameters.getStats();
 boolean resultsAsync = resultDelivery == 
IStatementExecutor.ResultDelivery.ASYNC
 || resultDelivery == 
IStatementExecutor.ResultDelivery.DEFERRED;
@@ -272,12 +272,12 @@
 }
 
 private static JobSpecification compileProcedureJob(IStatementExecutor 
statementExecutor,
-MetadataProvider metadataProvider, IHyracksClientConnection hcc, 
IHyracksDataset hdc,
+MetadataProvider metadataProvider, IHyracksClientConnection hcc, 
IResultSet resultSet,
 IStatementExecutor.Stats stats, Statement procedureStatement) 
throws Exception {
 if (procedureStatement.getKind() == Statement.Kind.INSERT) {
 return ((QueryTranslator) 
statementExecutor).handleInsertUpsertStatement(metadataProvider,
-procedureStatement, hcc, hdc, 
IStatementExecutor.ResultDelivery.ASYNC, null, stats, true, null,
-null, null);
+procedureStatement, hcc, resultSet, 
IStatementExecutor.ResultDelivery.ASYNC, null, stats, true,
+null, null, null);
 } else if (procedureStatement.getKind() == Statement.Kind.QUERY) {
 return compileQueryJob(statementExecutor, metadataProvider, hcc, 
(Query) procedureStatement);
 } else {
diff --git 
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
 
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
index 

[jira] [Commented] (ASTERIXDB-2314) Dataset appears in class names in Hyracks and is confusing

2018-07-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560855#comment-16560855
 ] 

ASF subversion and git services commented on ASTERIXDB-2314:


Commit 1d2f00d88313fe393ff877a42fb8684bee9c1b6a in asterixdb's branch 
refs/heads/master from Till Westmann
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=1d2f00d ]

[ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

- user model changes: no
- storage format changes: no
- interface changes: yes

Change-Id: I260add3a2dfb4a722440af5008a1a75f9446579e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2478
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Murtadha Hubail 


> Dataset appears in class names in Hyracks and is confusing
> --
>
> Key: ASTERIXDB-2314
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2314
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: RT - Runtime
>Reporter: Abdullah Alamoudi
>Assignee: Till
>Priority: Minor
>  Labels: triaged
>
> Dataset appears frequently in Hyracks in the result distribution context.
> They should be renamed as [Dataset] -> [Result]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb-bad[master]: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

2018-07-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2586
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333fa410df5efe7da9d4f0e9b7143f9f6928b88b
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

2018-07-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks
..


Patch Set 16: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2478
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I260add3a2dfb4a722440af5008a1a75f9446579e
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6994/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/QNAAzG : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3483/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/u4r6Jw : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3483/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4539/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4567/ 
(12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks
..


Patch Set 16: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6991/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2478
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I260add3a2dfb4a722440af5008a1a75f9446579e
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks
..


Patch Set 16: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/LHAQCM : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2478
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I260add3a2dfb4a722440af5008a1a75f9446579e
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Analytics Compatibility Compilation Successful
https://goo.gl/ifAieY : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6994/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4101/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9611/ (6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4139/
 (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4358/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4049/ 
(7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4689/ (11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4136/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8074/ (4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2148/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/382/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/419/ (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Luo Chen (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2825

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..

[ASTERIXDB-2429] Fix the upsert of primary key index

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Previously the primary key index is not properly maintained during
upsert. Since there is no secondary key in the primary key index, the
old value would always point to the primary key, which is always equal
to the new value. As a result, the primary key index is nevered
maintainined during upsert.
- This patch fixes this bug with two changes:
First, if there is a primary key index, we would perform upsert anyway
no matter whether old value == new value
Second, use a boolean variable to indicate whether the operation
is upsert or delete since for the primary key index, old value cannot
provide such information.

Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-meta-pk-index/change-feed-with-meta-pk-index.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-meta-pk-index/change-feed-with-meta-pk-index.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-meta-pk-index/change-feed-with-meta-pk-index.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/change-feed-with-meta-pk-index/change-feed-with-meta-pk-index.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/upsert/primary-secondary-btree/primary-secondary-btree.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-meta-pk-index/change-feed-with-meta-pk-index.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/upsert/primary-secondary-btree/primary-secondary-btree.2.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryUpsertOperatorDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryUpsertOperatorNodePushable.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/IndexInsertDeleteUpsertOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteUpsertOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexInsertDeleteUpsertPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
21 files changed, 317 insertions(+), 38 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/25/2825/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 


Change in asterixdb[master]: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2314][HYR] Dataset in class names in Hyracks
..


Patch Set 16: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3482/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2478
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I260add3a2dfb4a722440af5008a1a75f9446579e
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Analytics Compatibility Compilation Successful
https://goo.gl/4S3dvB : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 3: Contrib-2

Analytics Compatibility Compilation Failed
https://goo.gl/8gqCiJ : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6993/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4138/
 (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4357/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2147/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/381/ 
(6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/418/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8073/ (5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4688/ (2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2429] Fix the upsert of primary key index

2018-07-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9610/ (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2825
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


  1   2   >