Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3816/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7602/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3816/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/TcQ5dy : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/200/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8723/ (2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4996/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Analytics Compatibility Compilation Successful
https://goo.gl/f71Gxy : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7602/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/201/
 (12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4777/
 (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Hussain Towaileb (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3031

to look at the new patch set (#13).

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..

[ASTERIXDB-2476][FUN] Support array slicing in SQL++

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Added array_slice function. 2 functions were added, one that
accepts 2 arguments and the other accepts 3 arguments. The
arguments are (list, start, end) respectively.
- Added array_slice function test cases.
- Array slice syntax and documentation will be added in subsequent
changes.

Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.3.adm
A 

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5161/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2785/ 
(11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4686/ 
(1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10256/ (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4741/ 
(6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5345/ (3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5115/
 (10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4775/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


[jira] [Updated] (ASTERIXDB-2487) Cluster becomes UNUSUABLE with "java.lang.IllegalStateException: Couldn't find any checkpoints for resource"

2018-11-26 Thread Taewoo Kim (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taewoo Kim updated ASTERIXDB-2487:
--
Description: 
The Clouberry cluster became UNUSUABLE after the nc-1 (among five NCs) 
generated the following exception.

 
{code:java}
21:32:10.659 [Executor-10173:1] WARN 
org.apache.asterix.app.nc.IndexCheckpointManager - Couldn't find any checkpoint 
file for index 
io1/storage/partition_0/twitter/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382/0/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382.
 Content of dir are null.
21:32:10.659 [Executor-10172:1] WARN 
org.apache.asterix.app.nc.IndexCheckpointManager - Couldn't find any checkpoint 
file for index 
io2/storage/partition_1/twitter/ds_tweet_9460370bb0ca1c98a779b1bcc6861c2c/0/ds_tweet_9460370bb0ca1c98a779b1bcc6861c2c.
 Content of dir are null.
21:32:10.660 [Executor-10173:1] ERROR 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness - FLUSH 
operation.afterFinalize failed on {"class" : "LSMBTree", "dir" : 
"/home/waans11/asterixdb/io1/storage/partition_0/twitter/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382/0/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382",
 "memory" : [{"class":"LSMBTreeMemoryComponent", 
"state":"READABLE_UNWRITABLE_FLUSHING", "writers":0, "readers":1, 
"pendingFlushes":0, "id":"[9,9]"}, {"class":"LSMBTreeMemoryComponent", 
"state":"INACTIVE", "writers":0, "readers":0, "pendingFlushes":0, 
"id":"[8,8]"}], "disk" : 3, "num-scheduled-flushes":1, 
"current-memory-component":1}
21:32:10.660 [Executor-10173:1] ERROR 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness - FLUSH 
operation.afterFinalize failed on {"class" : "LSMBTree", "dir" : 
"/home/waans11/asterixdb/io1/storage/partition_0/twitter/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382/0/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382",
 "memory" : [{"class":"LSMBTreeMemoryComponent", 
"state":"READABLE_UNWRITABLE_FLUSHING", "writers":0, "readers":1, 
"pendingFlushes":0, "id":"[9,9]"}, {"class":"LSMBTreeMemoryComponent", 
"state":"INACTIVE", "writers":0, "readers":0, "pendingFlushes":0, 
"id":"[8,8]"}], "disk" : 3, "num-scheduled-flushes":1, 
"current-memory-component":1}
java.lang.IllegalStateException: Couldn't find any checkpoints for resource: 
io1/storage/partition_0/twitter/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382/0/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382
at 
org.apache.asterix.app.nc.IndexCheckpointManager.getLatest(IndexCheckpointManager.java:145)
 ~[asterix-app-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.app.nc.IndexCheckpointManager.flushed(IndexCheckpointManager.java:86)
 ~[asterix-app-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.common.ioopcallbacks.LSMIOOperationCallback.addComponentToCheckpoint(LSMIOOperationCallback.java:136)
 ~[asterix-common-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.common.ioopcallbacks.LSMIOOperationCallback.afterFinalize(LSMIOOperationCallback.java:123)
 ~[asterix-common-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness.doIo(LSMHarness.java:544)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness.flush(LSMHarness.java:513)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMTreeIndexAccessor.flush(LSMTreeIndexAccessor.java:122)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.FlushOperation.call(FlushOperation.java:38)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.FlushOperation.call(FlushOperation.java:29)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_161]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_161]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_161]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_161]
21:32:10.663 [Executor-10172:1] ERROR 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness - FLUSH 
operation.afterFinalize failed on {"class" : "LSMBTree", "dir" : 
"/home/waans11/asterixdb/io2/storage/partition_1/twitter/ds_tweet_9460370bb0ca1c98a779b1bcc6861c2c/0/ds_tweet_9460370bb0ca1c98a779b1bcc6861c2c",
 "memory" : [{"class":"LSMBTreeMemoryComponent", 
"state":"READABLE_UNWRITABLE_FLUSHING", "writers":0, "readers":1, 
"pendingFlushes":0, "id":"[24,24]"}, {"class":"LSMBTreeMemoryComponent", 
"state":"INACTIVE", "writers":0, "readers":0, "pendingFlushes":0, 
"id":"[23,23]"}], "disk" : 4, "num-scheduled-flushes":1, 
"current-memory-component":1}
java.lang.IllegalStateException: Couldn't find any checkpoints for resource: 

[jira] [Created] (ASTERIXDB-2487) Cluster becomes UNUSUABLE with "java.lang.IllegalStateException: Couldn't find any checkpoints for resource"

2018-11-26 Thread Taewoo Kim (JIRA)
Taewoo Kim created ASTERIXDB-2487:
-

 Summary: Cluster becomes UNUSUABLE with 
"java.lang.IllegalStateException: Couldn't find any checkpoints for resource"
 Key: ASTERIXDB-2487
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2487
 Project: Apache AsterixDB
  Issue Type: Bug
Reporter: Taewoo Kim
 Attachments: nc-1.log

The Clouberry cluster became UNUSUABLE after the nc-1 (among five NCs) 
generated the following exception.

 
{code:java}
21:32:10.660 [Executor-10173:1] ERROR 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness - FLUSH 
operation.afterFinalize failed on {"class" : "LSMBTree", "dir" : 
"/home/waans11/asterixdb/io1/storage/partition_0/twitter/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382/0/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382",
 "memory" : [{"class":"LSMBTreeMemoryComponent", 
"state":"READABLE_UNWRITABLE_FLUSHING", "writers":0, "readers":1, 
"pendingFlushes":0, "id":"[9,9]"}, {"class":"LSMBTreeMemoryComponent", 
"state":"INACTIVE", "writers":0, "readers":0, "pendingFlushes":0, 
"id":"[8,8]"}], "disk" : 3, "num-scheduled-flushes":1, 
"current-memory-component":1}
java.lang.IllegalStateException: Couldn't find any checkpoints for resource: 
io1/storage/partition_0/twitter/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382/0/ds_tweet_e9ad9c2394f7dc7b6a69fb43e52a7382
at 
org.apache.asterix.app.nc.IndexCheckpointManager.getLatest(IndexCheckpointManager.java:145)
 ~[asterix-app-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.app.nc.IndexCheckpointManager.flushed(IndexCheckpointManager.java:86)
 ~[asterix-app-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.common.ioopcallbacks.LSMIOOperationCallback.addComponentToCheckpoint(LSMIOOperationCallback.java:136)
 ~[asterix-common-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.common.ioopcallbacks.LSMIOOperationCallback.afterFinalize(LSMIOOperationCallback.java:123)
 ~[asterix-common-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness.doIo(LSMHarness.java:544)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness.flush(LSMHarness.java:513)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.LSMTreeIndexAccessor.flush(LSMTreeIndexAccessor.java:122)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.FlushOperation.call(FlushOperation.java:38)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at 
org.apache.hyracks.storage.am.lsm.common.impls.FlushOperation.call(FlushOperation.java:29)
 [hyracks-storage-am-lsm-common-0.3.5-SNAPSHOT.jar:0.3.5-SNAPSHOT]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_161]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_161]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_161]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_161]
21:32:10.663 [Executor-10172:1] ERROR 
org.apache.hyracks.storage.am.lsm.common.impls.LSMHarness - FLUSH 
operation.afterFinalize failed on {"class" : "LSMBTree", "dir" : 
"/home/waans11/asterixdb/io2/storage/partition_1/twitter/ds_tweet_9460370bb0ca1c98a779b1bcc6861c2c/0/ds_tweet_9460370bb0ca1c98a779b1bcc6861c2c",
 "memory" : [{"class":"LSMBTreeMemoryComponent", 
"state":"READABLE_UNWRITABLE_FLUSHING", "writers":0, "readers":1, 
"pendingFlushes":0, "id":"[24,24]"}, {"class":"LSMBTreeMemoryComponent", 
"state":"INACTIVE", "writers":0, "readers":0, "pendingFlushes":0, 
"id":"[23,23]"}], "disk" : 4, "num-scheduled-flushes":1, 
"current-memory-component":1}
java.lang.IllegalStateException: Couldn't find any checkpoints for resource: 
io2/storage/partition_1/twitter/ds_tweet_9460370bb0ca1c98a779b1bcc6861c2c/0/ds_tweet_9460370bb0ca1c98a779b1bcc6861c2c
at 
org.apache.asterix.app.nc.IndexCheckpointManager.getLatest(IndexCheckpointManager.java:145)
 ~[asterix-app-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.app.nc.IndexCheckpointManager.flushed(IndexCheckpointManager.java:86)
 ~[asterix-app-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.common.ioopcallbacks.LSMIOOperationCallback.addComponentToCheckpoint(LSMIOOperationCallback.java:136)
 ~[asterix-common-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.common.ioopcallbacks.LSMIOOperationCallback.afterFinalize(LSMIOOperationCallback.java:123)
 ~[asterix-common-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.common.ioopcallbacks.LSMIOOperationCallback.addComponentToCheckpoint(LSMIOOperationCallback.java:136)
 ~[asterix-common-0.9.5-SNAPSHOT.jar:0.9.5-SNAPSHOT]
at 
org.apache.asterix.common.ioopcallbacks.LSMIOOperationCallback.afterFinalize(LSMIOOperationCallback.java:123)
 

Change in asterixdb[master]: [NO ISSUE][API][MTD] Refactor query service servlet - user m...

2018-11-26 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][API][MTD] Refactor query service servlet - user 
model changes: no - storage format changes: no - interface changes: no
..


Patch Set 1:

Analytics Compatibility Tests Failed
https://goo.gl/Le5QJq : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3038
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbc81219cbe2f337b3c4aaf4a242ef2ebeb165c5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2451][DOC] Fix object_unwrap() documentation

2018-11-26 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2451][DOC] Fix object_unwrap() documentation
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3042
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5822a51e49676dcd9aae35455d2e19fb6dfee07
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 12:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp:

Line 27: };
Do we have have testcases where MISSING is passed as a first or second argument 
to the 2 argument version of array_slice()? If not then let's add those.


https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp:

Line 36: };
Do we have have testcases where NULL is passed as a first or second argument to 
the 2 argument version of array_slice()? If not then let's add those.


https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java:

Line 204: IAsterixListBuilder listBuilder =
We try to avoid object construction inside evaluate(). You only need at most 
two listbuilder instances: OrderedListBuilder and UnorderedListBuilder. These 
instances should be reused on each evaluate() call. Take a look at how 
AbstractArrayProcessEval maintains those.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2451][DOC] Fix object_unwrap() documentation

2018-11-26 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2451][DOC] Fix object_unwrap() documentation
..


Patch Set 1:

Analytics Compatibility Tests Failed
https://goo.gl/gxKG5Z : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3042
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5822a51e49676dcd9aae35455d2e19fb6dfee07
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No