Change in asterixdb[master]: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state
Michael Blow has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3394 )
Change subject: [NO ISSUE][*DB][CLUS] Add support for a rebalance required
cluster state
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/3394/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java:
https://asterix-gerrit.ics.uci.edu/#/c/3394/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java@195
PS1, Line 195: if (state != ClusterState.ACTIVE && state !=
ClusterState.RECOVERING) {
: setState(ClusterState.PENDING);
: }
> I doubt this is of any use since any subscribers won't be able to get the c
we explicitly pass the new state to the, there's no need to get the lock in
that case- but we could clean this up later...
--
To view, visit https://asterix-gerrit.ics.uci.edu/3394
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I863f8bf3fe1ce8d59522c9a28a1283006ffa414c
Gerrit-Change-Number: 3394
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Wed, 15 May 2019 20:25:16 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state
Michael Blow has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3394 )
Change subject: [NO ISSUE][*DB][CLUS] Add support for a rebalance required
cluster state
..
[NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state
Allow extensions to mandate that a rebalance is required in order for
the cluster to go active
Change-Id: I863f8bf3fe1ce8d59522c9a28a1283006ffa414c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3394
Contrib: Jenkins
Integration-Tests: Jenkins
Tested-by: Jenkins
Reviewed-by: Murtadha Hubail
---
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
3 files changed, 55 insertions(+), 22 deletions(-)
Approvals:
Jenkins: Verified; ; Verified
Murtadha Hubail: Looks good to me, approved
Objections:
Jenkins: Violations found
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java
index c2d3303..e13756c 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java
@@ -30,8 +30,8 @@
PENDING, // the metadata node has not yet joined & initialized
RECOVERING, // global recovery has not yet completed
ACTIVE, // cluster is ACTIVE and ready for requests
-REBALANCING, // replication is processing failbacks
-SHUTTING_DOWN // a shutdown request has been received, and is underway
+SHUTTING_DOWN, // a shutdown request has been received, and is underway
+REBALANCE_REQUIRED // one or more datasets require rebalance before
the cluster is usable
}
WorkType getClusterManagementWorkType();
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
index 0e62851..6c39372 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
@@ -21,6 +21,7 @@
import java.util.Map;
import java.util.Set;
import java.util.concurrent.TimeUnit;
+import java.util.function.Predicate;
import org.apache.asterix.common.api.IClusterManagementWork.ClusterState;
import org.apache.asterix.common.dataflow.ICcApplicationContext;
@@ -107,6 +108,14 @@
* @return true if the desired state was reached before timeout occurred
*/
boolean waitForState(ClusterState waitForState, long timeout, TimeUnit
unit)
+throws HyracksDataException, InterruptedException;
+
+/**
+ * Blocks until the cluster state matches supplied predicate, or timeout
is exhausted.
+ *
+ * @return the cluster state matching the predicate if it was satisfied
before timeout occurred, otherwise null
+ */
+ClusterState waitForState(Predicate condition, long timeout,
TimeUnit unit)
throws HyracksDataException, InterruptedException;
/**
@@ -250,4 +259,10 @@
* @return The metadata cluster partitions
*/
ClusterPartition getMetadataPartition();
+
+/**
+ * Indicate whether one or more datasets must be rebalanced before the
cluster becomes ACTIVE
+ * @param rebalanceRequired
+ */
+void setRebalanceRequired(boolean rebalanceRequired) throws
HyracksDataException;
}
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
index 16a479e..7933cd2 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
@@ -28,6 +28,7 @@
import java.util.SortedMap;
import java.util.TreeSet;
import java.util.concurrent.TimeUnit;
+import java.util.function.Predicate;
import org.apache.asterix.common.api.IClusterManagementWork.ClusterState;
import org.apache.asterix.common.cluster.ClusterPartition;
@@ -75,6 +76,7 @@
private INcLifecycleCoordinator lifecycleCoordinator;
private ICcApplicationContext appCtx;
private ClusterPartition metadataPartition;
+private boolean rebalanceRequired;
@Override
public void setCcAppCtx(ICcApplicationContext appCtx) {
@@ -186,45 +188,55 @@
return;
[jira] [Resolved] (ASTERIXDB-2567) Exception encountered in serializing nullable record fields
[
https://issues.apache.org/jira/browse/ASTERIXDB-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ali Alsuliman resolved ASTERIXDB-2567.
--
Resolution: Fixed
> Exception encountered in serializing nullable record fields
> ---
>
> Key: ASTERIXDB-2567
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2567
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: RT - Runtime
>Affects Versions: 0.9.4
>Reporter: Ali Alsuliman
>Assignee: Ali Alsuliman
>Priority: Major
> Fix For: 0.9.5
>
>
> When serializing a record, a field should be checked if it's nullable. The
> value to be serialized should be checked if it's null or value to serialize
> it correctly. Exceptions could happen when the record is in an array.
> The below query produces an exception.
>
> {code:java}
> [{"f1": "fieldStr", "f2": 1 < "text"}] ;
> result: exception, ANull cannot be cast to ABoolean
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ASTERIXDB-2567) Exception encountered in serializing nullable record fields
[
https://issues.apache.org/jira/browse/ASTERIXDB-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840714#comment-16840714
]
ASF subversion and git services commented on ASTERIXDB-2567:
Commit c99f57a6dee571b321ef4ca3c5d904cc67fc8138 in asterixdb's branch
refs/heads/master from Ali Alsuliman
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=c99f57a ]
[ASTERIXDB-2567][RT] Fix serializing nullable record fields
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
When serializing a record, a field should be checked if it's nullable.
The value to be serialized should be checked if it's null or value to
serialize it correctly. Exceptions could happen when the record is in
an array if record fields are not checked.
Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3398
Contrib: Jenkins
Tested-by: Jenkins
Reviewed-by: Murtadha Hubail
Integration-Tests: Jenkins
> Exception encountered in serializing nullable record fields
> ---
>
> Key: ASTERIXDB-2567
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2567
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: RT - Runtime
>Affects Versions: 0.9.4
>Reporter: Ali Alsuliman
>Assignee: Ali Alsuliman
>Priority: Major
> Fix For: 0.9.5
>
>
> When serializing a record, a field should be checked if it's nullable. The
> value to be serialized should be checked if it's null or value to serialize
> it correctly. Exceptions could happen when the record is in an array.
> The below query produces an exception.
>
> {code:java}
> [{"f1": "fieldStr", "f2": 1 < "text"}] ;
> result: exception, ANull cannot be cast to ABoolean
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Ali Alsuliman has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. [ASTERIXDB-2567][RT] Fix serializing nullable record fields - user model changes: no - storage format changes: no - interface changes: no Details: When serializing a record, a field should be checked if it's nullable. The value to be serialized should be checked if it's null or value to serialize it correctly. Exceptions could happen when the record is in an array if record fields are not checked. Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3398 Contrib: Jenkins Tested-by: Jenkins Reviewed-by: Murtadha Hubail Integration-Tests: Jenkins --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.2.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.4.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.6.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.7.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.8.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.2.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.4.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.5.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.6.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.7.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.8.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java 18 files changed, 207 insertions(+), 9 deletions(-) Approvals: Jenkins: Verified; ; Verified Murtadha Hubail: Looks good to me, approved Anon. E. Moose (1000171): Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.1.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.1.query.sqlpp new file mode 100644 index 000..8d50408 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.1.query.sqlpp @@ -0,0 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/G1ro5FRugDBbQdez9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 19:54:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8566/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 19:39:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state
Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3394 ) Change subject: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I863f8bf3fe1ce8d59522c9a28a1283006ffa414c Gerrit-Change-Number: 3394 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 19:23:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 19:25:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state
Murtadha Hubail has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3394 )
Change subject: [NO ISSUE][*DB][CLUS] Add support for a rebalance required
cluster state
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/3394/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java:
https://asterix-gerrit.ics.uci.edu/#/c/3394/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java@195
PS1, Line 195: if (state != ClusterState.ACTIVE && state !=
ClusterState.RECOVERING) {
: setState(ClusterState.PENDING);
: }
> This ensures that we always transition from UNUSABLE -> PENDING -> RECOVERI
I doubt this is of any use since any subscribers won't be able to get the
current state until this synchronized block is complete. We can revise this on
another change though.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3394
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I863f8bf3fe1ce8d59522c9a28a1283006ffa414c
Gerrit-Change-Number: 3394
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Wed, 15 May 2019 19:03:03 +
Gerrit-HasComments: Yes
[jira] [Resolved] (ASTERIXDB-2555) Make hash join use logical comparison
[ https://issues.apache.org/jira/browse/ASTERIXDB-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alsuliman resolved ASTERIXDB-2555. -- Resolution: Fixed > Make hash join use logical comparison > - > > Key: ASTERIXDB-2555 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2555 > Project: Apache AsterixDB > Issue Type: Bug > Components: COMP - Compiler >Affects Versions: 0.9.5 >Reporter: Ali Alsuliman >Assignee: Ali Alsuliman >Priority: Major > Fix For: 0.9.5 > > > Joins should use logical comparison. Nested loop join uses EQ function which > does logical comparison. Hash join should do the same thing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4416/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:49:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11278/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:29:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/6Fmr4BEWan9nPSQh7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:33:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4416/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:32:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3398/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java: https://asterix-gerrit.ics.uci.edu/#/c/3398/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java@185 PS3, Line 185: for (int fieldIndex > not changed in your patch, but why not move this into the for-loop initiali right. done since i had to rebase anyway. -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:31:05 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5804/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:29:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8566/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:30:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/965/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3798/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1063/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6159/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6369/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5955/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:29:00 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1155/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9745/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5703/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Hello Anon. E. Moose (1000171), Till Westmann, Jenkins, Michael Blow, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3398 to look at the new patch set (#4). Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. [ASTERIXDB-2567][RT] Fix serializing nullable record fields - user model changes: no - storage format changes: no - interface changes: no Details: When serializing a record, a field should be checked if it's nullable. The value to be serialized should be checked if it's null or value to serialize it correctly. Exceptions could happen when the record is in an array if record fields are not checked. Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.2.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.4.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.6.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.7.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.8.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.2.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.4.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.5.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.6.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.7.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/record-serialization-ASTERIXDB-2567/record-serialization-ASTERIXDB-2567.8.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java 18 files changed, 207 insertions(+), 9 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/98/3398/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6009/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:28:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/568/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:29:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/727/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:29:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5786/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:29:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Dmitry Lychagin has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. [NO ISSUE][COMP] Change plan printing for window operators - user model changes: no - storage format changes: no - interface changes: no Details: - Print window operators as 'window-aggregate' in the query plan - Add testcase for a window function call used in WHERE clause, and a negative testcase - Implement reset() for LogicalOperatorPrettyPrintVisitorJson - Make IOptimizationContext.getPrettyPrintVisitor() return AbstractLogicalOperatorPrettyPrintVisitor Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3397 Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Ali Alsuliman --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/misc_01/misc_01.9.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/win_negative/win_negative.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/window/misc_01/misc_01.9.adm A asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/window/misc_01/misc_01.9.ast M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/base/IOptimizationContext.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AbstractLogicalOperatorPrettyPrintVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AbstractRuleController.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AlgebricksOptimizationContext.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java 12 files changed, 129 insertions(+), 13 deletions(-) Approvals: Jenkins: Verified; Verified Anon. E. Moose (1000171): Ali Alsuliman: Looks good to me, approved Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/misc_01/misc_01.9.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/misc_01/misc_01.9.query.sqlpp new file mode 100644 index 000..b8db547 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/misc_01/misc_01.9.query.sqlpp @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +/* + * Description : Window function call in a complex WHERE clause + * Expected Res : SUCCESS + */ + +from range(1, 10) x +where to_bigint(to_double(x)) > 1 + and sum(x) over () = 55 + and x < 4 + and count(x) over () = 10 +select value x; diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/win_negative/win_negative.5.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/win_negative/win_negative.5.query.sqlpp new file mode 100644 index 000..be98876 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/win_negative/win_negative.5.query.sqlpp @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + *
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:16:47 + Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-2555) Make hash join use logical comparison
[ https://issues.apache.org/jira/browse/ASTERIXDB-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840624#comment-16840624 ] ASF subversion and git services commented on ASTERIXDB-2555: Commit b09ec2d99277c2fbce0e6d2961aa4ca483963edd in asterixdb's branch refs/heads/master from Ali Alsuliman [ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=b09ec2d ] [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison - user model changes: no - storage format changes: no - interface changes: no Details: This patch changes the hash join operator to use the join condition to evaluate if tuples are equal when joining. Binary physical comparators have been removed. The join condition evaluator is in TuplePairEvaluator. - extraced TuplePairEvaluatorFactory out of nested loop join class into a separate class so that it is shared among nested loop and hash join. - switched from FrameTuplePairComparator to ITuplePairComparator in in OptimizedHybridHashJoin and InMemoryHashJoin. - moved debugging code from OptimizedHybridHashJoin into a separate class, JoinUtil. - temporarily made the logical comparison of multisets use raw binary comparison instead of returning null until the logic is implemented. - made IBinaryBooleanInspector a functional interface and updated the implementations. - updated record and array test cases to reflect the new behaviour of hash join where logical comparison could produce null. Also, updated sorting, group by and distinct test cases since the input data has been modified. - added two new input files arrays1nulls.adm & arrays2nulls.adm to be used by the open dataset. previous arrays1.adm & arrays2.adm are used by the closed dataset since it cannot accept arrays with null values. Change-Id: If1834967fdd913fdc76003f09636b2450d07cd5e Reviewed-on: https://asterix-gerrit.ics.uci.edu/3387 Contrib: Jenkins Integration-Tests: Jenkins Tested-by: Jenkins Reviewed-by: Dmitry Lychagin Reviewed-by: Murtadha Hubail > Make hash join use logical comparison > - > > Key: ASTERIXDB-2555 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2555 > Project: Apache AsterixDB > Issue Type: Bug > Components: COMP - Compiler >Affects Versions: 0.9.5 >Reporter: Ali Alsuliman >Assignee: Ali Alsuliman >Priority: Major > Fix For: 0.9.5 > > > Joins should use logical comparison. Nested loop join uses EQ function which > does logical comparison. Hash join should do the same thing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/dBb9qUEWkKsHBQ1s8 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 18:14:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8565/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 17:19:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison
Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3387 ) Change subject: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3387 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1834967fdd913fdc76003f09636b2450d07cd5e Gerrit-Change-Number: 3387 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 17:11:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/gpS9V2EqHyBHFU9JA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 16:48:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8564/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 16:30:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state
Michael Blow has removed Anon. E. Moose (1000171) from this change. ( https://asterix-gerrit.ics.uci.edu/3394 ) Change subject: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state .. Removed reviewer null with the following votes: * Contrib-2 by Anon. E. Moose (1000171) -- To view, visit https://asterix-gerrit.ics.uci.edu/3394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I863f8bf3fe1ce8d59522c9a28a1283006ffa414c Gerrit-Change-Number: 3394 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3398/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java: https://asterix-gerrit.ics.uci.edu/#/c/3398/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java@185 PS3, Line 185: int fieldIndex = 0; not changed in your patch, but why not move this into the for-loop initializer? -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:26:29 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/wYPCXfAWDJiNFDt39 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:08:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5785/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/964/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1154/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:12:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6008/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8565/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:06:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5765/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/726/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5803/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/567/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11277/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3797/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5702/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6158/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6368/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1062/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9744/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5954/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:04:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2567][RT] Fix serializing nullable record fields
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3398 ) Change subject: [ASTERIXDB-2567][RT] Fix serializing nullable record fields .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42105965e69c60bc4b123337296476b4d75f0ad8 Gerrit-Change-Number: 3398 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 16:03:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Analytics Compatibility Compilation Successful : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:27:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1153/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:26:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:22:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5802/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/566/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6007/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8564/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:20:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3796/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:49 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11276/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5784/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5764/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6157/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9743/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1061/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/725/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6367/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/963/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5953/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][COMP] Change plan printing for window operators
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3397 ) Change subject: [NO ISSUE][COMP] Change plan printing for window operators .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5701/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3397 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710 Gerrit-Change-Number: 3397 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 15 May 2019 15:18:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][*DB][CLUS] Add support for a rebalance required cluster state
Michael Blow has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3394 )
Change subject: [NO ISSUE][*DB][CLUS] Add support for a rebalance required
cluster state
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/3394/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java:
https://asterix-gerrit.ics.uci.edu/#/c/3394/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java@195
PS1, Line 195: if (state != ClusterState.ACTIVE && state !=
ClusterState.RECOVERING) {
: setState(ClusterState.PENDING);
: }
> is this needed? looks like some unnecessary transient state that will be ch
This ensures that we always transition from UNUSABLE -> PENDING -> RECOVERING
-> [REBALANCE_REQUIRED ->] ACTIVE in case of normal startup- this might be
helpful for cluster event subscribers.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3394
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I863f8bf3fe1ce8d59522c9a28a1283006ffa414c
Gerrit-Change-Number: 3394
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-Comment-Date: Wed, 15 May 2019 11:43:54 +
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 12: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/7NMy2gdZd8m1GKb8A : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 12 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 11:01:50 + Gerrit-HasComments: No
[jira] [Resolved] (ASTERIXDB-2535) UPSERT and UUIDs are broken if used together
[ https://issues.apache.org/jira/browse/ASTERIXDB-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hussain Towaileb resolved ASTERIXDB-2535. - Resolution: Fixed > UPSERT and UUIDs are broken if used together > > > Key: ASTERIXDB-2535 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2535 > Project: Apache AsterixDB > Issue Type: Bug > Components: COMP - Compiler, SQL - Translator SQL++ >Affects Versions: 0.9.4 >Reporter: Michael J. Carey >Assignee: Hussain Towaileb >Priority: Major > Fix For: 0.9.5 > > > UPSERT doesn't work right for datasets with auto-generated (UUID) keys. Both > UPSERT and INSERT blindly generate and add the key - and if the incoming > record already has a key value, they fail with an object-merge error (note > that we need to improve the msg too!) due to what then becomes a duplicate > field. What's needed is to get them both to do to the right thing - which > would be to use the incoming key value if there is one and only generate one > only if there isn't one in the incoming object. This is especially a problem > for UPSERTs, as it means we currently cannot ever update data in datasets > with system-generated keys (!!!). (For INSERT we could just make a rule that > you can't pass in a key if you're going into auto-keyed dataset.) This is a > major bummer for open-source users who want to use UUIDs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ASTERIXDB-2535) UPSERT and UUIDs are broken if used together
[ https://issues.apache.org/jira/browse/ASTERIXDB-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840284#comment-16840284 ] ASF subversion and git services commented on ASTERIXDB-2535: Commit cd01c55b14ead23be7e9f557f285b4a69d5e8008 in asterixdb's branch refs/heads/master from Hussain Towaileb [ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=cd01c55 ] [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement - user model changes: no - storage format changes: no - interface changes: no Details: - Added a new record merge function, extending the old one, to handle the merge of duplicate fields. - Updated the record merge type computer to handle the merge of duplicate fields properly at compile time. - Added a new record merge descriptor and evaluator, extending the old one, to handle the merge of duplicate fields properly at runtime. - Updated IntroduceAutogenerateIDRule to use the new record merge function. - Added test cases to test the newly added function for insert and upsert statements. Change-Id: I22100d3ff29864b8bfd54b0decb183e5056fdb4a Reviewed-on: https://asterix-gerrit.ics.uci.edu/3370 Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Hussain Towaileb > UPSERT and UUIDs are broken if used together > > > Key: ASTERIXDB-2535 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2535 > Project: Apache AsterixDB > Issue Type: Bug > Components: COMP - Compiler, SQL - Translator SQL++ >Affects Versions: 0.9.4 >Reporter: Michael J. Carey >Assignee: Hussain Towaileb >Priority: Major > Fix For: 0.9.5 > > > UPSERT doesn't work right for datasets with auto-generated (UUID) keys. Both > UPSERT and INSERT blindly generate and add the key - and if the incoming > record already has a key value, they fail with an object-merge error (note > that we need to improve the msg too!) due to what then becomes a duplicate > field. What's needed is to get them both to do to the right thing - which > would be to use the incoming key value if there is one and only generate one > only if there isn't one in the incoming object. This is especially a problem > for UPSERTs, as it means we currently cannot ever update data in datasets > with system-generated keys (!!!). (For INSERT we could just make a rule that > you can't pass in a key if you're going into auto-keyed dataset.) This is a > major bummer for open-source users who want to use UUIDs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 13: Code-Review+2 Forwarding +2 from Ali Alsuliman. -- To view, visit https://asterix-gerrit.ics.uci.edu/3370 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22100d3ff29864b8bfd54b0decb183e5056fdb4a Gerrit-Change-Number: 3370 Gerrit-PatchSet: 13 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 10:29:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 13: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/oMQaAqx7V3Q3Njc39 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3370 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22100d3ff29864b8bfd54b0decb183e5056fdb4a Gerrit-Change-Number: 3370 Gerrit-PatchSet: 13 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 10:12:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 13: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/DLvUJDkBbSeoan678 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3370 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22100d3ff29864b8bfd54b0decb183e5056fdb4a Gerrit-Change-Number: 3370 Gerrit-PatchSet: 13 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 09:23:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 12: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8563/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 12 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 09:20:05 + Gerrit-HasComments: No
[jira] [Resolved] (ASTERIXDB-2556) Hash join should handle fail() and close() properly when in the failed state
[ https://issues.apache.org/jira/browse/ASTERIXDB-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alsuliman resolved ASTERIXDB-2556. -- Resolution: Fixed > Hash join should handle fail() and close() properly when in the failed state > > > Key: ASTERIXDB-2556 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2556 > Project: Apache AsterixDB > Issue Type: Bug > Components: HYR - Hyracks, RT - Runtime >Affects Versions: 0.9.4 >Reporter: Ali Alsuliman >Assignee: Ali Alsuliman >Priority: Major > Labels: triaged > Fix For: 0.9.5 > > > When opening the pipeline, the hash join operator open() could throw an > exception due to some checks. Then, when the upstream operator tries to > fail() and close() the pipeline due to this failure, the hash join operator > would process close() as if the pipeline was not in the failed state. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 13: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/ERefQw9ffjCoY1WBA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3370 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22100d3ff29864b8bfd54b0decb183e5056fdb4a Gerrit-Change-Number: 3370 Gerrit-PatchSet: 13 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 08:17:31 + Gerrit-HasComments: No
[jira] [Assigned] (ASTERIXDB-2556) Hash join should handle fail() and close() properly when in the failed state
[ https://issues.apache.org/jira/browse/ASTERIXDB-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alsuliman reassigned ASTERIXDB-2556: Assignee: Ali Alsuliman > Hash join should handle fail() and close() properly when in the failed state > > > Key: ASTERIXDB-2556 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2556 > Project: Apache AsterixDB > Issue Type: Bug > Components: HYR - Hyracks, RT - Runtime >Affects Versions: 0.9.4 >Reporter: Ali Alsuliman >Assignee: Ali Alsuliman >Priority: Major > Labels: triaged > Fix For: 0.9.5 > > > When opening the pipeline, the hash join operator open() could throw an > exception due to some checks. Then, when the upstream operator tries to > fail() and close() the pipeline due to this failure, the hash join operator > would process close() as if the pipeline was not in the failed state. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ASTERIXDB-2556) Hash join should handle fail() and close() properly when in the failed state
[ https://issues.apache.org/jira/browse/ASTERIXDB-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alsuliman updated ASTERIXDB-2556: - Labels: triaged (was: ) > Hash join should handle fail() and close() properly when in the failed state > > > Key: ASTERIXDB-2556 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2556 > Project: Apache AsterixDB > Issue Type: Bug > Components: HYR - Hyracks, RT - Runtime >Affects Versions: 0.9.4 >Reporter: Ali Alsuliman >Priority: Major > Labels: triaged > Fix For: 0.9.5 > > > When opening the pipeline, the hash join operator open() could throw an > exception due to some checks. Then, when the upstream operator tries to > fail() and close() the pipeline due to this failure, the hash join operator > would process close() as if the pipeline was not in the failed state. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ASTERIXDB-2564) Too many objects created in min() and max()
[ https://issues.apache.org/jira/browse/ASTERIXDB-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alsuliman resolved ASTERIXDB-2564. -- Resolution: Fixed > Too many objects created in min() and max() > --- > > Key: ASTERIXDB-2564 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2564 > Project: Apache AsterixDB > Issue Type: Bug > Components: RT - Runtime >Affects Versions: 0.9.4 >Reporter: Ali Alsuliman >Assignee: Ali Alsuliman >Priority: Major > Fix For: 0.9.5 > > > min() and max() functions create a new comparator when switching to new > aggregation type. That is when they encounter a double and the previous input > values were int. The logic checks if the promotion is possible and then > switch. By definition, double -> double promotion is always possible (calling > canPromote(double, double) will always return true). This will lead to > "switching" aggregation type and creating a new comparator with every tuple > even though switching here is not necessary since double and double are the > same types. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ASTERIXDB-2554) Add UTF8 String comparator factories and byte array comparator factory
[ https://issues.apache.org/jira/browse/ASTERIXDB-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alsuliman resolved ASTERIXDB-2554. -- Resolution: Fixed > Add UTF8 String comparator factories and byte array comparator factory > -- > > Key: ASTERIXDB-2554 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2554 > Project: Apache AsterixDB > Issue Type: Bug > Components: HYR - Hyracks >Affects Versions: 0.9.4 >Reporter: Ali Alsuliman >Assignee: Ali Alsuliman >Priority: Major > Fix For: 0.9.5 > > > Add comparator factories for UTF8StringPointable, > UTF8StringLowercasePointable, UTF8StringLowercaseTokenPointable and > ByteArrayPointable instead of using PointableBinaryComparatorFactory, a > wrapping factory that will create a factory each time (which also creates a > comparator each time). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ASTERIXDB-2552) Implement micro external sort operator for subplans
[ https://issues.apache.org/jira/browse/ASTERIXDB-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alsuliman resolved ASTERIXDB-2552. -- Resolution: Fixed > Implement micro external sort operator for subplans > --- > > Key: ASTERIXDB-2552 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2552 > Project: Apache AsterixDB > Issue Type: Bug > Components: RT - Runtime >Affects Versions: 0.9.4 >Reporter: Ali Alsuliman >Assignee: Ali Alsuliman >Priority: Major > Fix For: 0.9.4.2 > > > The external sort operator deals gracefully with insufficient memory. > However, the sort operator that is used in subplans currently is in memory > sort and not an external sort and thus could run out of memory. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ASTERIXDB-2481) Out of Memory error doing aggregation - need a bound
[
https://issues.apache.org/jira/browse/ASTERIXDB-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840155#comment-16840155
]
Ali Alsuliman commented on ASTERIXDB-2481:
--
[~psinthon]
Hi Gift,
Few changed have been merged to master that are related to listify, in memory
sort, and out of memory issue. One change is related to eliminating listify
from the plan when it is possible. The second change is to make the in memory
sort spill to disk when the memory budget is hit.
Could you please check if you are facing the same issue. It would be nice to
post the plan, too.
> Out of Memory error doing aggregation - need a bound
>
>
> Key: ASTERIXDB-2481
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2481
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: COMP - Compiler, RT - Runtime, SQL - Translator SQL++
>Affects Versions: 0.9.4
> Environment: Linux
>Reporter: Gift Sinthong
>Assignee: Ali Alsuliman
>Priority: Critical
> Fix For: 0.9.4.2
>
> Attachments: Screen Shot 2018-11-14 at 3.12.31 PM.png, cc.log,
> nc-1.log
>
>
> This is the schema:
> {noformat}
> CREATE TYPE Test AS open { unique2: int64 };
> CREATE DATASET wisconsin_5gb(Test) PRIMARY KEY unique2;
> {noformat}
> This is the query:
> {noformat}
> SELECT
> min(t.oddOnePercent) as min,
> max(t.oddOnePercent) as max,
> count(distinct t.oddOnePercent) as cnt
> FROM wisconsin_5gb t;
> {noformat}
> The plan for this query:
> {noformat}
> distribute result [$$46]
> -- DISTRIBUTE_RESULT |UNPARTITIONED|
> exchange
> -- ONE_TO_ONE_EXCHANGE |UNPARTITIONED|
> project ([$$46])
> -- STREAM_PROJECT |UNPARTITIONED|
> assign [$$46] <- [{"min": $$48, "max": $$49, "cnt": $$50}]
> -- ASSIGN |UNPARTITIONED|
> project ([$$48, $$49, $$50])
> -- STREAM_PROJECT |UNPARTITIONED|
> subplan {
> aggregate [$$50] <- [agg-sql-sum($$53)]
> -- AGGREGATE |LOCAL|
> aggregate [$$53] <- [agg-sql-count($$43)]
> -- AGGREGATE |LOCAL|
> distinct ([$$43])
> -- MICRO_PRE_SORTED_DISTINCT_BY |LOCAL|
> order (ASC, $$43)
> -- IN_MEMORY_STABLE_SORT [$$43(ASC)] |LOCAL|
> assign [$$43] <- [$$52.getField("oddOnePercent")]
> -- ASSIGN |UNPARTITIONED|
> assign [$$52] <- [$#4.getField(0)]
> -- ASSIGN |UNPARTITIONED|
> unnest $#4 <- scan-collection($$28)
> -- UNNEST |UNPARTITIONED|
> nested tuple source
> -- NESTED_TUPLE_SOURCE |UNPARTITIONED|
> }
> -- SUBPLAN |UNPARTITIONED|
> aggregate [$$28, $$48, $$49] <- [listify($$27),
> agg-sql-min($$33), agg-sql-max($$33)]
> -- AGGREGATE |UNPARTITIONED|
> exchange
> -- RANDOM_MERGE_EXCHANGE |PARTITIONED|
> project ([$$27, $$33])
> -- STREAM_PROJECT |PARTITIONED|
> assign [$$33, $$27] <- [$$t.getField("oddOnePercent"),
> {"t": $$t}]
> -- ASSIGN |PARTITIONED|
> project ([$$t])
> -- STREAM_PROJECT |PARTITIONED|
> exchange
> -- ONE_TO_ONE_EXCHANGE |PARTITIONED|
> data-scan []<-[$$47, $$t] <- Default.wisconsin_5gb
> -- DATASOURCE_SCAN |PARTITIONED|
> exchange
> -- ONE_TO_ONE_EXCHANGE |PARTITIONED|
> empty-tuple-source
> -- EMPTY_TUPLE_SOURCE |PARTITIONED|
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5801/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 12 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 08:02:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1152/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 12 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 08:11:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 12: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/wx6aDqk7s6zztMpX6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 12 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 08:07:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 12: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8563/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 12 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 15 May 2019 08:04:50 + Gerrit-HasComments: No
