Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8583/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 04:46:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/Nv5qVETbuAmtCZh5A : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 04:57:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4433/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:50:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5822/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:34:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Hello Anon. E. Moose (1000171), Till Westmann, Jenkins, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3400 to look at the new patch set (#10). Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. [ASTERIXDB-2288][COMP] Fix field access with UNION - user model changes: no - storage format changes: no - interface changes: no Details: For UNION, if there is an assign operator above UNION, the optimizer will move the assign operator under UNION into both branches. If the assign operator has field access by index, the index is based on the output record of the union operator which could be different from the field index in left and right branches. The fix is to map the index to the correct index of the input operator where the assign is copied to. Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixPushAssignBelowUnionAllRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.4.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.6.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.7.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.4.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.5.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.6.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushAssignBelowUnionAllRule.java 15 files changed, 397 insertions(+), 21 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/00/3400/10 -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/745/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8583/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:36:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/PPYdY49Ed9S4xTfz9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:38:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:38:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4433/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:37:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5972/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3816/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:34:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6177/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5804/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/586/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:34:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1081/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6027/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:34:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9763/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:34:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5785/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:34:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11296/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1172/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6387/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5721/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 10: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/983/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 10 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:33:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/oi4z4QqoHoHCNWTm7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 03:02:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8582/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 02:52:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5784/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 02:56:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4432/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:56:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:43:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5720/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/982/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3400/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAssignBelowUnionAllRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAssignBelowUnionAllRule.java: https://asterix-gerrit.ics.uci.edu/#/c/3400/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAssignBelowUnionAllRule.java@196 PS8, Line 196: > I'd move this 'if' outside of this method into modifyExpression loop. So li Done. a bit different now with the new logic. https://asterix-gerrit.ics.uci.edu/#/c/3400/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAssignBelowUnionAllRule.java@220 PS8, Line 220: > what if it returns -1 (not found)? hmm. i don't think the assign can be pushed in this case (even though it should not happen). i changed the logic now to not push the assign. -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:43:09 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/AZYwMw6P8q4RxZqA8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:43:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4432/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:42:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8582/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:41:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5783/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11295/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5821/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:23 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/585/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5971/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Hello Anon. E. Moose (1000171), Till Westmann, Jenkins, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3400 to look at the new patch set (#9). Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. [ASTERIXDB-2288][COMP] Fix field access with UNION - user model changes: no - storage format changes: no - interface changes: no Details: For UNION, if there is an assign operator above UNION, the optimizer will move the assign operator under UNION into both branches. If the assign operator has field access by index, the index is based on the output record of the union operator which could be different from the field index in left and right branches. The fix is to map the index to the correct index of the input operator where the assign is copied to. Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixPushAssignBelowUnionAllRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.4.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.6.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.7.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.4.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.5.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/field_access_union-ASTERIXDB-2288/field_access_union-ASTERIXDB-2288.6.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushAssignBelowUnionAllRule.java 15 files changed, 396 insertions(+), 21 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/00/3400/9 -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1171/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3815/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5803/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6176/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1080/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6386/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6026/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/744/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9762/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 9 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Tue, 21 May 2019 01:39:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 13: (12 comments) Not done yet, but here's the first batch of comments. https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java: https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@317 PS13, Line 317: if (value > Long.MAX_VALUE || value < Long.MIN_VALUE || value > Math.floor(value)) { Do we need to handle NaN here? https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@327 PS13, Line 327: if (value > Long.MAX_VALUE || value < Long.MIN_VALUE || value > Math.floor(value)) { Do we need to handle NaN here? https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@351 PS13, Line 351: public static long getLongValue(byte[] bytes, int startOffset, ATypeTag typeTag) throws HyracksDataException { We already have ATypeHierarchy.getLongValue(). Can we use that instead of creating a new method? https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitMultipleValuesEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitMultipleValuesEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitMultipleValuesEvaluator.java@150 PS13, Line 150: applyBitwiseOperation(resultMutableInt64.getLongValue(), nextValue); there's no need to use resultMutableInt64 at all in this loop. If you change applyBitWiseOperation() to return 'long' instead of 'void', then we can avoid writing/reading to/from resultMutableInt64 while looping. We'll only need to write the value there to serialize the result https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitSingleValueEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitSingleValueEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitSingleValueEvaluator.java@58 PS13, Line 58: final AMutableInt32 resultMutableInt32 = new AMutableInt32(0); bitnot() only uses int64 mutable/serde, but bitcount() only uses int32 mutable/serde, but this abstract evaluator always creates both pairs. Should we create move those mutable/serdes to each subclass, so only one pair is created? https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitSingleValueEvaluator.java@103 PS13, Line 103: resultMutableInt64.setValue(PointableHelper.getLongValue(bytes, startOffset + 1, typeTag)); why do we need to write the value to resultMutableInt64 and then immediately read it from there in line 111? just pass the long value we got from getLongValue() to applyBitwiseOperation() https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java@85 PS13, Line 85: final IPointable flagPointable = new VoidPointable(); We don't need to create this object if there's no flagEvaluator available. https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java@104 PS13, Line 104: flagEvaluator = hasFlagArgument ? argEvaluatorFactories[2].createScalarEvaluator(context) : null; do you need hasFlagArgument at all? Check the length of argEvaluatorFactories and if it's more than 2 then we have it, otherwise not.
Change in asterixdb[master]: [ASTERIXDB-2288][COMP] Fix field access with UNION
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3400 ) Change subject: [ASTERIXDB-2288][COMP] Fix field access with UNION .. Patch Set 8: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3400/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAssignBelowUnionAllRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAssignBelowUnionAllRule.java: https://asterix-gerrit.ics.uci.edu/#/c/3400/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAssignBelowUnionAllRule.java@196 PS8, Line 196: if (!functionCall.getFunctionIdentifier().equals(BuiltinFunctions.FIELD_ACCESS_BY_INDEX)) { I'd move this 'if' outside of this method into modifyExpression loop. So line 190 would be: if (functionCall.getFunctionIdentifier().equals(BuiltinFunctions.FIELD_ACCESS_BY_INDEX)) { mapFieldIndex(...) } https://asterix-gerrit.ics.uci.edu/#/c/3400/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAssignBelowUnionAllRule.java@220 PS8, Line 220: fieldIndex = inputType.getFieldIndex(fieldName); what if it returns -1 (not found)? -- To view, visit https://asterix-gerrit.ics.uci.edu/3400 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d65374aca6959fd5e70279fac8f7f0a6c7c64c5 Gerrit-Change-Number: 3400 Gerrit-PatchSet: 8 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 20 May 2019 22:33:58 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 13: Analytics Compatibility Tests Failed https://cbjenkins.page.link/mgWBohBQHZfM8LVb6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 13 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Mon, 20 May 2019 16:07:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/Ynf3VP96dhGgfCUZ7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 14:39:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8581/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 14:15:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1170/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:09:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4431/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:17:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5719/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/KhnSvMU2BKdYoWvc9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:05:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4431/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:04:06 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8581/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:02:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9761/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6385/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11294/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6025/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1079/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5820/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/743/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5782/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5970/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/584/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:55 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5802/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:01:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6175/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/981/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3393 ) Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3814/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 20 May 2019 13:00:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Hello Anon. E. Moose (1000171), Jenkins, Hussain Towaileb, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3393 to look at the new patch set (#3). Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests .. [ASTERIXDB-2569][TEST] Refactor type computer tests - user model changes: no - storage format changes: no - interface changes: no Details: - Converted type computer tests to be parameterized. - Moved the tests to appropriate packages to use the log4j logger. - Type computer instances check is based on the field type instead of field name. Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 --- M asterixdb/asterix-om/pom.xml D asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java D asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java A asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java A asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java R asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/util/JSONDeserializerForTypesTest.java 6 files changed, 471 insertions(+), 301 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/93/3393/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3393 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Gerrit-Change-Number: 3393 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins