Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/6GKruoLTYMQCJBoW6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 04:14:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8592/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 04:05:23 + Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2576) Implement multisets comparison
Ali Alsuliman created ASTERIXDB-2576: Summary: Implement multisets comparison Key: ASTERIXDB-2576 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2576 Project: Apache AsterixDB Issue Type: Bug Components: RT - Runtime Reporter: Ali Alsuliman Assignee: Ali Alsuliman -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ASTERIXDB-2575) Remove usages of ComparisonHelper and switch to logical or physical comparators
Ali Alsuliman created ASTERIXDB-2575: Summary: Remove usages of ComparisonHelper and switch to logical or physical comparators Key: ASTERIXDB-2575 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2575 Project: Apache AsterixDB Issue Type: Bug Components: COMP - Compiler, RT - Runtime Reporter: Ali Alsuliman Assignee: Ali Alsuliman Remove usages of ComparisonHelper and switch to logical or physical comparators -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ASTERIXDB-2574) Inconsistency in min() and max() with respect to arrays/records
Ali Alsuliman created ASTERIXDB-2574: Summary: Inconsistency in min() and max() with respect to arrays/records Key: ASTERIXDB-2574 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2574 Project: Apache AsterixDB Issue Type: Bug Components: FUN - Functions Reporter: Ali Alsuliman Assignee: Ali Alsuliman min() and max() functions used on record/array fields sometimes throw an exception and other times process input. That's because if the field type is known the compiler will validate and check the field is numeric, string or datetime. If the field type is not known (ANY), it would pass and the function runtime would process the input data. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4441/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 03:11:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5831/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:23 + Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2573) Refactor ascending & ignore case flags used in comparator provider
Ali Alsuliman created ASTERIXDB-2573: Summary: Refactor ascending & ignore case flags used in comparator provider Key: ASTERIXDB-2573 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2573 Project: Apache AsterixDB Issue Type: Bug Components: COMP - Compiler Reporter: Ali Alsuliman Assignee: Ali Alsuliman -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ASTERIXDB-2572) Fix getting a descending comparator for SHORTWITHOUTTYPEINFO
Ali Alsuliman created ASTERIXDB-2572: Summary: Fix getting a descending comparator for SHORTWITHOUTTYPEINFO Key: ASTERIXDB-2572 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2572 Project: Apache AsterixDB Issue Type: Bug Components: COMP - Compiler Reporter: Ali Alsuliman Assignee: Ali Alsuliman SHORTWITHOUTTYPEINFO comparators are normally used in inverted index which is always ascending. But comparator provider should handle getting a descending one regardless of who will be using it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/595/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4441/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:54:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/JvnqvTR3WSZ3N3nG6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:55:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1181/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8592/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:52:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1090/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6396/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5981/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6186/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9772/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3825/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11305/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/992/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5794/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5813/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6036/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/754/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5730/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3404 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151 Gerrit-Change-Number: 3404 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 02:51:15 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
Ali Alsuliman has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3404
Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get
comparator
..
[ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
UNION should not be allowed when getting a comparator by tag.
The comparator provider returns a generic comparator with types
ANY when UNION is passed as a tag. This could cause problems if
the actual type is a complex type. UNION should not be allowed.
Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151
---
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/04/3404/1
diff --git
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java
index 396bf3b..5f59a41 100644
---
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java
+++
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java
@@ -35,6 +35,7 @@
import org.apache.asterix.om.types.ATypeTag;
import org.apache.asterix.om.types.BuiltinType;
import org.apache.asterix.om.types.IAType;
+import org.apache.hyracks.algebricks.common.exceptions.NotImplementedException;
import org.apache.hyracks.algebricks.data.IBinaryComparatorFactoryProvider;
import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
import org.apache.hyracks.data.std.accessors.BooleanBinaryComparatorFactory;
@@ -115,10 +116,9 @@
public IBinaryComparatorFactory getBinaryComparatorFactory(ATypeTag type,
boolean ascending) {
switch (type) {
case ANY:
-case UNION:
-// i think UNION shouldn't be allowed. the actual type could
be closed array or record. ANY would fail.
-// we could do smth better for nullable fields
return createGenericBinaryComparatorFactory(BuiltinType.ANY,
BuiltinType.ANY, ascending);
+case UNION:
+throw new NotImplementedException("No comparator for type
UNION");
case NULL:
case MISSING:
return new AnyBinaryComparatorFactory();
--
To view, visit https://asterix-gerrit.ics.uci.edu/3404
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8816a0dc5584f0a27410c512f3a44ccfc6c3151
Gerrit-Change-Number: 3404
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/L3s9pjGtMryZvJqF9 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 01:14:00 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8591/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 00:43:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/38mxmC5EfqBXMJfr8 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 00:33:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4440/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:50:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/bN5SXAQT3RPttBWK6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:34:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4440/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:33:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5793/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11304/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5812/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8591/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:31:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/594/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1089/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1180/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6395/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6035/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9771/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/991/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5980/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/753/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3824/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6185/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5830/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5729/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Hussain Towaileb has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3403
Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes
..
[NO ISSUE][FUN] Remove unnecessary inner classes
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Remove unnecessary inner classes. Use the evaluator
factories length to check if the end position argument
is passed.
Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f
---
R
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithEndPositionDescriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithoutEndPositionDescriptor.java
3 files changed, 23 insertions(+), 59 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/03/3403/1
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
similarity index 90%
rename from
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
rename to
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
index 036447a..c907720 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
@@ -75,32 +75,31 @@
*
*/
-public abstract class AbstractArraySliceEval extends AbstractScalarEval {
+class ArraySliceEvaluator extends AbstractScalarEval {
+
// List type
private final IAType inputListType;
// Storage
-private final ArrayBackedValueStorage storage = new
ArrayBackedValueStorage();
+private final ArrayBackedValueStorage resultStorage = new
ArrayBackedValueStorage();
-// Evaluators
+// Evaluators and pointables
private final IScalarEvaluator listEval;
private final IScalarEvaluator startPositionEval;
-private final IScalarEvaluator endPositionEval;
-
-// Pointables
+private IScalarEvaluator endPositionEval;
private final IPointable listPointable = new VoidPointable();
private final IPointable startPositionPointable = new VoidPointable();
-private final IPointable endPositionPointable = new VoidPointable();
+private IPointable endPositionPointable;
// Accessors
private final ListAccessor listAccessor = new ListAccessor();
// List Builders
-private IAsterixListBuilder orderedListBuilder = new OrderedListBuilder();
-private IAsterixListBuilder unorderedListBuilder = new
UnorderedListBuilder();
+private final IAsterixListBuilder orderedListBuilder = new
OrderedListBuilder();
+private final IAsterixListBuilder unorderedListBuilder = new
UnorderedListBuilder();
// Constructor
-public AbstractArraySliceEval(IScalarEvaluatorFactory[] args,
IHyracksTaskContext ctx, SourceLocation sourceLoc,
+ArraySliceEvaluator(IScalarEvaluatorFactory[] argEvalFactories,
IHyracksTaskContext ctx, SourceLocation sourceLoc,
FunctionIdentifier functionIdentifier, IAType inputListType)
throws HyracksDataException {
// Source location
super(sourceLoc, functionIdentifier);
@@ -109,20 +108,18 @@
this.inputListType = inputListType;
// Evaluators
-listEval = args[0].createScalarEvaluator(ctx);
-startPositionEval = args[1].createScalarEvaluator(ctx);
+listEval = argEvalFactories[0].createScalarEvaluator(ctx);
+startPositionEval = argEvalFactories[1].createScalarEvaluator(ctx);
// Check for optional parameter
-endPositionEval = getEndPositionEval(args, ctx);
+if (argEvalFactories.length > 2) {
+endPositionEval = argEvalFactories[2].createScalarEvaluator(ctx);
+endPositionPointable = new VoidPointable();
+}
}
-
-protected abstract IScalarEvaluator
getEndPositionEval(IScalarEvaluatorFactory[] args, IHyracksTaskContext ctx)
-throws HyracksDataException;
@Override
public void evaluate(IFrameTupleReference tuple, IPointable result) throws
HyracksDataException {
-// Reset storage
-storage.reset();
// Evaluate
listEval.evaluate(tuple, listPointable);
@@ -231,18 +228,18 @@
try {
// Create the subset list based on the positions
for (int i = startPositionValue; i < endPositionValue; i++) {
-storage.reset();
-
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11303/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5979/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8590/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:41:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3823/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6184/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/rMxYuDsEhxMnq7Mk8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:39:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5728/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8590/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5829/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5811/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/593/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5792/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6394/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1088/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1179/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/752/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/990/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9770/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6034/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3822/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:44 + Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2571) Memory assigned out of the budget in hash join for large objects
Shiva Jahangiri created ASTERIXDB-2571: -- Summary: Memory assigned out of the budget in hash join for large objects Key: ASTERIXDB-2571 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2571 Project: Apache AsterixDB Issue Type: Bug Components: *DB - AsterixDB Affects Versions: 0.9.4.1 Reporter: Shiva Jahangiri Currently in optimized hybrid hash join in case of lack of memory asterix flushes the big prob object to the disk. For flushing a big object, a variable sized frame will be created from hyracks context not join memory budget. This means we may use more than the given budget. Possible solutions: 1) Have a way to flush the incoming frame/buffer directly to the disk. 2) Spill enough data to be able to fit the large object(less preferred as it hurts the performance). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8589/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:30:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Contrib-2 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4439/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5791/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11302/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Contrib-2 Analytics Compatibility Compilation Failed https://cbjenkins.page.link/66TM6a5zxKhCA8wbA : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:25:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8589/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:25:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4439/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:24:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5978/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9769/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/751/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1087/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/989/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1178/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6183/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6033/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6393/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5810/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/592/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3402 Change subject: [WIP] Convert docs from markdown to asciidoc .. [WIP] Convert docs from markdown to asciidoc Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 --- M asterixdb/asterix-doc/pom.xml A asterixdb/asterix-doc/src/main/asciidoc/builtins/0_toc.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/10_comparison.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/11_type.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/12_misc.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/13_conditional.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/1_numeric_common.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/1_numeric_delta.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/2_string_common.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/2_string_delta.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/3_binary.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/4_spatial.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/5_similarity.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/6_tokenizing.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/7_allens.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/7_temporal.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/8_record.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/9_aggregate_aql.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/9_aggregate_sql.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_composite.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_header.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_incomplete.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_primitive_common.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_primitive_delta.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/0_toc.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/1_intro.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/2_expr.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/2_expr_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/3_declare_dataverse.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/3_declare_function.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/3_query.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/3_query_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/4_error.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/4_error_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/5_ddl_dataset_index.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/5_ddl_dml.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/5_ddl_function_removal.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/5_ddl_head.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_1_keywords.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_1_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_2_index_only.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_2_parameters.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_2_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_3_resolution.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_3_title.adoc A asterixdb/asterix-doc/src/main/data_ingestion/feeds.adoc D asterixdb/asterix-doc/src/main/data_ingestion/feeds.md A asterixdb/asterix-doc/src/main/data_ingestion/feeds_title.adoc D asterixdb/asterix-doc/src/main/data_ingestion/feeds_title.md A asterixdb/asterix-doc/src/main/installation/ansible.adoc D asterixdb/asterix-doc/src/main/installation/ansible.md A asterixdb/asterix-doc/src/main/installation/ansible_title.adoc D asterixdb/asterix-doc/src/main/installation/ansible_title.md A asterixdb/asterix-doc/src/main/installation/aws.adoc D asterixdb/asterix-doc/src/main/installation/aws.md A asterixdb/asterix-doc/src/main/installation/aws_title.adoc D asterixdb/asterix-doc/src/main/installation/aws_title.md D asterixdb/asterix-doc/src/main/markdown/builtins/0_toc.md D asterixdb/asterix-doc/src/main/markdown/builtins/10_comparison.md D asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md D asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md D asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md D asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md D asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_delta.md D asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md D asterixdb/asterix-doc/src/main/markdown/builtins/2_string_delta.md D asterixdb/asterix-doc/src/main/markdown/builtins/3_binary.md D asterixdb/asterix-doc/src/main/markdown/builtins/4_spatial.md D asterixdb/asterix-doc/src/main/markdown/builtins/5_similarity.md D
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5727/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5828/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:29 + Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2570) Add documentation for bitwise functions
Hussain Towaileb created ASTERIXDB-2570: --- Summary: Add documentation for bitwise functions Key: ASTERIXDB-2570 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2570 Project: Apache AsterixDB Issue Type: Improvement Components: DOC - Documentation Affects Versions: 0.9.4 Reporter: Hussain Towaileb Assignee: Hussain Towaileb Fix For: 0.9.5 Need to add documentation for the bitwise functions -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ASTERIXDB-2562) Add support for bitwise functions.
[ https://issues.apache.org/jira/browse/ASTERIXDB-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hussain Towaileb resolved ASTERIXDB-2562. - Resolution: Fixed > Add support for bitwise functions. > -- > > Key: ASTERIXDB-2562 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2562 > Project: Apache AsterixDB > Issue Type: Improvement > Components: FUN - Functions >Affects Versions: 0.9.4 >Reporter: Hussain Towaileb >Assignee: Hussain Towaileb >Priority: Major > Fix For: 0.9.5 > > > Add support for bitwise functions. The bitwise functions operate on int64 > signed integers. > BITAND > BITCLEAR > BITNOT > BITOR > BITSET > BITSHIFT > BITTEST > BITXOR > BITCOUNT > ISBITSET (is a synonym for BITTEST) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ASTERIXDB-2562) Add support for bitwise functions.
[ https://issues.apache.org/jira/browse/ASTERIXDB-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846179#comment-16846179 ] ASF subversion and git services commented on ASTERIXDB-2562: Commit c420e45165187c14fdc61d0c631c4c1bc5df76e5 in asterixdb's branch refs/heads/master from Hussain Towaileb [ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=c420e45 ] [ASTERIXDB-2562][FUN] Add support for bitwise functions - user model changes: yes Added AND, OR, XOR, NOT, SET, CLEAR, SHIFT, TEST, ISSET and COUNT bitwise functions. - storage format changes: no - interface changes: no Details: - Introduced the AND, OR, XOR, NOT, SET, CLEAR, SHIFT, TEST, ISSET and COUNT bitwise functions. - Added test cases. Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3377 Contrib: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Dmitry Lychagin > Add support for bitwise functions. > -- > > Key: ASTERIXDB-2562 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2562 > Project: Apache AsterixDB > Issue Type: Improvement > Components: FUN - Functions >Affects Versions: 0.9.4 >Reporter: Hussain Towaileb >Assignee: Hussain Towaileb >Priority: Major > Fix For: 0.9.5 > > > Add support for bitwise functions. The bitwise functions operate on int64 > signed integers. > BITAND > BITCLEAR > BITNOT > BITOR > BITSET > BITSHIFT > BITTEST > BITXOR > BITCOUNT > ISBITSET (is a synonym for BITTEST) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Noted, I'll make sure to address your comments in future changes, I'll merge this one for now. -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 19:28:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Code-Review+2 (2 comments) I think we can merge it, but there's one thing we should improve. 1. We need to add tests where each function is called multiple times. something like. FROM range(0, 10) i SELECT VALUE bitset(i , ..) . The purpose is to test how each function runtime performs on subsequent invocations. (we can do this in a separate change) 2. (minor) You're using the following pattern in test queries. "t1" : (SELECT VALUE f(...))[0] It works but is equivalent to just "t1": f(...) We can keep existing tests as is because they work fine. This is just for future reference. https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java@123 PS13, Line 123: > checkAndSetMissingOrNull() only assumes the first 2 arguments are not null, I think it's fine. flagPointable was never null in your previous code, that's why I made this comment. but if it's always null if there's no flag, then passing it to checkAndSetMissingOrNull is ok. Regarding assuming that first 2 arguments are not null. I think it's ok to do. Those two should alway be present, otherwise there's no point in calling checkAndSetMissingOrNull method. https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java: https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java@130 PS13, Line 130: > It seems in both cases, the item gets written eventually to the provided po Yes, you're right. So we don't need to look at the result value -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 19:10:15 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/aCs1GDLtrvbXXcgy9 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 17:01:20 + Gerrit-HasComments: No
