Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/J7EjaHQuiUhdkL5PA : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Comment-Date: Fri, 07 Jun 2019 05:15:43 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8665/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Comment-Date: Fri, 07 Jun 2019 05:03:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/ZSdq8kzj9NuG2ojVA : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 04:22:55 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:54:00 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/DgfYF79C3gaxjt9F8 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:44:15 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8665/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:40:31 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/3430


Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..

[NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- To avoid cases where unintentional false comparison result happens
  due to a relative path of one FileReference starting with "/" and
  the other's does not, use the file absolute path in hashCode and
  equals.

Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/3430/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
index 4ded855..e4097ff 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
@@ -58,12 +58,12 @@
 if (!(o instanceof FileReference)) {
 return false;
 }
-return path.equals(((FileReference) o).path) && 
dev.equals(((FileReference) o).dev);
+return file.getAbsolutePath().equals(((FileReference) 
o).getAbsolutePath());
 }

 @Override
 public int hashCode() {
-return path.hashCode();
+return file.getAbsolutePath().hashCode();
 }

 /**

--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app-stabilization-f69489/103/
 (12/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:24 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5884/
 (9/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:18 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11377/ (8/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:17 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5867/ 
(11/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:22 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1253/
 (5/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:15 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1064/ (7/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:16 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6258/ 
(2/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:14 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9844/ (3/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:15 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5803/ 
(1/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:14 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5907/ 
(10/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:20 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6468/ (6/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:16 +
Gerrit-HasComments: No


Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3430 )

Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference 
hashCode/equals
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6108/ 
(4/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8664/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:38:50 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/dbKtcxCXVGudzSfg6 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:11:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8663/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:57:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4505/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:47:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1252/
 (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:35:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/zdKSHxKcg2Mv6LWh6 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:31:41 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4505/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:30:20 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

(1 comment)

> Patch Set 2:
>
> (1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3426/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java:

https://asterix-gerrit.ics.uci.edu/#/c/3426/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java@44
PS2, Line 44: datasou
> Should be "datasource" name I think, no?
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:29:17 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8664/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:28:44 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1063/ (15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:27 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6049/
 (14/16)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6467/ (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:24 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1159/
 (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6257/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/665/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5906/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11376/ (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:11 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/826/ 
(5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5883/
 (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3894/ 
(11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Till Westmann (Code Review)
Hello Anon. E. Moose (1000171), Hussain Towaileb, Jenkins, Murtadha Hubail, 
Dmitry Lychagin,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3426

to look at the new patch set (#3).

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..

[NO ISSUE][RT][COMP] Use more components to identify a datasource

- user model changes: no
- storage format changes: no
- interface changes: additional constructor for DataSourceId

Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorDatasource.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSourceId.java
2 files changed, 40 insertions(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/26/3426/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6107/ 
(10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5866/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:13 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5802/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3426 )

Change subject: [NO ISSUE][RT][COMP] Use more components to identify a 
datasource
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9843/ (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3426
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If371a6c7f8302ee7a83ddba0f1c6aeecdea4d5ef
Gerrit-Change-Number: 3426
Gerrit-PatchSet: 3
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:27:16 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4504/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 02:02:40 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/tS5p8zHL3mSuGTZT7 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:46:37 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4504/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:45:43 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/664/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:33 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3893/ 
(13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:34 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11375/ (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:40 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5865/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:38 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8663/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:44:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5905/ 
(14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:36 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6048/
 (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6256/ 
(9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:27 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1062/ (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6106/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5882/
 (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:29 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1158/
 (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5801/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1251/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:20 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/825/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9842/ (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar global/local functions

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar global/local functions
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6466/ (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:42:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has submitted this change and it was merged. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..

[NO ISSUE][SQLPP] Support SELECT LET

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Support SELECT ... LET ... (no FROM clause)
- Add CancelUnnestSingletonListRule to the optimizer
- Add negative testcase for unnamed field value
  expressions in object constructor

Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3428
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CancelUnnestSingletonListRule.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/flwr/select-let-1.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/flwr/select-let-1.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-1572.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/select-let/select-let.1.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/ObjectsQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/objects/no_fieldname_constr_negative/no_fieldname_constr_negative.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/flwor/select-let/select-let.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
11 files changed, 256 insertions(+), 70 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; Verified
  Anon. E. Moose (1000171):
  Dmitry Lychagin: Looks good to me, approved



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
index f9aecab..d5f2e00 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
@@ -32,6 +32,7 @@
 import org.apache.asterix.optimizer.rules.AsterixIntroduceGroupByCombinerRule;
 import org.apache.asterix.optimizer.rules.AsterixPushAssignBelowUnionAllRule;
 import org.apache.asterix.optimizer.rules.ByNameToByIndexFieldAccessRule;
+import org.apache.asterix.optimizer.rules.CancelUnnestSingletonListRule;
 import org.apache.asterix.optimizer.rules.CancelUnnestWithNestedListifyRule;
 import org.apache.asterix.optimizer.rules.CheckFilterExpressionTypeRule;
 import org.apache.asterix.optimizer.rules.CheckFullParallelSortRule;
@@ -203,6 +204,7 @@
 normalization.add(new PushAggFuncIntoStandaloneAggregateRule());
 normalization.add(new ListifyUnnestingFunctionRule());
 normalization.add(new RemoveRedundantSelectRule());
+normalization.add(new CancelUnnestSingletonListRule());
 normalization.add(new UnnestToDataScanRule());
 normalization.add(new MetaFunctionToMetaVariableRule());
 normalization.add(new FuzzyEqRule());
diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CancelUnnestSingletonListRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CancelUnnestSingletonListRule.java
new file mode 100644
index 000..ab7abdf
--- /dev/null
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CancelUnnestSingletonListRule.java
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.asterix.optimizer.rules;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.asterix.om.base.IACollection;
+import org.apache.asterix.om.base.IACursor;
+import org.apache.asterix.om.base.IAObject;
+import 

Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3: Code-Review+2

Forwarding Ali's +2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 23:56:29 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/rJ61YASspLj5kRgM6 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 23:02:04 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8662/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 22:51:44 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/NaKJdQmNsCLqr4FV8 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:44:00 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6047/
 (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3892/ 
(13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5904/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:57 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/663/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:59 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8662/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:41:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/824/ 
(14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:56 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1250/
 (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1157/
 (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5800/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9841/ (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1061/ (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6465/ (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5864/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11374/ (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5881/
 (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6105/ 
(5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6255/ 
(10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 3
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:39:54 +
Gerrit-HasComments: No


[jira] [Commented] (ASTERIXDB-2574) Inconsistency in min() and max() with respect to arrays/records

2019-06-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858103#comment-16858103
 ] 

ASF subversion and git services commented on ASTERIXDB-2574:


Commit 77450e6a1ad081d2dc2d00b2847f45d8b9a407e5 in asterixdb's branch 
refs/heads/master from Ali Alsuliman
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=77450e6 ]

[ASTERIXDB-2574][COMP] Fix min/max functions

- user model changes: no
- storage format changes: no
- interface changes: no

This change is mainly for 2 things. The first thing is to not throw
an exception when the type of the aggregated field is invalid for min/max
(e.g. record or rectange) or min/max get incompatible data like string
and int. The result in this case would be NULL. The second thing is to
enable comparing ARRAYs correctly by using logical comparison. When
a partition runs into type invalidity, it will output NULL. The global
aggregator interprets NULL received from a partition as type invalidity
and outputs NULL as the final result. Both SQL and SQL++ will do that.
Special treatment is needed for scalar and distinct version of SQL since
SQL min/max ignores NULL values and continue aggregation and the scalar
and distinct version of SQL are normally setup as a global aggregator
since they behave like the global aggregator in a two-step aggregation.
Currently, there is only a local min and max functions. The other
min/max functions are used for everything, the global function of
two-step aggregation, and for scalar and distinct min/max. In order to
differentiate, a global min/max functions are added that will be used
for the two-step aggregation.

Details:
- fixed listify to open up elements when adding them to the collection
and the collection item type is of type ANY and changed the type inferer
of listify to enable that.
- fixed AbstractCollectionType to make sure itemType is never null.
- changed MinMaxAggTypeComputer to not throw an exception but return
NULL for invalid types.
- changed min/max descriptors to implement inferer to propagate the
type of the field and pass that when getting a comparator.
- switched min/max comparison to the logical comparison.
- refactored method inequalityUndefined to be shared by logical comparison
and min/max functions.
- added global max/min functions to enable differentiating between
scalar min/max, distinct min/max and two-step min/max (global & local).
- code clean-up for LogicalScalarBinaryComparator; created two INSTANCES
and re-used.

Change-Id: I1231cfe558099d167bae0b2fa7fc4879b756baf0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3427
Contrib: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 


> Inconsistency in min() and max() with respect to arrays/records
> ---
>
> Key: ASTERIXDB-2574
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2574
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: FUN - Functions
>Affects Versions: 0.9.4.1
>Reporter: Ali Alsuliman
>Assignee: Ali Alsuliman
>Priority: Major
>
> min() and max() functions used on record/array fields sometimes throw an 
> exception and other times process input. That's because if the field type is 
> known the compiler will validate and check the field is numeric, string or 
> datetime. If the field type is not known (ANY), it would pass and the 
> function runtime would process the input data.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb[master]: [ASTERIXDB-2574][COMP] Fix min/max functions

2019-06-06 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3427 )

Change subject: [ASTERIXDB-2574][COMP] Fix min/max functions
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3427/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java:

https://asterix-gerrit.ics.uci.edu/#/c/3427/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java@42
PS2, Line 42: // TODO(ali): this should be removed. itemType is already 
enforced to be NonNull
> I think we need to investigate the intent of this method. May be we should
agreed.



--
To view, visit https://asterix-gerrit.ics.uci.edu/3427
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1231cfe558099d167bae0b2fa7fc4879b756baf0
Gerrit-Change-Number: 3427
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:24:52 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2574][COMP] Fix min/max functions

2019-06-06 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3427 )

Change subject: [ASTERIXDB-2574][COMP] Fix min/max functions
..


Patch Set 2: Code-Review+2

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3427/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java:

https://asterix-gerrit.ics.uci.edu/#/c/3427/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AbstractCollectionType.java@42
PS2, Line 42: // TODO(ali): this should be removed. itemType is already 
enforced to be NonNull
I think we need to investigate the intent of this method. May be we should do 
"return itemType != ANY" here


https://asterix-gerrit.ics.uci.edu/#/c/3427/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarArrayAggAggregateDescriptor.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarArrayAggAggregateDescriptor.java:

https://asterix-gerrit.ics.uci.edu/#/c/3427/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarArrayAggAggregateDescriptor.java@47
PS2, Line 47: itemType);
> check this just to make sure.
aggFuncDesc is LISTIFY, so this is correct



--
To view, visit https://asterix-gerrit.ics.uci.edu/3427
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1231cfe558099d167bae0b2fa7fc4879b756baf0
Gerrit-Change-Number: 3427
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:02:23 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 20:56:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/bhXBsSczWkFm17keA : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 20:44:13 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8661/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 06 Jun 2019 19:57:58 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2574][COMP] Fix min/max functions

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3427 )

Change subject: [ASTERIXDB-2574][COMP] Fix min/max functions
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/mZmVadGyFniSCUrf6 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3427
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1231cfe558099d167bae0b2fa7fc4879b756baf0
Gerrit-Change-Number: 3427
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 06 Jun 2019 19:09:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4503/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 06 Jun 2019 19:02:45 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/yfvqgqfGEH5pGhxQ6 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 06 Jun 2019 18:49:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4503/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 06 Jun 2019 18:48:28 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5903/ 
(13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 06 Jun 2019 18:45:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5880/
 (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 06 Jun 2019 18:45:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3891/ 
(5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 06 Jun 2019 18:45:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][SQLPP] Support SELECT LET

2019-06-06 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3428 )

Change subject: [NO ISSUE][SQLPP] Support SELECT LET
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8661/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3428
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1226dca83e756075608232c642851f646a9bee3b
Gerrit-Change-Number: 3428
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 06 Jun 2019 18:47:08 +
Gerrit-HasComments: No


  1   2   >